From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>,
cezary.rojewski@intel.com, tiwai@suse.com,
ranjani.sridharan@linux.intel.com,
pierre-louis.bossart@linux.intel.com, perex@perex.cz,
liam.r.girdwood@linux.intel.com, kai.vehmanen@linux.intel.com,
peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec
Date: Wed, 14 Sep 2022 12:27:28 +0200 [thread overview]
Message-ID: <87zgf2tfn3.wl-tiwai@suse.de> (raw)
In-Reply-To: <166314841746.314266.6045600836637107787.b4-ty@kernel.org>
On Wed, 14 Sep 2022 11:40:17 +0200,
Mark Brown wrote:
>
> On Mon, 22 Aug 2022 11:51:33 +0800, Gaosheng Cui wrote:
> > In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n,
> > gcc warns about an unused variable:
> >
> > sound/soc/intel/skylake/skl.c: In function ‘probe_codec’:
> > sound/soc/intel/skylake/skl.c:729:18: error: unused variable ‘skl’ [-Werror=unused-variable]
> > struct skl_dev *skl = bus_to_skl(bus);
> > ^~~
> > cc1: all warnings being treated as errors
> >
> > [...]
>
> Applied to
>
> broonie/sound.git for-next
>
> Thanks!
>
> [1/1] ASoC: Intel: fix unused-variable warning in probe_codec
> commit: 515626a33a194c4caaf2879dbf9e00e882582af0
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
I thought the buggy commit 3fd63658caed9 was present only in my tree
for now, but if it's in your tree, that's fine to apply through
yours. Then I'll drop from mine.
thanks,
Takashi
next prev parent reply other threads:[~2022-09-14 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 3:51 [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec Gaosheng Cui
2022-09-13 14:03 ` Cezary Rojewski
2022-09-13 15:21 ` Takashi Iwai
2022-09-14 9:40 ` Mark Brown
2022-09-14 10:27 ` Takashi Iwai [this message]
2022-09-14 10:31 ` Mark Brown
2022-09-14 10:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgf2tfn3.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cuigaosheng1@huawei.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox