From: Takashi Iwai <tiwai@suse.de>
To: Cezary Rojewski <cezary.rojewski@intel.com>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>,
<pierre-louis.bossart@linux.intel.com>,
<liam.r.girdwood@linux.intel.com>,
<peter.ujfalusi@linux.intel.com>,
<yung-chuan.liao@linux.intel.com>,
<ranjani.sridharan@linux.intel.com>,
<kai.vehmanen@linux.intel.com>, <broonie@kernel.org>,
<perex@perex.cz>, <tiwai@suse.com>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec
Date: Tue, 13 Sep 2022 17:21:40 +0200 [thread overview]
Message-ID: <874jxbfgfv.wl-tiwai@suse.de> (raw)
In-Reply-To: <39b0bfef-be7d-05a9-d964-19a74757bb8d@intel.com>
On Tue, 13 Sep 2022 16:03:35 +0200,
Cezary Rojewski wrote:
>
> On 2022-08-22 5:51 AM, Gaosheng Cui wrote:
> > In configurations with CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC=n,
> > gcc warns about an unused variable:
> >
> > sound/soc/intel/skylake/skl.c: In function ‘probe_codec’:
> > sound/soc/intel/skylake/skl.c:729:18: error: unused variable ‘skl’ [-Werror=unused-variable]
> > struct skl_dev *skl = bus_to_skl(bus);
> > ^~~
> > cc1: all warnings being treated as errors
> >
> > Fixes: 3fd63658caed9 ("ASoC: Intel: Drop hdac_ext usage for codec device creation")
> > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
>
> Thanks for the fix.
>
> Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
Applied now.
Takashi
next prev parent reply other threads:[~2022-09-13 16:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 3:51 [PATCH -next] ASoC: Intel: fix unused-variable warning in probe_codec Gaosheng Cui
2022-09-13 14:03 ` Cezary Rojewski
2022-09-13 15:21 ` Takashi Iwai [this message]
2022-09-14 9:40 ` Mark Brown
2022-09-14 10:27 ` Takashi Iwai
2022-09-14 10:31 ` Mark Brown
2022-09-14 10:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jxbfgfv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cuigaosheng1@huawei.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox