[PATCH] platform/x86: asus-armoury: downgrade missing power limits warning to debug

[PATCH] platform/x86: asus-armoury: downgrade missing power limits warning to debug

[Armandas Kvietkus]

When a system is not found in the power_limits DMI table,
init_rog_tunables() emits a pr_warn() and returns. This is
expected behaviour for hardware that does not support ROG
power limit tunables, not an error condition.

Downgrade to pr_debug() to avoid spurious boot noise on
unsupported systems while preserving the message for debugging.

Reported-by: fxzxaxon@outlook.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
Signed-off-by: Armandas Kvietkus <armundunelis@gmail.com>
---
 drivers/platform/x86/asus-armoury.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
index 5b0987ccc..c8e9ff89f 100644
--- a/drivers/platform/x86/asus-armoury.c
+++ b/drivers/platform/x86/asus-armoury.c
@@ -991,7 +991,7 @@ static void init_rog_tunables(void)
 	/* Match the system against the power_limits table */
 	dmi_id = dmi_first_match(power_limits);
 	if (!dmi_id) {
-		pr_warn("No matching power limits found for this system\n");
+		pr_debug("No matching power limits found for this system\n");
 		return;
 	}
 
-- 
2.54.0

Re: [PATCH] platform/x86: asus-armoury: downgrade missing power limits warning to debug

[Denis Benato]

On 5/3/26 19:57, Armandas Kvietkus wrote:
> When a system is not found in the power_limits DMI table,
> init_rog_tunables() emits a pr_warn() and returns. This is
> expected behaviour for hardware that does not support ROG
> power limit tunables, not an error condition.
>
> Downgrade to pr_debug() to avoid spurious boot noise on
> unsupported systems while preserving the message for debugging.
>
> Reported-by: fxzxaxon@outlook.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
> Signed-off-by: Armandas Kvietkus <armundunelis@gmail.com>
> ---
>  drivers/platform/x86/asus-armoury.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5b0987ccc..c8e9ff89f 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -991,7 +991,7 @@ static void init_rog_tunables(void)
>  	/* Match the system against the power_limits table */
>  	dmi_id = dmi_first_match(power_limits);
>  	if (!dmi_id) {
> -		pr_warn("No matching power limits found for this system\n");
> +		pr_debug("No matching power limits found for this system\n");
I don't agree with this: most distro suppress debug and this warning is very handy to understand what's wrong when people report "missing sliders".
>  		return;
>  	}
>  

Re: [PATCH] platform/x86: asus-armoury: downgrade missing power limits warning to debug

[Denis Benato]

On 5/3/26 19:57, Armandas Kvietkus wrote:
> When a system is not found in the power_limits DMI table,
> init_rog_tunables() emits a pr_warn() and returns. This is
> expected behaviour for hardware that does not support ROG
> power limit tunables, not an error condition.
>
> Downgrade to pr_debug() to avoid spurious boot noise on
> unsupported systems while preserving the message for debugging.
>
> Reported-by: fxzxaxon@outlook.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
> Signed-off-by: Armandas Kvietkus <armundunelis@gmail.com>
> ---
>  drivers/platform/x86/asus-armoury.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5b0987ccc..c8e9ff89f 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -991,7 +991,7 @@ static void init_rog_tunables(void)
>  	/* Match the system against the power_limits table */
>  	dmi_id = dmi_first_match(power_limits);
>  	if (!dmi_id) {
> -		pr_warn("No matching power limits found for this system\n");
> +		pr_debug("No matching power limits found for this system\n");
Maybe this is right to get downgraded, but still no debug: I think info is better,
but I would like to hear from Luke what this is about.

Denis
>  		return;
>  	}
>