From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Allison Karlitskaya <allison.karlitskaya@redhat.com>,
Chao Yu <chao@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by_dev()
Date: Tue, 8 Oct 2024 21:12:23 +0800 [thread overview]
Message-ID: <9774de2b-2bd6-443e-b502-2c1dd3ccf0a8@linux.alibaba.com> (raw)
In-Reply-To: <ZwUr2HthVw9Hc1ke@infradead.org>
On 2024/10/8 20:55, Christoph Hellwig wrote:
> On Tue, Oct 08, 2024 at 08:33:27PM +0800, Gao Xiang wrote:
>> how about
>> int get_tree_bdev_flags(struct fs_context *fc,
>> int (*fill_super)(struct super_block *,
>> struct fs_context *), bool quiet)
>>
>> for now? it can be turned into `int flags` if other needs
>> are shown later (and I don't need to define an enum.)
>
> I'd pass an unsigned int flags with a clearly spellt out (and
> extensible) flags namespae.
okay, got it.
Thanks,
Gao Xiang
prev parent reply other threads:[~2024-10-08 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 9:56 [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by_dev() Gao Xiang
2024-10-08 9:56 ` [PATCH 2/2] erofs: use get_tree_bdev_by_dev() to avoid misleading messages Gao Xiang
2024-10-08 11:49 ` [PATCH 1/2] fs/super.c: introduce get_tree_bdev_by_dev() Christoph Hellwig
2024-10-08 12:10 ` Gao Xiang
2024-10-08 12:23 ` Christoph Hellwig
2024-10-08 12:33 ` Gao Xiang
2024-10-08 12:55 ` Christoph Hellwig
2024-10-08 13:12 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9774de2b-2bd6-443e-b502-2c1dd3ccf0a8@linux.alibaba.com \
--to=hsiangkao@linux.alibaba.com \
--cc=allison.karlitskaya@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox