* [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK
@ 2023-08-15 15:28 Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2023-08-15 15:28 UTC (permalink / raw)
To: Vinod Koul, Kishon Vijay Abraham I, Greg Kroah-Hartman,
Stanley Chang
Cc: linux-phy, linux-kernel, Geert Uytterhoeven
The Realtek SoC USB2 and USB3 PHY Transceivers are only present on
Realtek Digital Home Center (DHC) RTD series SoCs. Hence add a
dependency on ARCH_REALTEK, to prevent asking the user about these
drivers when configuring a kernel without Realtek SoC support.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/phy/realtek/Kconfig | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig
index 650e20ed69af41d2..75ac7e7c31aec6f2 100644
--- a/drivers/phy/realtek/Kconfig
+++ b/drivers/phy/realtek/Kconfig
@@ -2,6 +2,9 @@
#
# Phy drivers for Realtek platforms
#
+
+if ARCH_REALTEK || COMPILE_TEST
+
config PHY_RTK_RTD_USB2PHY
tristate "Realtek RTD USB2 PHY Transceiver Driver"
depends on USB_SUPPORT
@@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
The DHC (digital home center) RTD series SoCs used the Synopsys
DWC3 USB IP. This driver will do the PHY initialization
of the parameters.
+
+endif # ARCH_REALTEK || COMPILE_TEST
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK
[not found] <202308161422.37GEMlZkA018197@rtits1.realtek.com.tw>
@ 2023-08-17 2:06 ` Stanley Chang[昌育德]
2023-08-17 6:46 ` Vinod Koul
0 siblings, 1 reply; 6+ messages in thread
From: Stanley Chang[昌育德] @ 2023-08-17 2:06 UTC (permalink / raw)
To: Geert Uytterhoeven, Vinod Koul, Kishon Vijay Abraham I,
Greg Kroah-Hartman
Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Hi Geert,
> diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> --- a/drivers/phy/realtek/Kconfig
> +++ b/drivers/phy/realtek/Kconfig
> @@ -2,6 +2,9 @@
> #
> # Phy drivers for Realtek platforms
> #
> +
> +if ARCH_REALTEK || COMPILE_TEST
> +
> config PHY_RTK_RTD_USB2PHY
> tristate "Realtek RTD USB2 PHY Transceiver Driver"
> depends on USB_SUPPORT
> @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> The DHC (digital home center) RTD series SoCs used the Synopsys
> DWC3 USB IP. This driver will do the PHY initialization
> of the parameters.
> +
> +endif # ARCH_REALTEK || COMPILE_TEST
Thanks for your patch.
Why not use "depends on"?
depends on ARCH_MEDIATEK || COMPILE_TEST
Thanks,
Stanley
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK
2023-08-17 2:06 ` [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK Stanley Chang[昌育德]
@ 2023-08-17 6:46 ` Vinod Koul
2023-08-17 6:53 ` Stanley Chang[昌育德]
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Vinod Koul @ 2023-08-17 6:46 UTC (permalink / raw)
To: Stanley Chang[昌育德]
Cc: Geert Uytterhoeven, Kishon Vijay Abraham I, Greg Kroah-Hartman,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
On 17-08-23, 02:06, Stanley Chang[昌育德] wrote:
> Hi Geert,
>
> > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > --- a/drivers/phy/realtek/Kconfig
> > +++ b/drivers/phy/realtek/Kconfig
> > @@ -2,6 +2,9 @@
> > #
> > # Phy drivers for Realtek platforms
> > #
> > +
> > +if ARCH_REALTEK || COMPILE_TEST
> > +
> > config PHY_RTK_RTD_USB2PHY
> > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > depends on USB_SUPPORT
> > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > The DHC (digital home center) RTD series SoCs used the Synopsys
> > DWC3 USB IP. This driver will do the PHY initialization
> > of the parameters.
> > +
> > +endif # ARCH_REALTEK || COMPILE_TEST
>
> Thanks for your patch.
> Why not use "depends on"?
> depends on ARCH_MEDIATEK || COMPILE_TEST
I think this patch is better, this way all future rtek drivers will be
fixed as well, no need to add for each driver
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK
2023-08-17 6:46 ` Vinod Koul
@ 2023-08-17 6:53 ` Stanley Chang[昌育德]
2023-08-17 7:31 ` Geert Uytterhoeven
2023-09-28 7:56 ` Geert Uytterhoeven
2 siblings, 0 replies; 6+ messages in thread
From: Stanley Chang[昌育德] @ 2023-08-17 6:53 UTC (permalink / raw)
To: Vinod Koul
Cc: Geert Uytterhoeven, Kishon Vijay Abraham I, Greg Kroah-Hartman,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
> > > diff --git a/drivers/phy/realtek/Kconfig
> > > b/drivers/phy/realtek/Kconfig index
> > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > > --- a/drivers/phy/realtek/Kconfig
> > > +++ b/drivers/phy/realtek/Kconfig
> > > @@ -2,6 +2,9 @@
> > > #
> > > # Phy drivers for Realtek platforms #
> > > +
> > > +if ARCH_REALTEK || COMPILE_TEST
> > > +
> > > config PHY_RTK_RTD_USB2PHY
> > > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > > depends on USB_SUPPORT
> > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > > The DHC (digital home center) RTD series SoCs used the
> Synopsys
> > > DWC3 USB IP. This driver will do the PHY initialization
> > > of the parameters.
> > > +
> > > +endif # ARCH_REALTEK || COMPILE_TEST
> >
> > Thanks for your patch.
> > Why not use "depends on"?
> > depends on ARCH_MEDIATEK || COMPILE_TEST
>
> I think this patch is better, this way all future rtek drivers will be fixed as well,
> no need to add for each driver
>
Ok, thanks,
Stanley
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK
2023-08-17 6:46 ` Vinod Koul
2023-08-17 6:53 ` Stanley Chang[昌育德]
@ 2023-08-17 7:31 ` Geert Uytterhoeven
2023-09-28 7:56 ` Geert Uytterhoeven
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2023-08-17 7:31 UTC (permalink / raw)
To: Vinod Koul
Cc: Stanley Chang[昌育德], Kishon Vijay Abraham I,
Greg Kroah-Hartman, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi Vinod,
On Thu, Aug 17, 2023 at 8:46 AM Vinod Koul <vkoul@kernel.org> wrote:
> On 17-08-23, 02:06, Stanley Chang[昌育德] wrote:
> > > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > > --- a/drivers/phy/realtek/Kconfig
> > > +++ b/drivers/phy/realtek/Kconfig
> > > @@ -2,6 +2,9 @@
> > > #
> > > # Phy drivers for Realtek platforms
> > > #
> > > +
> > > +if ARCH_REALTEK || COMPILE_TEST
> > > +
> > > config PHY_RTK_RTD_USB2PHY
> > > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > > depends on USB_SUPPORT
> > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > > The DHC (digital home center) RTD series SoCs used the Synopsys
> > > DWC3 USB IP. This driver will do the PHY initialization
> > > of the parameters.
> > > +
> > > +endif # ARCH_REALTEK || COMPILE_TEST
> >
> > Thanks for your patch.
> > Why not use "depends on"?
> > depends on ARCH_MEDIATEK || COMPILE_TEST
>
> I think this patch is better, this way all future rtek drivers will be
> fixed as well, no need to add for each driver
Indeed.
The only caveat is future non-on-SoC Realtek PHY drivers: they
should be added outside the if/endif block.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK
2023-08-17 6:46 ` Vinod Koul
2023-08-17 6:53 ` Stanley Chang[昌育德]
2023-08-17 7:31 ` Geert Uytterhoeven
@ 2023-09-28 7:56 ` Geert Uytterhoeven
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2023-09-28 7:56 UTC (permalink / raw)
To: Vinod Koul
Cc: Stanley Chang[昌育德], Kishon Vijay Abraham I,
Greg Kroah-Hartman, linux-phy@lists.infradead.org,
linux-kernel@vger.kernel.org
Hi Vinod,
On Thu, Aug 17, 2023 at 8:46 AM Vinod Koul <vkoul@kernel.org> wrote:
> On 17-08-23, 02:06, Stanley Chang[昌育德] wrote:
> > > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > > --- a/drivers/phy/realtek/Kconfig
> > > +++ b/drivers/phy/realtek/Kconfig
> > > @@ -2,6 +2,9 @@
> > > #
> > > # Phy drivers for Realtek platforms
> > > #
> > > +
> > > +if ARCH_REALTEK || COMPILE_TEST
> > > +
> > > config PHY_RTK_RTD_USB2PHY
> > > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > > depends on USB_SUPPORT
> > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > > The DHC (digital home center) RTD series SoCs used the Synopsys
> > > DWC3 USB IP. This driver will do the PHY initialization
> > > of the parameters.
> > > +
> > > +endif # ARCH_REALTEK || COMPILE_TEST
> >
> > Thanks for your patch.
> > Why not use "depends on"?
> > depends on ARCH_MEDIATEK || COMPILE_TEST
>
> I think this patch is better, this way all future rtek drivers will be
> fixed as well, no need to add for each driver
Is there anything still blocking this patch?
Do you want me to resend?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-28 7:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202308161422.37GEMlZkA018197@rtits1.realtek.com.tw>
2023-08-17 2:06 ` [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK Stanley Chang[昌育德]
2023-08-17 6:46 ` Vinod Koul
2023-08-17 6:53 ` Stanley Chang[昌育德]
2023-08-17 7:31 ` Geert Uytterhoeven
2023-09-28 7:56 ` Geert Uytterhoeven
2023-08-15 15:28 Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox