* [PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS
@ 2026-05-02 19:19 Julian Braha
2026-05-05 14:21 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2026-05-02 19:19 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
simona
Cc: intel-gfx, dri-devel, linux-kernel, Julian Braha
DRM_I915_SW_FENCE_DEBUG_OBJECTS currently selects DEBUG_OBJECTS even though
DEBUG_OBJECTS is visible to users. Other config options use 'depends on'
for DEBUG_OBJECTS, so let's do the same here.
This select-visible Kconfig misusage was detected by Kconfirm, a static
analysis tool for Kconfig.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/gpu/drm/i915/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
index 52a3a59b4ba2..028a2c97361d 100644
--- a/drivers/gpu/drm/i915/Kconfig.debug
+++ b/drivers/gpu/drm/i915/Kconfig.debug
@@ -153,7 +153,7 @@ config DRM_I915_TRACE_GTT
config DRM_I915_SW_FENCE_DEBUG_OBJECTS
bool "Enable additional driver debugging for fence objects"
depends on DRM_I915
- select DEBUG_OBJECTS
+ depends on DEBUG_OBJECTS
default n
help
Choose this option to turn on extra driver debugging that may affect
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS
2026-05-02 19:19 [PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS Julian Braha
@ 2026-05-05 14:21 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2026-05-05 14:21 UTC (permalink / raw)
To: Julian Braha, joonas.lahtinen, rodrigo.vivi, tursulin, airlied,
simona
Cc: intel-gfx, dri-devel, linux-kernel, Julian Braha
On Sat, 02 May 2026, Julian Braha <julianbraha@gmail.com> wrote:
> DRM_I915_SW_FENCE_DEBUG_OBJECTS currently selects DEBUG_OBJECTS even though
> DEBUG_OBJECTS is visible to users. Other config options use 'depends on'
> for DEBUG_OBJECTS, so let's do the same here.
>
> This select-visible Kconfig misusage was detected by Kconfirm, a static
> analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Thanks for the patch, pushed to drm-intel-next.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index 52a3a59b4ba2..028a2c97361d 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -153,7 +153,7 @@ config DRM_I915_TRACE_GTT
> config DRM_I915_SW_FENCE_DEBUG_OBJECTS
> bool "Enable additional driver debugging for fence objects"
> depends on DRM_I915
> - select DEBUG_OBJECTS
> + depends on DEBUG_OBJECTS
> default n
> help
> Choose this option to turn on extra driver debugging that may affect
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-05 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-02 19:19 [PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS Julian Braha
2026-05-05 14:21 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox