checkpatch false positive for "do not use assignment in if condition"

checkpatch false positive for "do not use assignment in if condition"

[Ethan Nelson-Moore]

Hello,

I got a strange error from checkpatch while preparing this patch for submission:
https://lore.kernel.org/all/20260509214622.38319-1-enelsonmoore@gmail.com/

ERROR: do not use assignment in if condition
#37: FILE: sound/soc/fsl/eukrea-tlv320.c:145:
+       if (of_machine_is_compatible("eukrea,cpuimx27") ||

ERROR: do not use assignment in if condition
#48: FILE: sound/soc/fsl/eukrea-tlv320.c:162:
+       } else if (of_machine_is_compatible("eukrea,cpuimx25") ||

These lines do not even contain =.
Could someone look into why this happened?

Have a nice day!
Ethan

Re: checkpatch false positive for "do not use assignment in if condition"

[Ethan Nelson-Moore]

On Sat, May 9, 2026 at 2:53 PM Ethan Nelson-Moore
<enelsonmoore@gmail.com> wrote:
> These lines do not even contain =.
> Could someone look into why this happened?

The lines *after* the affected patch hunks do have an assignment in
the if condition.

Ethan

Re: checkpatch false positive for "do not use assignment in if condition"

[Joe Perches]

On 2026-05-09 17:20, Ethan Nelson-Moore wrote:
> On Sat, May 9, 2026 at 2:53 PM Ethan Nelson-Moore
> <enelsonmoore@gmail.com> wrote:
>> These lines do not even contain =.
>> Could someone look into why this happened?
> 
> The lines *after* the affected patch hunks do have an assignment in
> the if condition.

checkpatch is fundamentally stupid and an incomplete parser.   Rely on 
your brain to ignore its incorrect bleats when it's wrong.

FYI it's looking for a single equal sign in the statement