The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Chen, Yu C" <yu.c.chen@intel.com>
To: Reinette Chatre <reinette.chatre@intel.com>
Cc: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Newman <peternewman@google.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Dave Martin <Dave.Martin@arm.com>,
	Ben Horgan <ben.horgan@arm.com>,
	James Morse <james.morse@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	Drew Fustini <fustini@kernel.org>,
	Fenghua Yu <fenghuay@nvidia.com>,
	"chen.yu@linux.dev" <chen.yu@linux.dev>
Subject: Re: [RFC v2] arm,x86,fs/resctrl: Generic schema description Proof of Concept
Date: Mon, 10 Aug 2026 10:05:09 +0800	[thread overview]
Message-ID: <9e38f138-7872-445d-9a11-105f9d0fa4d0@intel.com> (raw)
In-Reply-To: <d258a32f-12d5-464d-abe9-4720fb3e44b3@intel.com>

Hi Reinette,

Thank you very much for providing this version,

On 8/4/2026 1:26 PM, Reinette Chatre wrote:

> - Only "SAMPLE" code provided for x86 to demonstrate emulated controls.

> - Add relationships between controls. For example, cannot set "MIN" control
>    value to be larger than "MAX. Unclear how to do this in resctrl fs when
>    considering that the relationship may span between enabled and disabled
>    controls. This is potentially something that needs to be managed by architecture
>    and thus potentially without a consistent failure to user space.
>                                                                                  

I have tested this version, and it exhibits the expected
behavior according to my understanding:

The following is the legacy schemata:
[root@ resctrl]# cat schemata
             MB:0=100;1=100;2=100;3=100

and the following is the native schemata:
[root@ resctrl]# echo native > /sys/fs/resctrl/info/MB/control_mode
[root@ resctrl]# cat schemata
MB_REGION0_MAX:0=200;1=200;2=200;3=200
MB_REGION0_MIN:0=1;1=1;2=1;3=1

I have a minor question I'd like to confirm:

item 1.
In legacy mode, we intend to always let the "native" controller
emulate the "legacy" controller - at least for the region‑aware
RDT case.
Q1: Is this understanding correct?

item 2.
In commit fbed64f80515 ("x86/resctrl: SAMPLE: Emulated controls"),
during resctrl initialization, __get_mem_config_intel() clears
the legacy controller's hw_ctrl->msr_update to NULL, and sets
its emulation controllers in hw_ctrl->r_ctrl.emulated_by to
the region-aware related controllers. So legacy controller is
emulated by region-aware controllers.

item 3.
In resctrl_arch_control_mode_set(), when switching to "legacy"
mode, the legacy controller is set to:
hw_ctrl->msr_update = update_temporary_legacy_MB;
while the emulating controller is set to NULL:
hw_ctrl->msr_update = NULL;
That means, the emulated controllers will not take effect.

Q2:Does item 3 contradict item 1?


thanks,
Chenyu

  parent reply	other threads:[~2026-08-10  2:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  5:26 [RFC v2] arm,x86,fs/resctrl: Generic schema description Proof of Concept Reinette Chatre
2026-08-05 16:59 ` Ben Horgan
2026-08-05 23:57   ` Reinette Chatre
2026-08-06 17:04     ` Luck, Tony
2026-08-06 17:11       ` Reinette Chatre
2026-08-07 14:14         ` Moger, Babu
2026-08-07 15:35           ` Reinette Chatre
2026-08-07 18:33             ` Moger, Babu
2026-08-07 22:53               ` Reinette Chatre
2026-08-10 18:52                 ` Babu Moger
2026-08-07 15:35           ` Chen, Yu C
2026-08-07 17:57             ` Moger, Babu
2026-08-10  2:05 ` Chen, Yu C [this message]
2026-08-10 15:53   ` Reinette Chatre
2026-08-10 17:23     ` Chen, Yu C
2026-08-10 18:09       ` Reinette Chatre
2026-08-11  3:49         ` Chen, Yu C
2026-08-10  2:55 ` Fenghua Yu
2026-08-10  3:02   ` Chen, Yu C
2026-08-10  3:25     ` Fenghua Yu
2026-08-10  5:24       ` Chen, Yu C
2026-08-10 15:53   ` Reinette Chatre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e38f138-7872-445d-9a11-105f9d0fa4d0@intel.com \
    --to=yu.c.chen@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=bp@alien8.de \
    --cc=chen.yu@linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=fustini@kernel.org \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox