[PATCH] rust_binder: use pin_init::zeroed for file_operations initialization

[PATCH] rust_binder: use pin_init::zeroed for file_operations initialization

[Nicolás Antinori]

All types in `bindings` implement `Zeroable` if they can. This enables
using `pin_init::zeroed()` for `file_operations` initialization instead
of relying on `unsafe { core::mem::MaybeUninit::zeroed().assume_init() }`.

This change improves readability and removes an unnecessary unsafe
block.

Link: https://github.com/Rust-for-Linux/linux/issues/1189
Suggested-by: Benno Lossin <lossin@kernel.org>
Signed-off-by: Nicolás Antinori <nico.antinori.7@gmail.com>
---
 drivers/android/binder/rust_binder_main.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/android/binder/rust_binder_main.rs b/drivers/android/binder/rust_binder_main.rs
index dc1941cd2407..7f07fb5e171b 100644
--- a/drivers/android/binder/rust_binder_main.rs
+++ b/drivers/android/binder/rust_binder_main.rs
@@ -314,8 +314,7 @@ unsafe impl<T> Sync for AssertSync<T> {}
 #[no_mangle]
 #[used]
 pub static rust_binder_fops: AssertSync<kernel::bindings::file_operations> = {
-    // SAFETY: All zeroes is safe for the `file_operations` type.
-    let zeroed_ops = unsafe { core::mem::MaybeUninit::zeroed().assume_init() };
+    let zeroed_ops = pin_init::zeroed();

     let ops = kernel::bindings::file_operations {
         owner: THIS_MODULE.as_ptr(),
--
2.47.3

Re: [PATCH] rust_binder: use pin_init::zeroed for file_operations initialization

[Alexandre Courbot]

On Sat Jun 27, 2026 at 6:44 AM JST, Nicolás Antinori wrote:
> All types in `bindings` implement `Zeroable` if they can. This enables
> using `pin_init::zeroed()` for `file_operations` initialization instead
> of relying on `unsafe { core::mem::MaybeUninit::zeroed().assume_init() }`.
>
> This change improves readability and removes an unnecessary unsafe
> block.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Suggested-by: Benno Lossin <lossin@kernel.org>
> Signed-off-by: Nicolás Antinori <nico.antinori.7@gmail.com>

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

Re: [PATCH] rust_binder: use pin_init::zeroed for file_operations initialization

[Miguel Ojeda]

On Fri, Jun 26, 2026 at 11:44 PM Nicolás Antinori
<nico.antinori.7@gmail.com> wrote:
>
> -    // SAFETY: All zeroes is safe for the `file_operations` type.
> -    let zeroed_ops = unsafe { core::mem::MaybeUninit::zeroed().assume_init() };
> +    let zeroed_ops = pin_init::zeroed();

I would just remove the variable and put `zeroed()` directly in the
fops initializer like we do in other cases, but it is fine of course.

I guess it will go through Binder, but if `rust-next` is preferred,
please let me know.

Thanks!

Cheers,
Miguel

Re: [PATCH] rust_binder: use pin_init::zeroed for file_operations initialization

[Nicolás Antinori]

On Sun Jun 28, 2026 at 7:16 AM -03, Miguel Ojeda wrote:
> On Fri, Jun 26, 2026 at 11:44 PM Nicolás Antinori
> <nico.antinori.7@gmail.com> wrote:
>>
>> -    // SAFETY: All zeroes is safe for the `file_operations` type.
>> -    let zeroed_ops = unsafe { core::mem::MaybeUninit::zeroed().assume_init() };
>> +    let zeroed_ops = pin_init::zeroed();
>
> I would just remove the variable and put `zeroed()` directly in the
> fops initializer like we do in other cases, but it is fine of course.

I thought of that as well but I tried to touch as little as possible (I
assumed that was in a variable for a reason). I can send a v2 if that is 
preferred!

Thank you,
Nicolás