* [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0
@ 2022-10-06 5:27 Christophe Leroy
2022-11-10 13:25 ` Christophe Leroy
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2022-10-06 5:27 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Christophe Leroy, linux-kernel, linuxppc-dev
NO_IRQ is used to check the return of irq_of_parse_and_map().
On some architecture NO_IRQ is 0, on other architectures it is -1.
irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
So use 0 instead of using NO_IRQ.
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
---
drivers/virt/fsl_hypervisor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
index 07035249a5e1..f8b4389d60d9 100644
--- a/drivers/virt/fsl_hypervisor.c
+++ b/drivers/virt/fsl_hypervisor.c
@@ -839,7 +839,7 @@ static int __init fsl_hypervisor_init(void)
handle = of_get_property(np, "interrupts", NULL);
irq = irq_of_parse_and_map(np, 0);
- if (!handle || (irq == NO_IRQ)) {
+ if (!handle || !irq) {
pr_err("fsl-hv: no 'interrupts' property in %pOF node\n",
np);
continue;
--
2.37.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0
2022-10-06 5:27 [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0 Christophe Leroy
@ 2022-11-10 13:25 ` Christophe Leroy
2022-11-10 14:33 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2022-11-10 13:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Hi Greg,
Le 06/10/2022 à 07:27, Christophe Leroy a écrit :
> NO_IRQ is used to check the return of irq_of_parse_and_map().
>
> On some architecture NO_IRQ is 0, on other architectures it is -1.
>
> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>
> So use 0 instead of using NO_IRQ.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Do you plan to apply this patch, or is any change required ?
Thanks
Christophe
> ---
> drivers/virt/fsl_hypervisor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virt/fsl_hypervisor.c b/drivers/virt/fsl_hypervisor.c
> index 07035249a5e1..f8b4389d60d9 100644
> --- a/drivers/virt/fsl_hypervisor.c
> +++ b/drivers/virt/fsl_hypervisor.c
> @@ -839,7 +839,7 @@ static int __init fsl_hypervisor_init(void)
>
> handle = of_get_property(np, "interrupts", NULL);
> irq = irq_of_parse_and_map(np, 0);
> - if (!handle || (irq == NO_IRQ)) {
> + if (!handle || !irq) {
> pr_err("fsl-hv: no 'interrupts' property in %pOF node\n",
> np);
> continue;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0
2022-11-10 13:25 ` Christophe Leroy
@ 2022-11-10 14:33 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-11-10 14:33 UTC (permalink / raw)
To: Christophe Leroy
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
On Thu, Nov 10, 2022 at 01:25:14PM +0000, Christophe Leroy wrote:
> Hi Greg,
>
> Le 06/10/2022 à 07:27, Christophe Leroy a écrit :
> > NO_IRQ is used to check the return of irq_of_parse_and_map().
> >
> > On some architecture NO_IRQ is 0, on other architectures it is -1.
> >
> > irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
> >
> > So use 0 instead of using NO_IRQ.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Do you plan to apply this patch, or is any change required ?
It is in my review queue, give me time to catch up...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-10 14:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-06 5:27 [PATCH] virt: fsl_hypervisor: Replace NO_IRQ by 0 Christophe Leroy
2022-11-10 13:25 ` Christophe Leroy
2022-11-10 14:33 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox