* [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses
@ 2022-11-17 13:02 Krzysztof Kozlowski
2022-11-17 14:28 ` Stephan Gerhold
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-17 13:02 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Rob Herring, Krzysztof Kozlowski, linux-pm, linux-arm-msm,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski, Neil Armstrong
Most of the device-specific compatibles have generic fallbacks like
qcom,tsens-v1 or qcom,tsens-v2. The if:then: block mentions these
fallbacks, so drop redundant entries for specific compatibles.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Neil Armstrong <neil.armstrong@linaro.org>
---
.../devicetree/bindings/thermal/qcom-tsens.yaml | 16 ----------------
1 file changed, 16 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index f0bd4b979e28..c9949713f714 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -118,12 +118,7 @@ allOf:
contains:
enum:
- qcom,ipq8064-tsens
- - qcom,mdm9607-tsens
- - qcom,msm8916-tsens
- qcom,msm8960-tsens
- - qcom,msm8974-tsens
- - qcom,msm8976-tsens
- - qcom,qcs404-tsens
- qcom,tsens-v0_1
- qcom,tsens-v1
then:
@@ -140,17 +135,6 @@ allOf:
compatible:
contains:
enum:
- - qcom,msm8953-tsens
- - qcom,msm8996-tsens
- - qcom,msm8998-tsens
- - qcom,sc7180-tsens
- - qcom,sc7280-tsens
- - qcom,sc8180x-tsens
- - qcom,sdm630-tsens
- - qcom,sdm845-tsens
- - qcom,sm8150-tsens
- - qcom,sm8250-tsens
- - qcom,sm8350-tsens
- qcom,tsens-v2
then:
properties:
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses
2022-11-17 13:02 [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses Krzysztof Kozlowski
@ 2022-11-17 14:28 ` Stephan Gerhold
2022-11-17 15:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Stephan Gerhold @ 2022-11-17 14:28 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Amit Kucheria, Thara Gopinath, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Rob Herring, Krzysztof Kozlowski, linux-pm, linux-arm-msm,
devicetree, linux-kernel, Neil Armstrong
On Thu, Nov 17, 2022 at 02:02:54PM +0100, Krzysztof Kozlowski wrote:
> Most of the device-specific compatibles have generic fallbacks like
> qcom,tsens-v1 or qcom,tsens-v2. The if:then: block mentions these
> fallbacks, so drop redundant entries for specific compatibles.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> .../devicetree/bindings/thermal/qcom-tsens.yaml | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index f0bd4b979e28..c9949713f714 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -118,12 +118,7 @@ allOf:
> contains:
> enum:
> - qcom,ipq8064-tsens
> - - qcom,mdm9607-tsens
> - - qcom,msm8916-tsens
> - qcom,msm8960-tsens
> - - qcom,msm8974-tsens
> - - qcom,msm8976-tsens
> - - qcom,qcs404-tsens
> - qcom,tsens-v0_1
> - qcom,tsens-v1
> then:
FWIW: I submitted the same patch for this part a couple of months ago,
it was never applied for some reason:
https://lore.kernel.org/linux-arm-msm/20220627131415.2868938-2-stephan.gerhold@kernkonzept.com/
> @@ -140,17 +135,6 @@ allOf:
> compatible:
> contains:
> enum:
> - - qcom,msm8953-tsens
> - - qcom,msm8996-tsens
> - - qcom,msm8998-tsens
> - - qcom,sc7180-tsens
> - - qcom,sc7280-tsens
> - - qcom,sc8180x-tsens
> - - qcom,sdm630-tsens
> - - qcom,sdm845-tsens
> - - qcom,sm8150-tsens
> - - qcom,sm8250-tsens
> - - qcom,sm8350-tsens
> - qcom,tsens-v2
> then:
> properties:
>
This part was not present back then though. Looks like this was
introduced recently in "dt-bindings: thermal: tsens: Add ipq8074
compatible".
I don't mind if you take this patch instead of mine. Feel free to add my
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
Thanks,
Stephan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses
2022-11-17 14:28 ` Stephan Gerhold
@ 2022-11-17 15:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-17 15:31 UTC (permalink / raw)
To: Stephan Gerhold
Cc: Amit Kucheria, Thara Gopinath, Andy Gross, Bjorn Andersson,
Konrad Dybcio, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Rob Herring, Krzysztof Kozlowski, linux-pm, linux-arm-msm,
devicetree, linux-kernel, Neil Armstrong
On 17/11/2022 15:28, Stephan Gerhold wrote:
> On Thu, Nov 17, 2022 at 02:02:54PM +0100, Krzysztof Kozlowski wrote:
>> Most of the device-specific compatibles have generic fallbacks like
>> qcom,tsens-v1 or qcom,tsens-v2. The if:then: block mentions these
>> fallbacks, so drop redundant entries for specific compatibles.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>> .../devicetree/bindings/thermal/qcom-tsens.yaml | 16 ----------------
>> 1 file changed, 16 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> index f0bd4b979e28..c9949713f714 100644
>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>> @@ -118,12 +118,7 @@ allOf:
>> contains:
>> enum:
>> - qcom,ipq8064-tsens
>> - - qcom,mdm9607-tsens
>> - - qcom,msm8916-tsens
>> - qcom,msm8960-tsens
>> - - qcom,msm8974-tsens
>> - - qcom,msm8976-tsens
>> - - qcom,qcs404-tsens
>> - qcom,tsens-v0_1
>> - qcom,tsens-v1
>> then:
>
> FWIW: I submitted the same patch for this part a couple of months ago,
> it was never applied for some reason:
> https://lore.kernel.org/linux-arm-msm/20220627131415.2868938-2-stephan.gerhold@kernkonzept.com/
Indeed, somehow Daniel didn't take it. Your patch should go instead, if
you rebase and include new hunks (like my patch).
>
>> @@ -140,17 +135,6 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> - - qcom,msm8953-tsens
>> - - qcom,msm8996-tsens
>> - - qcom,msm8998-tsens
>> - - qcom,sc7180-tsens
>> - - qcom,sc7280-tsens
>> - - qcom,sc8180x-tsens
>> - - qcom,sdm630-tsens
>> - - qcom,sdm845-tsens
>> - - qcom,sm8150-tsens
>> - - qcom,sm8250-tsens
>> - - qcom,sm8350-tsens
>> - qcom,tsens-v2
>> then:
>> properties:
>>
>
> This part was not present back then though. Looks like this was
> introduced recently in "dt-bindings: thermal: tsens: Add ipq8074
> compatible".
>
> I don't mind if you take this patch instead of mine. Feel free to add my
>
> Reviewed-by: Stephan Gerhold <stephan@gerhold.net>
>
> Thanks,
> Stephan
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-17 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-17 13:02 [PATCH] dt-bindings: thermal: qcom-tsens: simplify if:then: clauses Krzysztof Kozlowski
2022-11-17 14:28 ` Stephan Gerhold
2022-11-17 15:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox