From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] random: use raw spinlocks for use on RT
Date: Thu, 11 Aug 2022 09:15:11 +0200 [thread overview]
Message-ID: <YvSsf5uds7zGgWPX@linutronix.de> (raw)
In-Reply-To: <YvRKm/IpbUID18FK@zx2c4.com>
On 2022-08-11 02:17:31 [+0200], Jason A. Donenfeld wrote:
> Hey Sebastian,
Hi Jason,
> > > Sebastian - I won't move forward with this without your Ack, obviously.
> > > What do you think of this general approach? -Jason
> >
> > I would need to do worst-case measurements and I've been looking at this
> > just before writting the other email and there was a local_lock_t
> > somewhere which needs also change…
>
> Did you ever come up some measurements here? It sure would be nice if I
> could apply this, but obviously that's contingent on you saying it's
> okay latency-wise on RT.
No, I did not. But I've been thinking a little about it. The worst case
latency is important now and later.
Looking at it, all we need is one init in vsprintf at boot time and we
are done. That is the third fallout that I am aware of since the rework
of get_random_*().
We managed to get rid of all memory allocations (including GFP_ATOMIC)
from preempt/IRQ-off section on PREEMPT_RT. Therefore I am not convinced
to make all locks in random core a raw_spinlock_t just to make things
work here as of now.
> Jason
Sebastian
next prev parent reply other threads:[~2022-08-11 7:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 14:25 [PATCH] random: use raw spinlocks for use on RT Jason A. Donenfeld
2022-08-01 14:34 ` Sebastian Andrzej Siewior
2022-08-01 14:41 ` Jason A. Donenfeld
2022-08-11 0:17 ` Jason A. Donenfeld
2022-08-11 7:15 ` Sebastian Andrzej Siewior [this message]
2022-08-11 14:20 ` Jason A. Donenfeld
2022-08-15 10:26 ` David Laight
2022-08-16 14:02 ` Jason A. Donenfeld
2022-08-29 19:45 ` Sebastian Andrzej Siewior
2022-08-29 19:56 ` Jason A. Donenfeld
2022-08-30 10:13 ` Sebastian Andrzej Siewior
2022-08-30 15:24 ` Jason A. Donenfeld
2022-08-30 18:57 ` Sebastian Andrzej Siewior
2022-08-31 16:27 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvSsf5uds7zGgWPX@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=Jason@zx2c4.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox