* Re: [PATCH] mm: add build-time option to set hotplug default type [not found] ` <3775fe9c-460e-4b31-9d5c-068a1f685513@redhat.com> @ 2024-12-20 18:25 ` Gregory Price 2024-12-20 18:26 ` David Hildenbrand [not found] ` <Z2WdXY1fvgrDkegw@gourry-fedora-PF4VCD3F> 1 sibling, 1 reply; 3+ messages in thread From: Gregory Price @ 2024-12-20 18:25 UTC (permalink / raw) To: David Hildenbrand Cc: Gregory Price, linux-mm, linux-kernel, osalvador, gregkh, rafael, akpm On Fri, Dec 20, 2024 at 05:04:42PM +0100, David Hildenbrand wrote: > On 20.12.24 15:45, Gregory Price wrote: > > Please call these "default_online_type". Further keep the "mhp" terminology, > it's more commonly used. We cannot rename the "memhp_default_state" > parameter name unfortunately. > fyi for v2 - i went ahead and cleaned this up (not including the param), but basically also synced the build option with the boot parameter: - offline - online ("Auto") - online_kernel - online_movable Figured might as well. Sending shortly ~Gregory ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: add build-time option to set hotplug default type 2024-12-20 18:25 ` [PATCH] mm: add build-time option to set hotplug default type Gregory Price @ 2024-12-20 18:26 ` David Hildenbrand 0 siblings, 0 replies; 3+ messages in thread From: David Hildenbrand @ 2024-12-20 18:26 UTC (permalink / raw) To: Gregory Price; +Cc: linux-mm, linux-kernel, osalvador, gregkh, rafael, akpm On 20.12.24 19:25, Gregory Price wrote: > On Fri, Dec 20, 2024 at 05:04:42PM +0100, David Hildenbrand wrote: >> On 20.12.24 15:45, Gregory Price wrote: >> >> Please call these "default_online_type". Further keep the "mhp" terminology, >> it's more commonly used. We cannot rename the "memhp_default_state" >> parameter name unfortunately. >> > > fyi for v2 - i went ahead and cleaned this up (not including the param), > but basically also synced the build option with the boot parameter: > - offline > - online ("Auto") > - online_kernel > - online_movable > > Figured might as well. Sending shortly Just replied to your other mail :) -- Cheers, David / dhildenb ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <Z2WdXY1fvgrDkegw@gourry-fedora-PF4VCD3F>]
[parent not found: <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com>]
* Re: [PATCH] mm: add build-time option to set hotplug default type [not found] ` <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com> @ 2024-12-20 18:36 ` Gregory Price 0 siblings, 0 replies; 3+ messages in thread From: Gregory Price @ 2024-12-20 18:36 UTC (permalink / raw) To: David Hildenbrand Cc: Gregory Price, linux-mm, linux-kernel, osalvador, gregkh, rafael, akpm On Fri, Dec 20, 2024 at 07:25:57PM +0100, David Hildenbrand wrote: > > If you have another suggestion, I'm open > > I'd just do it like CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS, and simply do > > if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE)) > ... > else if (IS_ENABLED(MEMHP_DEFAULT_ONLINE_TYPE_ONLINE_MOVABLE)) > ... > > No need for parsing strings and dealing with unexpected values. > onward to V3 :P ~Gregory ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-20 18:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241220144518.206208-1-gourry@gourry.net>
[not found] ` <3775fe9c-460e-4b31-9d5c-068a1f685513@redhat.com>
2024-12-20 18:25 ` [PATCH] mm: add build-time option to set hotplug default type Gregory Price
2024-12-20 18:26 ` David Hildenbrand
[not found] ` <Z2WdXY1fvgrDkegw@gourry-fedora-PF4VCD3F>
[not found] ` <2721ef36-abc9-4261-a4e2-d9f219ebd551@redhat.com>
2024-12-20 18:36 ` Gregory Price
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox