public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Ian Rogers <irogers@google.com>, Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
	Ingo Molnar <mingo@kernel.org>, Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path
Date: Thu, 27 Feb 2025 08:46:26 -0800	[thread overview]
Message-ID: <Z8CW4ozmV4OwyXWm@google.com> (raw)
In-Reply-To: <Z7-ylCsV43noci77@google.com>

Adding Josh and Peter as it's used in objtool as well.

On Wed, Feb 26, 2025 at 04:32:20PM -0800, Namhyung Kim wrote:
> On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> > tools/arch/x86/include/linux doesn't exist but building is working by
> > virtue of a -I. Building using bazel this fails. Use angle brackets to
> > include unaligned.h so there isn't an invalid relative include.
> 
> Right, it's using tools/include/linux/unaligned.h.

Josh, are you ok with this?  I can carry this in the perf tools tree if
you don't mind.

Thanks,
Namhyung

> 
> > 
> > Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/arch/x86/lib/insn.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
> > index ab5cdc3337da..e91d4c4e1c16 100644
> > --- a/tools/arch/x86/lib/insn.c
> > +++ b/tools/arch/x86/lib/insn.c
> > @@ -13,7 +13,7 @@
> >  #endif
> >  #include "../include/asm/inat.h" /* __ignore_sync_check__ */
> >  #include "../include/asm/insn.h" /* __ignore_sync_check__ */
> > -#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
> > +#include <linux/unaligned.h> /* __ignore_sync_check__ */
> >  
> >  #include <linux/errno.h>
> >  #include <linux/kconfig.h>
> > -- 
> > 2.48.1.711.g2feabab25a-goog
> > 

  reply	other threads:[~2025-02-27 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 19:36 [PATCH v1] x86/insn: Fix linux/unaligned.h include path Ian Rogers
2025-02-27  0:32 ` Namhyung Kim
2025-02-27 16:46   ` Namhyung Kim [this message]
2025-02-27 22:37     ` Josh Poimboeuf
2025-02-28 22:25 ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8CW4ozmV4OwyXWm@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox