* [PATCH v1] x86/insn: Fix linux/unaligned.h include path
@ 2025-02-25 19:36 Ian Rogers
2025-02-27 0:32 ` Namhyung Kim
2025-02-28 22:25 ` Namhyung Kim
0 siblings, 2 replies; 5+ messages in thread
From: Ian Rogers @ 2025-02-25 19:36 UTC (permalink / raw)
To: Adrian Hunter, Ingo Molnar, Al Viro, Ian Rogers, linux-kernel,
Arnaldo Carvalho de Melo, Namhyung Kim
tools/arch/x86/include/linux doesn't exist but building is working by
virtue of a -I. Building using bazel this fails. Use angle brackets to
include unaligned.h so there isn't an invalid relative include.
Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/arch/x86/lib/insn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
index ab5cdc3337da..e91d4c4e1c16 100644
--- a/tools/arch/x86/lib/insn.c
+++ b/tools/arch/x86/lib/insn.c
@@ -13,7 +13,7 @@
#endif
#include "../include/asm/inat.h" /* __ignore_sync_check__ */
#include "../include/asm/insn.h" /* __ignore_sync_check__ */
-#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
+#include <linux/unaligned.h> /* __ignore_sync_check__ */
#include <linux/errno.h>
#include <linux/kconfig.h>
--
2.48.1.711.g2feabab25a-goog
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path
2025-02-25 19:36 [PATCH v1] x86/insn: Fix linux/unaligned.h include path Ian Rogers
@ 2025-02-27 0:32 ` Namhyung Kim
2025-02-27 16:46 ` Namhyung Kim
2025-02-28 22:25 ` Namhyung Kim
1 sibling, 1 reply; 5+ messages in thread
From: Namhyung Kim @ 2025-02-27 0:32 UTC (permalink / raw)
To: Ian Rogers
Cc: Adrian Hunter, Ingo Molnar, Al Viro, linux-kernel,
Arnaldo Carvalho de Melo
On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> tools/arch/x86/include/linux doesn't exist but building is working by
> virtue of a -I. Building using bazel this fails. Use angle brackets to
> include unaligned.h so there isn't an invalid relative include.
Right, it's using tools/include/linux/unaligned.h.
Thanks,
Namhyung
>
> Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/arch/x86/lib/insn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
> index ab5cdc3337da..e91d4c4e1c16 100644
> --- a/tools/arch/x86/lib/insn.c
> +++ b/tools/arch/x86/lib/insn.c
> @@ -13,7 +13,7 @@
> #endif
> #include "../include/asm/inat.h" /* __ignore_sync_check__ */
> #include "../include/asm/insn.h" /* __ignore_sync_check__ */
> -#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
> +#include <linux/unaligned.h> /* __ignore_sync_check__ */
>
> #include <linux/errno.h>
> #include <linux/kconfig.h>
> --
> 2.48.1.711.g2feabab25a-goog
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path
2025-02-27 0:32 ` Namhyung Kim
@ 2025-02-27 16:46 ` Namhyung Kim
2025-02-27 22:37 ` Josh Poimboeuf
0 siblings, 1 reply; 5+ messages in thread
From: Namhyung Kim @ 2025-02-27 16:46 UTC (permalink / raw)
To: Ian Rogers, Josh Poimboeuf
Cc: Adrian Hunter, Ingo Molnar, Al Viro, linux-kernel,
Arnaldo Carvalho de Melo, Peter Zijlstra
Adding Josh and Peter as it's used in objtool as well.
On Wed, Feb 26, 2025 at 04:32:20PM -0800, Namhyung Kim wrote:
> On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> > tools/arch/x86/include/linux doesn't exist but building is working by
> > virtue of a -I. Building using bazel this fails. Use angle brackets to
> > include unaligned.h so there isn't an invalid relative include.
>
> Right, it's using tools/include/linux/unaligned.h.
Josh, are you ok with this? I can carry this in the perf tools tree if
you don't mind.
Thanks,
Namhyung
>
> >
> > Fixes: 5f60d5f6bbc1 ("move asm/unaligned.h to linux/unaligned.h")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/arch/x86/lib/insn.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/arch/x86/lib/insn.c b/tools/arch/x86/lib/insn.c
> > index ab5cdc3337da..e91d4c4e1c16 100644
> > --- a/tools/arch/x86/lib/insn.c
> > +++ b/tools/arch/x86/lib/insn.c
> > @@ -13,7 +13,7 @@
> > #endif
> > #include "../include/asm/inat.h" /* __ignore_sync_check__ */
> > #include "../include/asm/insn.h" /* __ignore_sync_check__ */
> > -#include "../include/linux/unaligned.h" /* __ignore_sync_check__ */
> > +#include <linux/unaligned.h> /* __ignore_sync_check__ */
> >
> > #include <linux/errno.h>
> > #include <linux/kconfig.h>
> > --
> > 2.48.1.711.g2feabab25a-goog
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path
2025-02-27 16:46 ` Namhyung Kim
@ 2025-02-27 22:37 ` Josh Poimboeuf
0 siblings, 0 replies; 5+ messages in thread
From: Josh Poimboeuf @ 2025-02-27 22:37 UTC (permalink / raw)
To: Namhyung Kim
Cc: Ian Rogers, Adrian Hunter, Ingo Molnar, Al Viro, linux-kernel,
Arnaldo Carvalho de Melo, Peter Zijlstra
On Thu, Feb 27, 2025 at 08:46:26AM -0800, Namhyung Kim wrote:
> Adding Josh and Peter as it's used in objtool as well.
>
> On Wed, Feb 26, 2025 at 04:32:20PM -0800, Namhyung Kim wrote:
> > On Tue, Feb 25, 2025 at 11:36:00AM -0800, Ian Rogers wrote:
> > > tools/arch/x86/include/linux doesn't exist but building is working by
> > > virtue of a -I. Building using bazel this fails. Use angle brackets to
> > > include unaligned.h so there isn't an invalid relative include.
> >
> > Right, it's using tools/include/linux/unaligned.h.
>
> Josh, are you ok with this? I can carry this in the perf tools tree if
> you don't mind.
LGTM
Acked-by: Josh Poimboeuf <jpoimboe@kernel.org>
--
Josh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] x86/insn: Fix linux/unaligned.h include path
2025-02-25 19:36 [PATCH v1] x86/insn: Fix linux/unaligned.h include path Ian Rogers
2025-02-27 0:32 ` Namhyung Kim
@ 2025-02-28 22:25 ` Namhyung Kim
1 sibling, 0 replies; 5+ messages in thread
From: Namhyung Kim @ 2025-02-28 22:25 UTC (permalink / raw)
To: Adrian Hunter, Ingo Molnar, Al Viro, linux-kernel,
Arnaldo Carvalho de Melo, Ian Rogers
On Tue, 25 Feb 2025 11:36:00 -0800, Ian Rogers wrote:
> tools/arch/x86/include/linux doesn't exist but building is working by
> virtue of a -I. Building using bazel this fails. Use angle brackets to
> include unaligned.h so there isn't an invalid relative include.
>
>
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-28 22:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25 19:36 [PATCH v1] x86/insn: Fix linux/unaligned.h include path Ian Rogers
2025-02-27 0:32 ` Namhyung Kim
2025-02-27 16:46 ` Namhyung Kim
2025-02-27 22:37 ` Josh Poimboeuf
2025-02-28 22:25 ` Namhyung Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox