* [PATCH v1 1/1] units: Add missing header
@ 2023-11-28 17:44 Andy Shevchenko
2023-11-28 22:25 ` Randy Dunlap
2023-11-29 2:09 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-11-28 17:44 UTC (permalink / raw)
To: Damian Muszynski, linux-kernel
Cc: Rasmus Villemoes, Andrew Morton, Andy Shevchenko
BITS_PER_BYTE is defined in bits.h.
Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/linux/units.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/units.h b/include/linux/units.h
index ff1bd6b5f5b3..45110daaf8d3 100644
--- a/include/linux/units.h
+++ b/include/linux/units.h
@@ -2,6 +2,7 @@
#ifndef _LINUX_UNITS_H
#define _LINUX_UNITS_H
+#include <linux/bits.h>
#include <linux/math.h>
/* Metric prefixes in accordance with Système international (d'unités) */
--
2.43.0.rc1.1.gbec44491f096
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] units: Add missing header
2023-11-28 17:44 [PATCH v1 1/1] units: Add missing header Andy Shevchenko
@ 2023-11-28 22:25 ` Randy Dunlap
2023-11-29 2:09 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2023-11-28 22:25 UTC (permalink / raw)
To: Andy Shevchenko, Damian Muszynski, linux-kernel
Cc: Rasmus Villemoes, Andrew Morton
On 11/28/23 09:44, Andy Shevchenko wrote:
> BITS_PER_BYTE is defined in bits.h.
>
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> include/linux/units.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/units.h b/include/linux/units.h
> index ff1bd6b5f5b3..45110daaf8d3 100644
> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
> #ifndef _LINUX_UNITS_H
> #define _LINUX_UNITS_H
>
> +#include <linux/bits.h>
> #include <linux/math.h>
>
> /* Metric prefixes in accordance with Système international (d'unités) */
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] units: Add missing header
2023-11-28 17:44 [PATCH v1 1/1] units: Add missing header Andy Shevchenko
2023-11-28 22:25 ` Randy Dunlap
@ 2023-11-29 2:09 ` Andrew Morton
2023-11-29 10:19 ` Andy Shevchenko
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2023-11-29 2:09 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Damian Muszynski, linux-kernel, Rasmus Villemoes, Herbert Xu
On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> BITS_PER_BYTE is defined in bits.h.
>
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
This is post-6.6, so the fix should go into this -rc whatever happens, but...
It would be rather nice to know the effects of this change please. Did
some build break?
> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
> #ifndef _LINUX_UNITS_H
> #define _LINUX_UNITS_H
>
> +#include <linux/bits.h>
> #include <linux/math.h>
>
> /* Metric prefixes in accordance with Système international (d'unités) */
> --
> 2.43.0.rc1.1.gbec44491f096
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] units: Add missing header
2023-11-29 2:09 ` Andrew Morton
@ 2023-11-29 10:19 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2023-11-29 10:19 UTC (permalink / raw)
To: Andrew Morton
Cc: Damian Muszynski, linux-kernel, Rasmus Villemoes, Herbert Xu
On Tue, Nov 28, 2023 at 06:09:57PM -0800, Andrew Morton wrote:
> On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > BITS_PER_BYTE is defined in bits.h.
> >
> > Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
>
> This is post-6.6, so the fix should go into this -rc whatever happens, but...
>
> It would be rather nice to know the effects of this change please. Did
> some build break?
Not of my knowledge. Fixes tag here to make sure people won't forget that
headers are special and we need a bit stricter rules on how we add a new
stuff (which will require another header) or remove an old one (which may
give a stale inclusion).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-29 10:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 17:44 [PATCH v1 1/1] units: Add missing header Andy Shevchenko
2023-11-28 22:25 ` Randy Dunlap
2023-11-29 2:09 ` Andrew Morton
2023-11-29 10:19 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox