* [PATCH] android: removed duplicate linux/errno
@ 2024-01-04 19:31 Tanzir Hasan
2024-01-06 16:35 ` Carlos Llamas
0 siblings, 1 reply; 3+ messages in thread
From: Tanzir Hasan @ 2024-01-04 19:31 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner, Carlos Llamas,
Suren Baghdasaryan
Cc: Nick Desaulniers, linux-kernel, Nick Desaulniers, Tanzir Hasan
There are two linux/errno.h inclusions in this file. The second one has
been removed and the file builds correctly.
Fixes: 54ffdab82080 ("android: binder: binderfs.c: removed asm-generic/errno-base.h")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Tanzir Hasan <tanzirh@google.com>
---
---
drivers/android/binderfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
index d04ff6029480..3001d754ac36 100644
--- a/drivers/android/binderfs.c
+++ b/drivers/android/binderfs.c
@@ -29,7 +29,6 @@
#include <linux/uaccess.h>
#include <linux/user_namespace.h>
#include <linux/xarray.h>
-#include <linux/errno.h>
#include <uapi/linux/android/binder.h>
#include <uapi/linux/android/binderfs.h>
---
base-commit: 0c9ae0b8605078eafc3bea053cc78791e97ba2e2
change-id: 20240104-removeduperror-9b6954a0c52c
Best regards,
--
Tanzir Hasan <tanzirh@google.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] android: removed duplicate linux/errno
2024-01-04 19:31 [PATCH] android: removed duplicate linux/errno Tanzir Hasan
@ 2024-01-06 16:35 ` Carlos Llamas
2024-01-07 8:48 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Carlos Llamas @ 2024-01-06 16:35 UTC (permalink / raw)
To: Tanzir Hasan, Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Suren Baghdasaryan, Nick Desaulniers, linux-kernel,
Nick Desaulniers
On Thu, Jan 04, 2024 at 07:31:36PM +0000, Tanzir Hasan wrote:
> There are two linux/errno.h inclusions in this file. The second one has
> been removed and the file builds correctly.
>
> Fixes: 54ffdab82080 ("android: binder: binderfs.c: removed asm-generic/errno-base.h")
I'm not sure that we can I this tag before the patch hits mainline. I
suppose it's ok since char-misc doesn't do forced updates?
Greg, is this fine?
If it is, then:
Acked-by: Carlos Llamas <cmllamas@google.com>
Thanks,
--
Carlos Llamas
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] android: removed duplicate linux/errno
2024-01-06 16:35 ` Carlos Llamas
@ 2024-01-07 8:48 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2024-01-07 8:48 UTC (permalink / raw)
To: Carlos Llamas
Cc: Tanzir Hasan, Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, Suren Baghdasaryan,
Nick Desaulniers, linux-kernel, Nick Desaulniers
On Sat, Jan 06, 2024 at 04:35:30PM +0000, Carlos Llamas wrote:
> On Thu, Jan 04, 2024 at 07:31:36PM +0000, Tanzir Hasan wrote:
> > There are two linux/errno.h inclusions in this file. The second one has
> > been removed and the file builds correctly.
> >
> > Fixes: 54ffdab82080 ("android: binder: binderfs.c: removed asm-generic/errno-base.h")
>
> I'm not sure that we can I this tag before the patch hits mainline. I
> suppose it's ok since char-misc doesn't do forced updates?
Yes, char-misc does not rebase (like any sane public-facing branch.)
> Greg, is this fine?
Yes.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-07 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-04 19:31 [PATCH] android: removed duplicate linux/errno Tanzir Hasan
2024-01-06 16:35 ` Carlos Llamas
2024-01-07 8:48 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox