* Re: [PATCH v1] media: atomisp: Fix typos in comment
2024-09-23 3:30 [PATCH v1] media: atomisp: Fix typos in comment Yu Jiaoliang
@ 2024-09-23 5:44 ` Philipp Hortmann
2024-09-23 8:28 ` Andy Shevchenko
2024-09-23 5:57 ` Philipp Hortmann
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Philipp Hortmann @ 2024-09-23 5:44 UTC (permalink / raw)
To: Yu Jiaoliang, Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Andy Shevchenko, Greg Kroah-Hartman, Hans Verkuil, Kieran Bingham,
Jonathan Bergh, Kate Hsuan, Dipendra Khadka, linux-media,
linux-kernel, linux-staging
Cc: opensource.kernel
On 9/23/24 5:30 AM, Yu Jiaoliang wrote:
> Corrected typos:
> componnet->component,
> cofiguration->configuration,
> doubtfull->doubtful,
> consisit->consist,
> coppied->copied.
>
> These changes fix the typos in the comment,
> without affecting the functionality.
>
> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
Hi Jiaoliang,
Please make your "Subject" line more unique. Consider that we may end up
with having dozen of commits like yours, all of them referring to
different removals and all without the necessary information to tell
what they differ in (except the driver/subsystem). So it would help if
you add the changed file or function to make it more unique.
Please improve your patch description. Better omit what you are changing
as this can be seen in the change itself. Do focus on why this patch
makes the code better. Your sentence is fine. Just remove what you change.
If you send in a second version of this patch please use a change
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Thanks
Bye Philipp
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v1] media: atomisp: Fix typos in comment
2024-09-23 5:44 ` Philipp Hortmann
@ 2024-09-23 8:28 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-09-23 8:28 UTC (permalink / raw)
To: Philipp Hortmann
Cc: Yu Jiaoliang, Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, Hans Verkuil, Kieran Bingham, Jonathan Bergh,
Kate Hsuan, Dipendra Khadka, linux-media, linux-kernel,
linux-staging, opensource.kernel
On Mon, Sep 23, 2024 at 07:44:51AM +0200, Philipp Hortmann wrote:
> On 9/23/24 5:30 AM, Yu Jiaoliang wrote:
...
> Please make your "Subject" line more unique. Consider that we may end up
> with having dozen of commits like yours, all of them referring to different
> removals and all without the necessary information to tell what they differ
> in (except the driver/subsystem). So it would help if you add the changed
> file or function to make it more unique.
For _this_ driver the Subject is good enough, no need to change.
We all know that
1) AtomISP is in staging;
2) AtomISP is unique driver in the entire kernel.
> Please improve your patch description. Better omit what you are changing as
> this can be seen in the change itself. Do focus on why this patch makes the
> code better. Your sentence is fine. Just remove what you change.
>
> If you send in a second version of this patch please use a change history.
> Description from Dan under:
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
The above is a good advice, thanks.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] media: atomisp: Fix typos in comment
2024-09-23 3:30 [PATCH v1] media: atomisp: Fix typos in comment Yu Jiaoliang
2024-09-23 5:44 ` Philipp Hortmann
@ 2024-09-23 5:57 ` Philipp Hortmann
2024-09-23 8:26 ` Andy Shevchenko
2024-09-23 8:30 ` Andy Shevchenko
2024-11-04 11:11 ` Hans de Goede
3 siblings, 1 reply; 8+ messages in thread
From: Philipp Hortmann @ 2024-09-23 5:57 UTC (permalink / raw)
To: Yu Jiaoliang, Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Andy Shevchenko, Greg Kroah-Hartman, Hans Verkuil, Kieran Bingham,
Jonathan Bergh, Kate Hsuan, Dipendra Khadka, linux-media,
linux-kernel, linux-staging
Cc: opensource.kernel
On 9/23/24 5:30 AM, Yu Jiaoliang wrote:
> Corrected typos:
> componnet->component,
> cofiguration->configuration,
> doubtfull->doubtful,
> consisit->consist,
> coppied->copied.
>
> These changes fix the typos in the comment,
> without affecting the functionality.
>
> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 2 +-
> .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 2 +-
> drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c | 2 +-
> drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c | 2 +-
> drivers/staging/media/atomisp/pci/sh_css_mipi.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index c9984f1557b0..eb46ba4f4f13 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -55,7 +55,7 @@
> /* G-Min addition: pull this in from intel_mid_pm.h */
> #define CSTATE_EXIT_LATENCY_C1 1
>
> -/* cross componnet debug message flag */
> +/* cross component debug message flag */
> int dbg_level;
> module_param(dbg_level, int, 0644);
> MODULE_PARM_DESC(dbg_level, "debug message level (default:0)");
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8f2f4e8eddd9..c18f62fe66b3 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -406,7 +406,7 @@ input_system_err_t input_system_configuration_reset(void)
> config.unallocated_ib_mem_words = IB_CAPACITY_IN_WORDS;
> //config.acq_allocated_ib_mem_words = 0;
>
> - // Set the start of the session cofiguration.
> + // Set the start of the session configuration.
> config.session_flags = INPUT_SYSTEM_CFG_FLAG_REQUIRED;
>
> return INPUT_SYSTEM_ERR_NO_ERROR;
> diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> index 7ce2b2d6da11..3bfaf52c5cdd 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> @@ -951,7 +951,7 @@ int ia_css_binary_find(struct ia_css_binary_descr *descr, struct ia_css_binary *
> unsigned int i;
>
> assert(descr);
> - /* MW: used after an error check, may accept NULL, but doubtfull */
> + /* MW: used after an error check, may accept NULL, but doubtful */
> assert(binary);
>
> dev_dbg(atomisp_dev, "ia_css_binary_find() enter: descr=%p, (mode=%d), binary=%p\n",
> diff --git a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> index 2d7fddb114f6..0ab83e1b51b8 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> @@ -362,7 +362,7 @@ void ia_css_frame_free_multiple(unsigned int num_frames,
> int ia_css_frame_allocate_with_buffer_size(struct ia_css_frame **frame,
> const unsigned int buffer_size_bytes)
> {
> - /* AM: Body coppied from frame_allocate_with_data(). */
> + /* AM: Body copied from frame_allocate_with_data(). */
> int err;
> struct ia_css_frame *me = frame_create(0, 0,
> IA_CSS_FRAME_FORMAT_NUM,/* Not valid format yet */
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> index 80f0395cc560..710744ff0b24 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> @@ -169,7 +169,7 @@ ia_css_mipi_frame_calculate_size(const unsigned int width,
> /* ceil(words_per_odd_line/8); mem_word = 32 bytes, 8 words */
> mem_words_for_first_line = (words_for_first_line + 7) >> 3;
> mem_words_per_even_line = (words_per_even_line + 7) >> 3;
> - mem_words_for_EOF = 1; /* last line consisit of the optional (EOL) and EOF */
> + mem_words_for_EOF = 1; /* last line consist of the optional (EOL) and EOF */
>
> mem_words = ((embedded_data_size_words + 7) >> 3) +
> mem_words_for_first_line +
Hi Jiaoliang,
I cannot apply your patch:
Applying: media: atomisp: Fix typos in comment
error: patch failed:
drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c:951
error: drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c:
patch does not apply
Patch failed at 0001 media: atomisp: Fix typos in comment
Are you using the right git repo?
git remote show origin
* remote origin
Fetch URL:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
...
git branch -a
my branch: staging-testing
Please rebase.
Thanks.
Bye Philipp
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v1] media: atomisp: Fix typos in comment
2024-09-23 5:57 ` Philipp Hortmann
@ 2024-09-23 8:26 ` Andy Shevchenko
2024-09-23 8:32 ` Andy Shevchenko
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2024-09-23 8:26 UTC (permalink / raw)
To: Philipp Hortmann
Cc: Yu Jiaoliang, Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, Hans Verkuil, Kieran Bingham, Jonathan Bergh,
Kate Hsuan, Dipendra Khadka, linux-media, linux-kernel,
linux-staging, opensource.kernel
On Mon, Sep 23, 2024 at 07:57:00AM +0200, Philipp Hortmann wrote:
> On 9/23/24 5:30 AM, Yu Jiaoliang wrote:
...
> I cannot apply your patch:
> Fetch URL:
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
You used the wrong branch.
AtomISP has it's own tree/branch for development:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] media: atomisp: Fix typos in comment
2024-09-23 8:26 ` Andy Shevchenko
@ 2024-09-23 8:32 ` Andy Shevchenko
0 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-09-23 8:32 UTC (permalink / raw)
To: Philipp Hortmann
Cc: Yu Jiaoliang, Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, Hans Verkuil, Kieran Bingham, Jonathan Bergh,
Kate Hsuan, Dipendra Khadka, linux-media, linux-kernel,
linux-staging, opensource.kernel
On Mon, Sep 23, 2024 at 11:26:57AM +0300, Andy Shevchenko wrote:
> On Mon, Sep 23, 2024 at 07:57:00AM +0200, Philipp Hortmann wrote:
> > On 9/23/24 5:30 AM, Yu Jiaoliang wrote:
...
> > I cannot apply your patch:
>
> > Fetch URL:
> > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
>
> You used the wrong branch.
> AtomISP has it's own tree/branch for development:
> https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
Talking about this, Yu may use --base next time, so everyone, including CIs,
will know exactly what should be used as a base.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] media: atomisp: Fix typos in comment
2024-09-23 3:30 [PATCH v1] media: atomisp: Fix typos in comment Yu Jiaoliang
2024-09-23 5:44 ` Philipp Hortmann
2024-09-23 5:57 ` Philipp Hortmann
@ 2024-09-23 8:30 ` Andy Shevchenko
2024-11-04 11:11 ` Hans de Goede
3 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2024-09-23 8:30 UTC (permalink / raw)
To: Yu Jiaoliang
Cc: Hans de Goede, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, Hans Verkuil, Kieran Bingham, Jonathan Bergh,
Kate Hsuan, Dipendra Khadka, linux-media, linux-kernel,
linux-staging, opensource.kernel
On Mon, Sep 23, 2024 at 11:30:23AM +0800, Yu Jiaoliang wrote:
> Corrected typos:
> componnet->component,
> cofiguration->configuration,
> doubtfull->doubtful,
> consisit->consist,
> coppied->copied.
>
> These changes fix the typos in the comment,
> without affecting the functionality.
...
> //config.acq_allocated_ib_mem_words = 0;
>
> - // Set the start of the session cofiguration.
> + // Set the start of the session configuration.
While at it, the comment style can be changed to C-like
/* Set the start of the session configuration */
(no need to resend unless Hans asks for that, otherwise he might fix whilst
applying).
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1] media: atomisp: Fix typos in comment
2024-09-23 3:30 [PATCH v1] media: atomisp: Fix typos in comment Yu Jiaoliang
` (2 preceding siblings ...)
2024-09-23 8:30 ` Andy Shevchenko
@ 2024-11-04 11:11 ` Hans de Goede
3 siblings, 0 replies; 8+ messages in thread
From: Hans de Goede @ 2024-11-04 11:11 UTC (permalink / raw)
To: Yu Jiaoliang, Mauro Carvalho Chehab, Sakari Ailus,
Andy Shevchenko, Greg Kroah-Hartman, Hans Verkuil, Kieran Bingham,
Jonathan Bergh, Kate Hsuan, Dipendra Khadka, linux-media,
linux-kernel, linux-staging
Cc: opensource.kernel
Hi,
On 23-Sep-24 5:30 AM, Yu Jiaoliang wrote:
> Corrected typos:
> componnet->component,
> cofiguration->configuration,
> doubtfull->doubtful,
> consisit->consist,
> coppied->copied.
>
> These changes fix the typos in the comment,
> without affecting the functionality.
>
> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
Thank you for your patch(es).
I have merged this/these in my media-atomisp branch:
https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp
And this/these will be included in my next pull-request to
Mauro (to media subsystem maintainer)
Regards,
Hans
> ---
> drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 2 +-
> .../media/atomisp/pci/hive_isp_css_common/host/input_system.c | 2 +-
> drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c | 2 +-
> drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c | 2 +-
> drivers/staging/media/atomisp/pci/sh_css_mipi.c | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index c9984f1557b0..eb46ba4f4f13 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -55,7 +55,7 @@
> /* G-Min addition: pull this in from intel_mid_pm.h */
> #define CSTATE_EXIT_LATENCY_C1 1
>
> -/* cross componnet debug message flag */
> +/* cross component debug message flag */
> int dbg_level;
> module_param(dbg_level, int, 0644);
> MODULE_PARM_DESC(dbg_level, "debug message level (default:0)");
> diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> index 8f2f4e8eddd9..c18f62fe66b3 100644
> --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
> @@ -406,7 +406,7 @@ input_system_err_t input_system_configuration_reset(void)
> config.unallocated_ib_mem_words = IB_CAPACITY_IN_WORDS;
> //config.acq_allocated_ib_mem_words = 0;
>
> - // Set the start of the session cofiguration.
> + // Set the start of the session configuration.
> config.session_flags = INPUT_SYSTEM_CFG_FLAG_REQUIRED;
>
> return INPUT_SYSTEM_ERR_NO_ERROR;
> diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> index 7ce2b2d6da11..3bfaf52c5cdd 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> @@ -951,7 +951,7 @@ int ia_css_binary_find(struct ia_css_binary_descr *descr, struct ia_css_binary *
> unsigned int i;
>
> assert(descr);
> - /* MW: used after an error check, may accept NULL, but doubtfull */
> + /* MW: used after an error check, may accept NULL, but doubtful */
> assert(binary);
>
> dev_dbg(atomisp_dev, "ia_css_binary_find() enter: descr=%p, (mode=%d), binary=%p\n",
> diff --git a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> index 2d7fddb114f6..0ab83e1b51b8 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/frame/src/frame.c
> @@ -362,7 +362,7 @@ void ia_css_frame_free_multiple(unsigned int num_frames,
> int ia_css_frame_allocate_with_buffer_size(struct ia_css_frame **frame,
> const unsigned int buffer_size_bytes)
> {
> - /* AM: Body coppied from frame_allocate_with_data(). */
> + /* AM: Body copied from frame_allocate_with_data(). */
> int err;
> struct ia_css_frame *me = frame_create(0, 0,
> IA_CSS_FRAME_FORMAT_NUM,/* Not valid format yet */
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_mipi.c b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> index 80f0395cc560..710744ff0b24 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_mipi.c
> @@ -169,7 +169,7 @@ ia_css_mipi_frame_calculate_size(const unsigned int width,
> /* ceil(words_per_odd_line/8); mem_word = 32 bytes, 8 words */
> mem_words_for_first_line = (words_for_first_line + 7) >> 3;
> mem_words_per_even_line = (words_per_even_line + 7) >> 3;
> - mem_words_for_EOF = 1; /* last line consisit of the optional (EOL) and EOF */
> + mem_words_for_EOF = 1; /* last line consist of the optional (EOL) and EOF */
>
> mem_words = ((embedded_data_size_words + 7) >> 3) +
> mem_words_for_first_line +
^ permalink raw reply [flat|nested] 8+ messages in thread