[PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()

[PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()

[Nicolin Chen]

The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.

Drop the '!' to fix it.

Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
 tools/testing/selftests/iommu/iommufd_utils.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/iommu/iommufd_utils.h b/tools/testing/selftests/iommu/iommufd_utils.h
index 772ca1db6e597..9f472c20c1905 100644
--- a/tools/testing/selftests/iommu/iommufd_utils.h
+++ b/tools/testing/selftests/iommu/iommufd_utils.h
@@ -1044,8 +1044,8 @@ static int _test_cmd_trigger_vevents(int fd, __u32 dev_id, __u32 nvevents)
 	};
 
 	while (nvevents--) {
-		if (!ioctl(fd, _IOMMU_TEST_CMD(IOMMU_TEST_OP_TRIGGER_VEVENT),
-			    &trigger_vevent_cmd))
+		if (ioctl(fd, _IOMMU_TEST_CMD(IOMMU_TEST_OP_TRIGGER_VEVENT),
+			  &trigger_vevent_cmd))
 			return -1;
 	}
 	return 0;
-- 
2.43.0

RE: [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()

[Tian, Kevin]

> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Wednesday, October 15, 2025 5:49 AM
> 
> The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.
> 
> Drop the '!' to fix it.
> 
> Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Re: [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()

[Alessandro Zanni]

On Thu, Oct 16, 2025 at 07:47:20AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Wednesday, October 15, 2025 5:49 AM
> > 
> > The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.
> > 
> > Drop the '!' to fix it.
> > 
> > Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> 
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

With this fix a positive value returned by the ioctl() ends the loop and returns -1
to the assert.
Maybe better to put ioctl()<0 in the if condition?

Re: [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()

[Nicolin Chen]

On Thu, Oct 16, 2025 at 11:09:59AM +0200, Alessandro Zanni wrote:
> On Thu, Oct 16, 2025 at 07:47:20AM +0000, Tian, Kevin wrote:
> > > From: Nicolin Chen <nicolinc@nvidia.com>
> > > Sent: Wednesday, October 15, 2025 5:49 AM
> > > 
> > > The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.
> > > 
> > > Drop the '!' to fix it.
> > > 
> > > Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
> > > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > 
> > Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> 
> With this fix a positive value returned by the ioctl() ends the loop and returns -1
> to the assert.

Not with this particular ioctl(). And in fact, I don't recall we
have an ioctl in iommufd uAPI that returns a positive value. All
the other ioctls in selftest check "if (ret)".

Nicolin

Re: [PATCH rc] iommufd/selftest: Fix ioctl return value in _test_cmd_trigger_vevents()

[Jason Gunthorpe]

On Tue, Oct 14, 2025 at 02:48:46PM -0700, Nicolin Chen wrote:
> The ioctl returns 0 upon success, so !0 returning -1 breaks the selftest.
> 
> Drop the '!' to fix it.
> 
> Fixes: 1d235d849425 ("iommu/selftest: prevent use of uninitialized variable")
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  tools/testing/selftests/iommu/iommufd_utils.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-rc, thanks

Jason