From: Simona Vetter <simona.vetter@ffwll.ch>
To: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jyri Sarha <jyri.sarha@iki.fi>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Devarsh Thakkar <devarsht@ti.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/29] drm: Implement state readout support
Date: Fri, 17 Oct 2025 15:11:56 +0200 [thread overview]
Message-ID: <aPJAnPWneXod2REH@phenom.ffwll.local> (raw)
In-Reply-To: <20250923-spry-aloof-bullfrog-4febcc@penduick>
On Tue, Sep 23, 2025 at 11:15:55AM +0200, Maxime Ripard wrote:
> Hi Thomas,
>
> On Tue, Sep 02, 2025 at 04:13:21PM +0200, Thomas Zimmermann wrote:
> > Hi Maxime,
> >
> > there are a number of patches in this series that can be merged immediately,
> > and likely should.
>
> Ack, I'll do a first pass to apply the preliminary patches if (or when)
> they get reviewed.
>
> > Is the state-compare code really necessary? Doing this separately might ease
> > the review.
>
> My understanding was that Sima wanted to be part of it, but I guess we
> can introduce it later on if she agrees.
Yeah I think without readout state comparison fastboot is nigh impossible
to validate and keep working. For merging splitting things sounds fine,
but for enabling in production I'd be very vary to ship this without.
I think a module option for developers and testing would be good here to
make this happen: -1/default means you only get fastboot when the entire
driver (including all bridges) support both state readout and comparison,
and then you can override that with 0/1. And this should be a tainting
module option I think.
-Sima
--
Simona Vetter
Software Engineer
http://blog.ffwll.ch
next prev parent reply other threads:[~2025-10-17 13:12 UTC|newest]
Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 8:32 [PATCH 00/29] drm: Implement state readout support Maxime Ripard
2025-09-02 8:32 ` [PATCH 01/29] drm/atomic: Document atomic state lifetime Maxime Ripard
2025-09-02 13:08 ` Thomas Zimmermann
2025-09-02 18:59 ` Laurent Pinchart
2025-09-23 9:22 ` Maxime Ripard
2025-09-02 8:32 ` [PATCH 02/29] drm/atomic: Fix unused but set warning in for_each_old_plane_in_state Maxime Ripard
2025-09-02 13:10 ` Thomas Zimmermann
2025-09-02 19:25 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 03/29] drm/atomic: Fix unused but set warning in for_each_old_private_obj_in_state Maxime Ripard
2025-09-02 13:10 ` Thomas Zimmermann
2025-09-02 19:26 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 04/29] drm/atomic_helper: Skip over NULL private_obj pointers Maxime Ripard
2025-09-02 13:13 ` Thomas Zimmermann
2025-09-02 19:29 ` Laurent Pinchart
2025-09-23 9:23 ` Maxime Ripard
2025-09-02 8:32 ` [PATCH 05/29] drm/atomic_state_helper: Fix bridge state initialization Maxime Ripard
2025-09-02 13:18 ` Thomas Zimmermann
2025-09-15 11:27 ` Maxime Ripard
2025-09-15 13:12 ` Thomas Zimmermann
2025-09-23 9:33 ` Maxime Ripard
2025-10-01 6:45 ` Thomas Zimmermann
2025-09-15 12:54 ` Dmitry Baryshkov
2025-09-02 19:49 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 06/29] drm/bridge: Implement atomic_print_state Maxime Ripard
2025-09-02 13:22 ` Thomas Zimmermann
2025-09-02 20:22 ` Laurent Pinchart
2025-09-15 11:28 ` Maxime Ripard
2025-09-15 12:56 ` Dmitry Baryshkov
2025-09-02 8:32 ` [PATCH 07/29] drm/atomic: Implement drm_atomic_print_old_state Maxime Ripard
2025-09-02 13:26 ` Thomas Zimmermann
2025-09-09 12:44 ` Maxime Ripard
2025-09-02 20:35 ` Laurent Pinchart
2025-09-02 8:32 ` [PATCH 08/29] drm/atomic: Only call atomic_destroy_state on a !NULL pointer Maxime Ripard
2025-09-02 13:30 ` Thomas Zimmermann
2025-09-02 20:52 ` Laurent Pinchart
2025-09-15 11:35 ` Maxime Ripard
2025-09-02 8:32 ` [PATCH 09/29] drm/modeset: Create atomic_reset hook Maxime Ripard
2025-09-02 21:04 ` Laurent Pinchart
2025-09-15 11:37 ` Maxime Ripard
2025-09-02 8:32 ` [PATCH 10/29] drm/atomic: Add atomic_state_readout infrastructure Maxime Ripard
2025-09-02 13:44 ` Thomas Zimmermann
2025-09-15 8:42 ` Maxime Ripard
2025-09-15 9:11 ` Thomas Zimmermann
2025-09-23 9:37 ` Maxime Ripard
2025-10-01 7:01 ` Thomas Zimmermann
2025-09-15 18:38 ` Dmitry Baryshkov
2025-09-23 9:38 ` Maxime Ripard
2025-09-23 10:28 ` Dmitry Baryshkov
2025-09-23 10:32 ` Laurent Pinchart
2025-09-23 10:43 ` Dmitry Baryshkov
2025-09-23 11:41 ` Laurent Pinchart
2025-09-23 15:20 ` Dmitry Baryshkov
2025-09-24 9:56 ` Maxime Ripard
2025-09-24 9:53 ` Maxime Ripard
2025-09-15 18:40 ` Dmitry Baryshkov
2025-09-23 9:45 ` Maxime Ripard
2025-09-23 10:30 ` Dmitry Baryshkov
2025-10-17 13:12 ` Simona Vetter
2025-10-17 13:29 ` Simona Vetter
2025-10-17 13:41 ` Simona Vetter
2025-09-02 8:32 ` [PATCH 11/29] drm/crtc: Drop no_vblank bit field Maxime Ripard
2025-09-02 13:45 ` Thomas Zimmermann
2025-09-30 10:00 ` (subset) " Maxime Ripard
2025-09-02 8:32 ` [PATCH 12/29] drm/atomic_helper: Pass nonblock to commit_tail Maxime Ripard
2025-09-02 13:46 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 13/29] drm/atomic_helper: Compare actual and readout states once the commit is done Maxime Ripard
2025-10-17 13:21 ` Simona Vetter
2025-10-21 9:27 ` Simona Vetter
2025-10-31 21:01 ` Simona Vetter
2025-09-02 8:32 ` [PATCH 14/29] drm/atomic_state_helper: Provide comparison macros Maxime Ripard
2025-09-02 8:32 ` [PATCH 15/29] drm/atomic_state_helper: Provide atomic_compare_state helpers Maxime Ripard
2025-09-02 8:32 ` [PATCH 16/29] drm/encoder: Create get_current_crtc hook Maxime Ripard
2025-10-17 13:19 ` Simona Vetter
2025-09-02 8:32 ` [PATCH 17/29] drm/bridge_connector: Implement hw readout for connector Maxime Ripard
2025-09-02 8:32 ` [PATCH 18/29] drm/tidss: Convert to drm logging Maxime Ripard
2025-09-02 13:49 ` Thomas Zimmermann
2025-09-30 10:00 ` (subset) " Maxime Ripard
2025-09-02 8:32 ` [PATCH 19/29] drm/tidss: Remove ftrace-like logs Maxime Ripard
2025-09-02 13:50 ` Thomas Zimmermann
2025-09-30 10:00 ` (subset) " Maxime Ripard
2025-09-02 8:32 ` [PATCH 20/29] drm/tidss: crtc: Change variable name Maxime Ripard
2025-09-02 13:51 ` Thomas Zimmermann
2025-09-30 10:00 ` (subset) " Maxime Ripard
2025-09-02 8:32 ` [PATCH 21/29] drm/tidss: crtc: Implement destroy_state Maxime Ripard
2025-09-02 13:52 ` Thomas Zimmermann
2025-09-30 10:00 ` (subset) " Maxime Ripard
2025-09-02 8:32 ` [PATCH 22/29] drm/tidss: crtc: Cleanup reset implementation Maxime Ripard
2025-09-02 13:54 ` Thomas Zimmermann
2025-09-30 10:00 ` (subset) " Maxime Ripard
2025-09-02 8:32 ` [PATCH 23/29] drm/tidss: dispc: Add format lookup by hw value Maxime Ripard
2025-10-08 12:40 ` Tomi Valkeinen
2025-09-02 8:32 ` [PATCH 24/29] drm/tidss: dispc: Improve mode checking logs Maxime Ripard
2025-09-02 14:06 ` Thomas Zimmermann
2025-09-02 8:32 ` [PATCH 25/29] drm/tidss: dispc: Move dispc_device definition to headers Maxime Ripard
2025-09-02 8:32 ` [PATCH 26/29] drm/tidss: dispc: make accessors accessible to other parts of the driver Maxime Ripard
2025-09-02 8:32 ` [PATCH 27/29] drm/tidss: Implement readout support Maxime Ripard
2025-10-08 12:44 ` Tomi Valkeinen
2025-09-02 8:32 ` [PATCH 28/29] drm/tidss: encoder: implement get_current_crtc Maxime Ripard
2025-09-02 8:32 ` [PATCH 29/29] drm/bridge: sii902x: Implement hw state readout Maxime Ripard
2025-09-02 14:13 ` [PATCH 00/29] drm: Implement state readout support Thomas Zimmermann
2025-09-23 9:15 ` Maxime Ripard
2025-10-17 13:11 ` Simona Vetter [this message]
2025-10-08 13:07 ` Tomi Valkeinen
2025-10-08 13:57 ` Maxime Ripard
2025-10-08 14:15 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPJAnPWneXod2REH@phenom.ffwll.local \
--to=simona.vetter@ffwll.ch \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=jyri.sarha@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox