[PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

[PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

[Billy Tsai]

Ensures the reference voltage bits are cleared in the ADC engine
control register before configuring the voltage reference. This
avoids potential misconfigurations caused by residual bits.

Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
 drivers/iio/adc/aspeed_adc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/aspeed_adc.c b/drivers/iio/adc/aspeed_adc.c
index 1d5fd5f534b8..8ab29948214a 100644
--- a/drivers/iio/adc/aspeed_adc.c
+++ b/drivers/iio/adc/aspeed_adc.c
@@ -415,6 +415,7 @@ static int aspeed_adc_vref_config(struct iio_dev *indio_dev)
 	}
 	adc_engine_control_reg_val =
 		readl(data->base + ASPEED_REG_ENGINE_CONTROL);
+	adc_engine_control_reg_val &= ~ASPEED_ADC_REF_VOLTAGE;
 
 	ret = devm_regulator_get_enable_read_voltage(data->dev, "vref");
 	if (ret < 0 && ret != -ENODEV)
-- 
2.25.1

Re: [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

[Andy Shevchenko]

On Tue, Oct 28, 2025 at 01:41:02PM +0800, Billy Tsai wrote:
> Ensures the reference voltage bits are cleared in the ADC engine
> control register before configuring the voltage reference. This
> avoids potential misconfigurations caused by residual bits.
> 
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---

It's a v2 and here a changelog is missing.
No need to resend, just reply with a missing piece.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

[Jonathan Cameron]

On Tue, 28 Oct 2025 12:14:51 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Oct 28, 2025 at 01:41:02PM +0800, Billy Tsai wrote:
> > Ensures the reference voltage bits are cleared in the ADC engine
> > control register before configuring the voltage reference. This
> > avoids potential misconfigurations caused by residual bits.
> > 
> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > ---  
> 
> It's a v2 and here a changelog is missing.
> No need to resend, just reply with a missing piece.
> 

Billy. This one is still outstanding.

I was rather expecting a fixes tag as well.
I'm going to mark it as changes requested in patchwork and stop
tracking it. Hence please send a v3 addressing Andy's comment
and either add a fixes tag or say why one isn't appropriate.


Thanks,

Jonathan

Re: [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

[Billy Tsai]

Hi Jonathan and Andy,

Sorry, I missed this email thread. I will send v3 with the appropriate Fixes tags.

Thanks

________________________________________
From: Jonathan Cameron <jic23@kernel.org>
Sent: Sunday, March 1, 2026 9:41 PM
To: Andy Shevchenko
Cc: Billy Tsai; dlechner@baylibre.com; nuno.sa@analog.com; andy@kernel.org; joel@jms.id.au; andrew@codeconstruct.com.au; linux-iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: aspeed: clear reference voltage bits before configuring vref

On Tue, 28 Oct 2025 12:14:51 +0200
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:

> On Tue, Oct 28, 2025 at 01:41:02PM +0800, Billy Tsai wrote:
> > Ensures the reference voltage bits are cleared in the ADC engine
> > control register before configuring the voltage reference. This
> > avoids potential misconfigurations caused by residual bits.
> >
> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > ---
>
> It's a v2 and here a changelog is missing.
> No need to resend, just reply with a missing piece.
>

Billy. This one is still outstanding.

I was rather expecting a fixes tag as well.
I'm going to mark it as changes requested in patchwork and stop
tracking it. Hence please send a v3 addressing Andy's comment
and either add a fixes tag or say why one isn't appropriate.


Thanks,

Jonathan