From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shenghao Ding <shenghao-ding@ti.com>
Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org,
baojun.xu@ti.com, Baojun.Xu@fpt.com, 13564923607@139.com,
13916275206@139.com
Subject: Re: [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment
Date: Sat, 29 Nov 2025 15:29:48 +0200 [thread overview]
Message-ID: <aSr1TIpl2IYtpypS@smile.fi.intel.com> (raw)
In-Reply-To: <20251129015128.1170-1-shenghao-ding@ti.com>
On Sat, Nov 29, 2025 at 09:51:28AM +0800, Shenghao Ding wrote:
> An extra space in the comment was reported by one of my customers.
> Their careful code review is greatly appreciated.
> Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib")
Definitely not a fix that anyhow needs to be backported or even thought about.
...
> /*
> * Our variable names are ASCII by construction, but
> - * EFI names are wide chars. Convert and zero-pad.
> + * EFI names are wide chars. Convert and zero-pad.
> */
It's not a problem. This was (still is?) standard way of the spacing in
the (antique :-) computer text in English.
https://www.reddit.com/r/grammar/comments/zn0jxz/two_spaces_after_a_period/
With all that said, no need for this change, it does nothing good or bad, just
unneeded churn.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-11-29 13:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 1:51 [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment Shenghao Ding
2025-11-29 13:29 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aSr1TIpl2IYtpypS@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=13564923607@139.com \
--cc=13916275206@139.com \
--cc=Baojun.Xu@fpt.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox