* [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment
@ 2025-11-29 1:51 Shenghao Ding
2025-11-29 13:29 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Shenghao Ding @ 2025-11-29 1:51 UTC (permalink / raw)
To: tiwai
Cc: broonie, andriy.shevchenko, linux-kernel, baojun.xu, Baojun.Xu,
13564923607, 13916275206, Shenghao Ding
An extra space in the comment was reported by one of my customers.
Their careful code review is greatly appreciated.
Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib")
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
index c8619995b1d7..3a2f942a0533 100644
--- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
+++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c
@@ -357,7 +357,7 @@ static int tas2563_save_calibration(struct tas2781_hda *h)
}
/*
* Our variable names are ASCII by construction, but
- * EFI names are wide chars. Convert and zero-pad.
+ * EFI names are wide chars. Convert and zero-pad.
*/
memset(efi_name, 0, sizeof(efi_name));
for (k = 0; k < sizeof(var8) && var8[k]; k++)
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment
2025-11-29 1:51 [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment Shenghao Ding
@ 2025-11-29 13:29 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2025-11-29 13:29 UTC (permalink / raw)
To: Shenghao Ding
Cc: tiwai, broonie, linux-kernel, baojun.xu, Baojun.Xu, 13564923607,
13916275206
On Sat, Nov 29, 2025 at 09:51:28AM +0800, Shenghao Ding wrote:
> An extra space in the comment was reported by one of my customers.
> Their careful code review is greatly appreciated.
> Fixes: 4fe238513407 ("ALSA: hda/tas2781: Move and unified the calibrated-data getting function for SPI and I2C into the tas2781_hda lib")
Definitely not a fix that anyhow needs to be backported or even thought about.
...
> /*
> * Our variable names are ASCII by construction, but
> - * EFI names are wide chars. Convert and zero-pad.
> + * EFI names are wide chars. Convert and zero-pad.
> */
It's not a problem. This was (still is?) standard way of the spacing in
the (antique :-) computer text in English.
https://www.reddit.com/r/grammar/comments/zn0jxz/two_spaces_after_a_period/
With all that said, no need for this change, it does nothing good or bad, just
unneeded churn.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-29 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-29 1:51 [PATCH v1] ALSA: hda/tas2781: remove an extra space in the comment Shenghao Ding
2025-11-29 13:29 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox