public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Nick Huang <sef1548@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	kusogame68@gmail.com, paladin@ntub.edu.tw, n1136402@ntub.edu.tw,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/test_min_heap: fix incorrect module description
Date: Mon, 19 Jan 2026 22:06:02 +0800	[thread overview]
Message-ID: <aW46Sg3EwXWMi49G@google.com> (raw)
In-Reply-To: <CABZAGRFuq7h=-Z0wYfasLV4a1nY_iaNtJHN9W3PpeJc6=OP3Qw@mail.gmail.com>

Hi Nick,

On Mon, Jan 19, 2026 at 09:46:05PM +0800, Nick Huang wrote:
> Kuan-Wei Chiu <visitorckw@gmail.com> 於 2026年1月19日週一 下午9:26寫道:
> 
> > Hi Nick,
> >
> > On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote:
> > > The module description incorrectly mentions "min max heap", but the
> > > test module is specifically designed for testing the min heap
> > > implementation. Correct the metadata to match the code.
> >
> > Thanks for the patch, but I don't think this change is necessary.
> >
> > As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"),
> > the implementation easily supports a max heap by simply inverting
> > the comparison function.
> >
> > Since this module explicitly tests both min heap and max heap
> > scenarios, the current description accurately reflects the test
> > coverage.
> >
> > Regards,
> > Kuan-Wei
> >
> 
>   Hi Kuan-Wei
> 
>    Thanks for your clarification!
> 
For future reference, please ensure your emails are plain text only,
without html or base64 encoding.

Regards,
Kuan-Wei


  parent reply	other threads:[~2026-01-19 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-19 11:34 [PATCH] lib/test_min_heap: fix incorrect module description Nick Huang
2026-01-19 13:26 ` Kuan-Wei Chiu
     [not found]   ` <CABZAGRFuq7h=-Z0wYfasLV4a1nY_iaNtJHN9W3PpeJc6=OP3Qw@mail.gmail.com>
2026-01-19 14:06     ` Kuan-Wei Chiu [this message]
2026-01-20  3:11       ` Nick Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aW46Sg3EwXWMi49G@google.com \
    --to=visitorckw@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kusogame68@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n1136402@ntub.edu.tw \
    --cc=paladin@ntub.edu.tw \
    --cc=sef1548@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox