From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Nick Huang <sef1548@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kusogame68@gmail.com, paladin@ntub.edu.tw, n1136402@ntub.edu.tw,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/test_min_heap: fix incorrect module description
Date: Mon, 19 Jan 2026 21:26:16 +0800 [thread overview]
Message-ID: <aW4w-JHPMY93iOiP@google.com> (raw)
In-Reply-To: <20260119113420.2819-1-sef1548@gmail.com>
Hi Nick,
On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote:
> The module description incorrectly mentions "min max heap", but the
> test module is specifically designed for testing the min heap
> implementation. Correct the metadata to match the code.
Thanks for the patch, but I don't think this change is necessary.
As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"),
the implementation easily supports a max heap by simply inverting
the comparison function.
Since this module explicitly tests both min heap and max heap
scenarios, the current description accurately reflects the test
coverage.
Regards,
Kuan-Wei
>
> Signed-off-by: Nick Huang <sef1548@gmail.com>
> ---
> lib/test_min_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c
> index a9c4a74d3..9e42a805b 100644
> --- a/lib/test_min_heap.c
> +++ b/lib/test_min_heap.c
> @@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void)
> }
> module_exit(test_min_heap_exit);
>
> -MODULE_DESCRIPTION("Test cases for the min max heap");
> +MODULE_DESCRIPTION("Test cases for the min heap");
> MODULE_LICENSE("GPL");
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-01-19 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 11:34 [PATCH] lib/test_min_heap: fix incorrect module description Nick Huang
2026-01-19 13:26 ` Kuan-Wei Chiu [this message]
[not found] ` <CABZAGRFuq7h=-Z0wYfasLV4a1nY_iaNtJHN9W3PpeJc6=OP3Qw@mail.gmail.com>
2026-01-19 14:06 ` Kuan-Wei Chiu
2026-01-20 3:11 ` Nick Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW4w-JHPMY93iOiP@google.com \
--to=visitorckw@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kusogame68@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n1136402@ntub.edu.tw \
--cc=paladin@ntub.edu.tw \
--cc=sef1548@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox