[PATCH] lib/test_min_heap: fix incorrect module description

[PATCH] lib/test_min_heap: fix incorrect module description

[Nick Huang]

The module description incorrectly mentions "min max heap", but the
test module is specifically designed for testing the min heap
implementation. Correct the metadata to match the code.

Signed-off-by: Nick Huang <sef1548@gmail.com>
---
 lib/test_min_heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c
index a9c4a74d3..9e42a805b 100644
--- a/lib/test_min_heap.c
+++ b/lib/test_min_heap.c
@@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void)
 }
 module_exit(test_min_heap_exit);
 
-MODULE_DESCRIPTION("Test cases for the min max heap");
+MODULE_DESCRIPTION("Test cases for the min heap");
 MODULE_LICENSE("GPL");
-- 
2.43.0

Re: [PATCH] lib/test_min_heap: fix incorrect module description

[Kuan-Wei Chiu]

Hi Nick,

On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote:
> The module description incorrectly mentions "min max heap", but the
> test module is specifically designed for testing the min heap
> implementation. Correct the metadata to match the code.

Thanks for the patch, but I don't think this change is necessary.

As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"),
the implementation easily supports a max heap by simply inverting
the comparison function.

Since this module explicitly tests both min heap and max heap
scenarios, the current description accurately reflects the test
coverage.

Regards,
Kuan-Wei

> 
> Signed-off-by: Nick Huang <sef1548@gmail.com>
> ---
>  lib/test_min_heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_min_heap.c b/lib/test_min_heap.c
> index a9c4a74d3..9e42a805b 100644
> --- a/lib/test_min_heap.c
> +++ b/lib/test_min_heap.c
> @@ -218,5 +218,5 @@ static void __exit test_min_heap_exit(void)
>  }
>  module_exit(test_min_heap_exit);
>  
> -MODULE_DESCRIPTION("Test cases for the min max heap");
> +MODULE_DESCRIPTION("Test cases for the min heap");
>  MODULE_LICENSE("GPL");
> -- 
> 2.43.0
> 

Re: [PATCH] lib/test_min_heap: fix incorrect module description

[Kuan-Wei Chiu]

Hi Nick,

On Mon, Jan 19, 2026 at 09:46:05PM +0800, Nick Huang wrote:
> Kuan-Wei Chiu <visitorckw@gmail.com> 於 2026年1月19日週一 下午9:26寫道：
> 
> > Hi Nick,
> >
> > On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote:
> > > The module description incorrectly mentions "min max heap", but the
> > > test module is specifically designed for testing the min heap
> > > implementation. Correct the metadata to match the code.
> >
> > Thanks for the patch, but I don't think this change is necessary.
> >
> > As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"),
> > the implementation easily supports a max heap by simply inverting
> > the comparison function.
> >
> > Since this module explicitly tests both min heap and max heap
> > scenarios, the current description accurately reflects the test
> > coverage.
> >
> > Regards,
> > Kuan-Wei
> >
> 
>   Hi Kuan-Wei
> 
>    Thanks for your clarification!
> 
For future reference, please ensure your emails are plain text only,
without html or base64 encoding.

Regards,
Kuan-Wei

Re: [PATCH] lib/test_min_heap: fix incorrect module description

[Nick Huang]

Kuan-Wei Chiu <visitorckw@gmail.com> 於 2026年1月19日週一 下午10:06寫道：
>
> Hi Nick,
>
> On Mon, Jan 19, 2026 at 09:46:05PM +0800, Nick Huang wrote:
> > Kuan-Wei Chiu <visitorckw@gmail.com> 於 2026年1月19日週一 下午9:26寫道：
> >
> > > Hi Nick,
> > >
> > > On Mon, Jan 19, 2026 at 11:34:20AM +0000, Nick Huang wrote:
> > > > The module description incorrectly mentions "min max heap", but the
> > > > test module is specifically designed for testing the min heap
> > > > implementation. Correct the metadata to match the code.
> > >
> > > Thanks for the patch, but I don't think this change is necessary.
> > >
> > > As noted in commit 6e24628d78e4 ("lib: Introduce generic min-heap"),
> > > the implementation easily supports a max heap by simply inverting
> > > the comparison function.
> > >
> > > Since this module explicitly tests both min heap and max heap
> > > scenarios, the current description accurately reflects the test
> > > coverage.
> > >
> > > Regards,
> > > Kuan-Wei
> > >
> >
> >   Hi Kuan-Wei
> >
> >    Thanks for your clarification!
> >
> For future reference, please ensure your emails are plain text only,
> without html or base64 encoding.
>
> Regards,
> Kuan-Wei
>
Hi Kuan-Wei

Thanks for the reminder. I'll make sure to send my future emails in
plain text only.

Regards,
Nick Huang