public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Henry Zhang <henryzhangjcle@gmail.com>
Cc: speakup@linux-speakup.org, w.d.hubbs@gmail.com,
	chris@the-brannons.com, kirk@reisers.ca,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Henry Zhang <zeri@umich.edu>
Subject: Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds
Date: Mon, 26 Jan 2026 22:49:57 +0100	[thread overview]
Message-ID: <aXfhhSUZyKUM-W58@end> (raw)
In-Reply-To: <20260126201707.1297665-1-zeri@umich.edu>

Henry Zhang, le lun. 26 janv. 2026 15:17:07 -0500, a ecrit:
> The documentation had a TODO questioning whether the unit was in
> jiffies. The implementation in drivers/accessibility/speakup/main.c
> passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> in milliseconds.
> 
> Signed-off-by: Henry Zhang <zeri@umich.edu>

Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Thanks!

> ---
>  Documentation/ABI/stable/sysfs-driver-speakup | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Documentation/ABI/stable/sysfs-driver-speakup b/Documentation/ABI/stable/sysfs-driver-speakup
> index bcb6831aa114..8b508b4a7a00 100644
> --- a/Documentation/ABI/stable/sysfs-driver-speakup
> +++ b/Documentation/ABI/stable/sysfs-driver-speakup
> @@ -23,8 +23,7 @@ What:		/sys/accessibility/speakup/bleep_time
>  KernelVersion:	2.6
>  Contact:	speakup@linux-speakup.org
>  Description:	This controls the duration of the PC speaker beeps speakup
> -		produces.
> -		TODO: What are the units? Jiffies?
> +		produces, in milliseconds.
>  
>  What:		/sys/accessibility/speakup/cursor_time
>  KernelVersion:	2.6
> -- 
> 2.34.1
> 

  reply	other threads:[~2026-01-26 21:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 20:17 [PATCH] speakup: Clarify bleep_time unit is milliseconds Henry Zhang
2026-01-26 21:49 ` Samuel Thibault [this message]
2026-01-27 14:55 ` Greg KH
2026-01-27 14:56   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXfhhSUZyKUM-W58@end \
    --to=samuel.thibault@ens-lyon.org \
    --cc=chris@the-brannons.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=henryzhangjcle@gmail.com \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=speakup@linux-speakup.org \
    --cc=w.d.hubbs@gmail.com \
    --cc=zeri@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox