* [PATCH] speakup: Clarify bleep_time unit is milliseconds
@ 2026-01-26 20:17 Henry Zhang
2026-01-26 21:49 ` Samuel Thibault
2026-01-27 14:55 ` Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Henry Zhang @ 2026-01-26 20:17 UTC (permalink / raw)
To: speakup
Cc: w.d.hubbs, chris, kirk, samuel.thibault, gregkh, linux-kernel,
Henry Zhang
The documentation had a TODO questioning whether the unit was in
jiffies. The implementation in drivers/accessibility/speakup/main.c
passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
in milliseconds.
Signed-off-by: Henry Zhang <zeri@umich.edu>
---
Documentation/ABI/stable/sysfs-driver-speakup | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/Documentation/ABI/stable/sysfs-driver-speakup b/Documentation/ABI/stable/sysfs-driver-speakup
index bcb6831aa114..8b508b4a7a00 100644
--- a/Documentation/ABI/stable/sysfs-driver-speakup
+++ b/Documentation/ABI/stable/sysfs-driver-speakup
@@ -23,8 +23,7 @@ What: /sys/accessibility/speakup/bleep_time
KernelVersion: 2.6
Contact: speakup@linux-speakup.org
Description: This controls the duration of the PC speaker beeps speakup
- produces.
- TODO: What are the units? Jiffies?
+ produces, in milliseconds.
What: /sys/accessibility/speakup/cursor_time
KernelVersion: 2.6
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds
2026-01-26 20:17 [PATCH] speakup: Clarify bleep_time unit is milliseconds Henry Zhang
@ 2026-01-26 21:49 ` Samuel Thibault
2026-01-27 14:55 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Samuel Thibault @ 2026-01-26 21:49 UTC (permalink / raw)
To: Henry Zhang
Cc: speakup, w.d.hubbs, chris, kirk, gregkh, linux-kernel,
Henry Zhang
Henry Zhang, le lun. 26 janv. 2026 15:17:07 -0500, a ecrit:
> The documentation had a TODO questioning whether the unit was in
> jiffies. The implementation in drivers/accessibility/speakup/main.c
> passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> in milliseconds.
>
> Signed-off-by: Henry Zhang <zeri@umich.edu>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Thanks!
> ---
> Documentation/ABI/stable/sysfs-driver-speakup | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Documentation/ABI/stable/sysfs-driver-speakup b/Documentation/ABI/stable/sysfs-driver-speakup
> index bcb6831aa114..8b508b4a7a00 100644
> --- a/Documentation/ABI/stable/sysfs-driver-speakup
> +++ b/Documentation/ABI/stable/sysfs-driver-speakup
> @@ -23,8 +23,7 @@ What: /sys/accessibility/speakup/bleep_time
> KernelVersion: 2.6
> Contact: speakup@linux-speakup.org
> Description: This controls the duration of the PC speaker beeps speakup
> - produces.
> - TODO: What are the units? Jiffies?
> + produces, in milliseconds.
>
> What: /sys/accessibility/speakup/cursor_time
> KernelVersion: 2.6
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds
2026-01-26 20:17 [PATCH] speakup: Clarify bleep_time unit is milliseconds Henry Zhang
2026-01-26 21:49 ` Samuel Thibault
@ 2026-01-27 14:55 ` Greg KH
2026-01-27 14:56 ` Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2026-01-27 14:55 UTC (permalink / raw)
To: Henry Zhang
Cc: speakup, w.d.hubbs, chris, kirk, samuel.thibault, linux-kernel,
Henry Zhang
On Mon, Jan 26, 2026 at 03:17:07PM -0500, Henry Zhang wrote:
> The documentation had a TODO questioning whether the unit was in
> jiffies. The implementation in drivers/accessibility/speakup/main.c
> passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> in milliseconds.
>
> Signed-off-by: Henry Zhang <zeri@umich.edu>
Does not match your From: line :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] speakup: Clarify bleep_time unit is milliseconds
2026-01-27 14:55 ` Greg KH
@ 2026-01-27 14:56 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-01-27 14:56 UTC (permalink / raw)
To: Henry Zhang
Cc: speakup, w.d.hubbs, chris, kirk, samuel.thibault, linux-kernel,
Henry Zhang
On Tue, Jan 27, 2026 at 03:55:07PM +0100, Greg KH wrote:
> On Mon, Jan 26, 2026 at 03:17:07PM -0500, Henry Zhang wrote:
> > The documentation had a TODO questioning whether the unit was in
> > jiffies. The implementation in drivers/accessibility/speakup/main.c
> > passes spk_bleep_time to msecs_to_jiffies(), confirming the unit is
> > in milliseconds.
> >
> > Signed-off-by: Henry Zhang <zeri@umich.edu>
>
> Does not match your From: line :(
Which my scripts did not seem to object to, so nevermind :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-27 14:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 20:17 [PATCH] speakup: Clarify bleep_time unit is milliseconds Henry Zhang
2026-01-26 21:49 ` Samuel Thibault
2026-01-27 14:55 ` Greg KH
2026-01-27 14:56 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox