* [PATCH] staging: rtl8723bs: Use kmemdup in sdio_ops.c
@ 2026-02-21 10:51 Giorgi Tchankvetadze
2026-02-21 13:20 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Giorgi Tchankvetadze @ 2026-02-21 10:51 UTC (permalink / raw)
To: gregkh, linux-staging; +Cc: linux-kernel, Giorgi Tchankvetadze
Replace kmalloc() + memcpy() with kmemdup() to simplify the code.
No functional change.
Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index c9cb20c61a2b..6e03d3d8a6ab 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -583,11 +583,10 @@ s32 sdio_local_write(
)
return sd_cmd52_write(intfhdl, addr, cnt, buf);
- tmpbuf = kmalloc(cnt, GFP_ATOMIC);
+ tmpbuf = kmemdup(buf, cnt, GFP_ATOMIC);
if (!tmpbuf)
return -ENOMEM;
- memcpy(tmpbuf, buf, cnt);
err = sd_write(intfhdl, addr, cnt, tmpbuf);
--
2.52.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: Use kmemdup in sdio_ops.c
2026-02-21 10:51 [PATCH] staging: rtl8723bs: Use kmemdup in sdio_ops.c Giorgi Tchankvetadze
@ 2026-02-21 13:20 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-02-21 13:20 UTC (permalink / raw)
To: Giorgi Tchankvetadze; +Cc: gregkh, linux-staging, linux-kernel
On Sat, Feb 21, 2026 at 02:51:49PM +0400, Giorgi Tchankvetadze wrote:
> Replace kmalloc() + memcpy() with kmemdup() to simplify the code.
> No functional change.
>
> Signed-off-by: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/sdio_ops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index c9cb20c61a2b..6e03d3d8a6ab 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -583,11 +583,10 @@ s32 sdio_local_write(
> )
> return sd_cmd52_write(intfhdl, addr, cnt, buf);
>
> - tmpbuf = kmalloc(cnt, GFP_ATOMIC);
> + tmpbuf = kmemdup(buf, cnt, GFP_ATOMIC);
> if (!tmpbuf)
> return -ENOMEM;
>
> - memcpy(tmpbuf, buf, cnt);
>
You need to delete a blank line here as well.
regards,
dan carpenter
> err = sd_write(intfhdl, addr, cnt, tmpbuf);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-21 13:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-21 10:51 [PATCH] staging: rtl8723bs: Use kmemdup in sdio_ops.c Giorgi Tchankvetadze
2026-02-21 13:20 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox