public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: MoeLeak <i@leak.moe>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dts: enable rtl8723ds on lichee pi 4a
Date: Sat, 25 Apr 2026 16:46:11 -0700	[thread overview]
Message-ID: <ae1SQ7QqPSCXCE6L@gen8> (raw)
In-Reply-To: <20260425070450.43148-1-i@leak.moe>

On Sat, Apr 25, 2026 at 03:04:50PM +0800, MoeLeak wrote:
> ---
>  .../boot/dts/thead/th1520-lichee-pi-4a.dts    | 23 +++++++++++++++++++
>  1 file changed, 23 insertions(+)

Hello, thanks for sending this patch. Please resend with a full commit
message including a Signed-off-by: tag [1].

What branch did you use to create this patch? It does not apply to
mainline.

> 
> diff --git a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> index a5b00c48d..46d3f21e3 100644
> --- a/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> +++ b/arch/riscv/boot/dts/thead/th1520-lichee-pi-4a.dts
> @@ -29,6 +29,7 @@ aliases {
>  		i2c2 = &i2c2;
>  		i2c3 = &i2c3;
>  		i2c4 = &i2c4;
> +		wifi0 = &rtl8723ds;
>  	};
>  
>  	chosen {
> @@ -119,6 +120,12 @@ vcc5v_usb: regulator-vcc5v_usb {
>  		enable-active-high;
>  		regulator-always-on;
>  	};
> +
> +	wifi_pwrseq: wifi-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		reset-gpios = <&ioexp2 4 GPIO_ACTIVE_LOW>;

This is not a valid phandle in the mainline dts for the th1520. Did you
base this patch on the vendor kernel?

Thanks,
Drew

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html

      reply	other threads:[~2026-04-25 23:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25  7:04 [PATCH] dts: enable rtl8723ds on lichee pi 4a MoeLeak
2026-04-25 23:46 ` Drew Fustini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ae1SQ7QqPSCXCE6L@gen8 \
    --to=fustini@kernel.org \
    --cc=i@leak.moe \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox