[PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Chaoyi Chen]

From: Chaoyi Chen <chaoyi.chen@rock-chips.com>

When TYPEC_DP_ALTMODE is enabled, DRM_AUX_HPD_BRIDGE is most likely
also needed for embedded platforms. Select it when available.

Suggested-by: Xu Yang <xu.yang_2@oss.nxp.com>
Signed-off-by: Chaoyi Chen <chaoyi.chen@rock-chips.com>
---
 drivers/usb/typec/altmodes/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/typec/altmodes/Kconfig b/drivers/usb/typec/altmodes/Kconfig
index 7867fa7c405d..1f35b253d6b8 100644
--- a/drivers/usb/typec/altmodes/Kconfig
+++ b/drivers/usb/typec/altmodes/Kconfig
@@ -5,6 +5,7 @@ menu "USB Type-C Alternate Mode drivers"
 config TYPEC_DP_ALTMODE
 	tristate "DisplayPort Alternate Mode driver"
 	depends on DRM
+	imply DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
 	help
 	  DisplayPort USB Type-C Alternate Mode allows DisplayPort
 	  displays and adapters to be attached to the USB Type-C
-- 
2.53.0

Re: [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Julian Braha]

Hi all,

On 7/5/26 07:58, Chaoyi Chen wrote:
> +	imply DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF

When I suggested that 'imply' may be more appropriate here on v1, I was
hoping to have more of a conversation first.

'Imply' is safer to use than 'select', and intended for use when the
option is highly preferred (but not actually required).

Perhaps Xu could provide an opinion?

- Julian Braha

Re: [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Chaoyi Chen]

Hi Julian,

On 7/5/2026 5:20 PM, Julian Braha wrote:
> Hi all,
> 
> On 7/5/26 07:58, Chaoyi Chen wrote:
>> +	imply DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> 
> When I suggested that 'imply' may be more appropriate here on v1, I was
> hoping to have more of a conversation first.
> 
> 'Imply' is safer to use than 'select', and intended for use when the
> option is highly preferred (but not actually required).
> 
> Perhaps Xu could provide an opinion?
> 

I think this is reasonable, as x86 works fine without DRM_AUX_HPD_BRIDGE.

-- 
Best, 
Chaoyi

Re: [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Julian Braha]

Hi Chaoyi,

On 7/5/26 10:37, Chaoyi Chen wrote:
> I think this is reasonable, as x86 works fine without DRM_AUX_HPD_BRIDGE.

Understood, thank you for clarifying.

I think this patch needs a v3 as the commit message and title no
longer match what the patch does and would make the commit history
confusing. Also, in the next version, could you add the changelog and
links to each previous revision below the '---'?

Finally, a link to the original conversation that led to this patch
would be good to add to the body:
https://lore.kernel.org/all/b2633b22-da30-4778-8e23-7b5bed9ead07@rock-chips.com/

Then I will give you my reviewed-by :)

- Julian Braha

Re: [PATCH v2] usb: typec: altmodes: select DRM_AUX_HPD_BRIDGE for TYPEC_DP_ALTMODE

[Xu Yang]

On Sun, Jul 05, 2026 at 10:20:03AM +0100, Julian Braha wrote:
> Hi all,
> 
> On 7/5/26 07:58, Chaoyi Chen wrote:
> > +     imply DRM_AUX_HPD_BRIDGE if DRM_BRIDGE && OF
> 
> When I suggested that 'imply' may be more appropriate here on v1, I was
> hoping to have more of a conversation first.
> 
> 'Imply' is safer to use than 'select', and intended for use when the
> option is highly preferred (but not actually required).
> 
> Perhaps Xu could provide an opinion?

Config DRM_AUX_HPD_BRIDGE is not user visiable, so I think "select" and
"imply" have the same effects here. And there is no force dependency bewteen
DRM_AUX_HPD_BRIDGE and TYPEC_DP_ALTMODE, it's ok for me to use imply here.

Thanks,
Xu Yang