* [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c
@ 2026-05-03 0:41 Francisco Maestre
2026-05-03 9:58 ` Nikolay Kulikov
0 siblings, 1 reply; 2+ messages in thread
From: Francisco Maestre @ 2026-05-03 0:41 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Francisco Maestre
Remove braces around a single-statement block in the SDIO
disconnect path, as per kernel coding style guidelines.
This fixes the following checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Francisco Maestre <francisco@maestretorreblanca.com>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e254912c..a86252ccac76 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
sdio_claim_host(func);
sdio_disable_func(func);
- if (dvobj->irq_alloc) {
+ if (dvobj->irq_alloc)
sdio_release_irq(func);
- }
sdio_release_host(func);
}
--
2.50.1 (Apple Git-155)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c
2026-05-03 0:41 [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c Francisco Maestre
@ 2026-05-03 9:58 ` Nikolay Kulikov
0 siblings, 0 replies; 2+ messages in thread
From: Nikolay Kulikov @ 2026-05-03 9:58 UTC (permalink / raw)
To: Francisco Maestre; +Cc: gregkh, linux-staging, linux-kernel
On Sat, May 02, 2026 at 07:41:44PM -0500, Francisco Maestre wrote:
> Remove braces around a single-statement block in the SDIO
> disconnect path, as per kernel coding style guidelines.
>
> This fixes the following checkpatch.pl warning:
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Francisco Maestre <francisco@maestretorreblanca.com>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..a86252ccac76 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
> sdio_claim_host(func);
> sdio_disable_func(func);
>
> - if (dvobj->irq_alloc) {
> + if (dvobj->irq_alloc)
> sdio_release_irq(func);
> - }
>
> sdio_release_host(func);
> }
> --
> 2.50.1 (Apple Git-155)
>
>
This is already fixed in staging-next.
Thanks,
Nikolay
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-03 9:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-03 0:41 [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces in sdio_intf.c Francisco Maestre
2026-05-03 9:58 ` Nikolay Kulikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox