From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@kernel.org>, Kees Cook <kees@kernel.org>,
Kusaram Devineni <kusaram@devineni.in>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@kernel.org>, Will Drewry <wad@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked()
Date: Thu, 14 May 2026 10:18:55 +0200 [thread overview]
Message-ID: <agWFb_ZHwg1ic2Pa@redhat.com> (raw)
In-Reply-To: <20260513165237.b7a2cad23da85997609f31b0@linux-foundation.org>
On 05/13, Andrew Morton wrote:
>
> On Sat, 2 May 2026 16:13:12 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
>
> > force_sig_info_to_task() calls send_signal_locked() but this is pointless;
> > info is always valid and has_si_pid_and_uid(info) should never be true.
> > Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid
> > overlaps with .si_addr/si_call_addr/etc.
>
> Thanks. AI review said things:
> https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC@redhat.com
Yes, yes, thanks.
I have already replied,
https://lore.kernel.org/all/afhmbCryeyIz0E3V@redhat.com/
Sashiko is right. Again!!!
This needs another version.
Oleg.
prev parent reply other threads:[~2026-05-14 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <afYGeHSWkLzXDlvC@redhat.com>
2026-05-13 23:52 ` [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked() Andrew Morton
2026-05-14 8:18 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agWFb_ZHwg1ic2Pa@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=kees@kernel.org \
--cc=kusaram@devineni.in \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@kernel.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox