* Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked()
[not found] <afYGeHSWkLzXDlvC@redhat.com>
@ 2026-05-13 23:52 ` Andrew Morton
2026-05-14 8:18 ` Oleg Nesterov
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Morton @ 2026-05-13 23:52 UTC (permalink / raw)
To: Oleg Nesterov
Cc: Andy Lutomirski, Kees Cook, Kusaram Devineni, Peter Zijlstra,
Thomas Gleixner, Will Drewry, linux-kernel
On Sat, 2 May 2026 16:13:12 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
> force_sig_info_to_task() calls send_signal_locked() but this is pointless;
> info is always valid and has_si_pid_and_uid(info) should never be true.
> Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid
> overlaps with .si_addr/si_call_addr/etc.
Thanks. AI review said things:
https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC@redhat.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked()
2026-05-13 23:52 ` [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked() Andrew Morton
@ 2026-05-14 8:18 ` Oleg Nesterov
0 siblings, 0 replies; 2+ messages in thread
From: Oleg Nesterov @ 2026-05-14 8:18 UTC (permalink / raw)
To: Andrew Morton
Cc: Andy Lutomirski, Kees Cook, Kusaram Devineni, Peter Zijlstra,
Thomas Gleixner, Will Drewry, linux-kernel
On 05/13, Andrew Morton wrote:
>
> On Sat, 2 May 2026 16:13:12 +0200 Oleg Nesterov <oleg@redhat.com> wrote:
>
> > force_sig_info_to_task() calls send_signal_locked() but this is pointless;
> > info is always valid and has_si_pid_and_uid(info) should never be true.
> > Forced signals do not carry si_pid/si_uid, not to mention that info.si_pid
> > overlaps with .si_addr/si_call_addr/etc.
>
> Thanks. AI review said things:
> https://sashiko.dev/#/patchset/afYGeHSWkLzXDlvC@redhat.com
Yes, yes, thanks.
I have already replied,
https://lore.kernel.org/all/afhmbCryeyIz0E3V@redhat.com/
Sashiko is right. Again!!!
This needs another version.
Oleg.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-14 8:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <afYGeHSWkLzXDlvC@redhat.com>
2026-05-13 23:52 ` [PATCH v2 1/2] signal: change force_sig_info_to_task() to call __send_signal_locked() Andrew Morton
2026-05-14 8:18 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox