From: Corey Minyard <corey@minyard.net>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data
Date: Fri, 29 May 2026 12:01:03 -0500 [thread overview]
Message-ID: <ahnGT7yytzIZn4ph@mail.minyard.net> (raw)
In-Reply-To: <5966a65daf432613a58af373af79c9c4421b3985.1780052427.git.u.kleine-koenig@baylibre.com>
On Fri, May 29, 2026 at 01:03:39PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly set the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop this
> unused assignments.
>
> While touching this array use a named initializer for assigning .name.
Sure, this is fine, it's in my next tree.
-corey
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> this patch is a preparation for changing struct platform_device_id
> see e.g.
> https://lore.kernel.org/all/cover.1779878004.git.u.kleine-koenig@baylibre.com/
> for the details about the quest.
>
> Best regards
> Uwe
>
> drivers/char/ipmi/ipmi_ssif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index add043b812ea..07f1d2327bb7 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -2127,7 +2127,7 @@ static void ssif_platform_remove(struct platform_device *dev)
> }
>
> static const struct platform_device_id ssif_plat_ids[] = {
> - { "dmi-ipmi-ssif", 0 },
> + { .name = "dmi-ipmi-ssif" },
> { }
> };
> MODULE_DEVICE_TABLE(platform, ssif_plat_ids);
>
> base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
> --
> 2.47.3
>
prev parent reply other threads:[~2026-05-29 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 11:03 [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-05-29 17:01 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahnGT7yytzIZn4ph@mail.minyard.net \
--to=corey@minyard.net \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox