* [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data
@ 2026-05-29 11:03 Uwe Kleine-König (The Capable Hub)
2026-05-29 17:01 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König (The Capable Hub) @ 2026-05-29 11:03 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, linux-kernel
The driver explicitly set the .driver_data member of struct
platform_device_id to zero without relying on that value. Drop this
unused assignments.
While touching this array use a named initializer for assigning .name.
Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,
this patch is a preparation for changing struct platform_device_id
see e.g.
https://lore.kernel.org/all/cover.1779878004.git.u.kleine-koenig@baylibre.com/
for the details about the quest.
Best regards
Uwe
drivers/char/ipmi/ipmi_ssif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index add043b812ea..07f1d2327bb7 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -2127,7 +2127,7 @@ static void ssif_platform_remove(struct platform_device *dev)
}
static const struct platform_device_id ssif_plat_ids[] = {
- { "dmi-ipmi-ssif", 0 },
+ { .name = "dmi-ipmi-ssif" },
{ }
};
MODULE_DEVICE_TABLE(platform, ssif_plat_ids);
base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data
2026-05-29 11:03 [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
@ 2026-05-29 17:01 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2026-05-29 17:01 UTC (permalink / raw)
To: Uwe Kleine-König (The Capable Hub); +Cc: openipmi-developer, linux-kernel
On Fri, May 29, 2026 at 01:03:39PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly set the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop this
> unused assignments.
>
> While touching this array use a named initializer for assigning .name.
Sure, this is fine, it's in my next tree.
-corey
>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> this patch is a preparation for changing struct platform_device_id
> see e.g.
> https://lore.kernel.org/all/cover.1779878004.git.u.kleine-koenig@baylibre.com/
> for the details about the quest.
>
> Best regards
> Uwe
>
> drivers/char/ipmi/ipmi_ssif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index add043b812ea..07f1d2327bb7 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -2127,7 +2127,7 @@ static void ssif_platform_remove(struct platform_device *dev)
> }
>
> static const struct platform_device_id ssif_plat_ids[] = {
> - { "dmi-ipmi-ssif", 0 },
> + { .name = "dmi-ipmi-ssif" },
> { }
> };
> MODULE_DEVICE_TABLE(platform, ssif_plat_ids);
>
> base-commit: f7af91adc230aa99e23330ecf85bc9badd9780ad
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-29 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-29 11:03 [PATCH v1] ipmi:ssif: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-05-29 17:01 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox