* [PATCH] ata: pata_pxa: Fix DMA channel leak on probe error
@ 2026-06-25 14:18 Wentao Liang
2026-06-26 11:10 ` Niklas Cassel
2026-06-26 21:44 ` Damien Le Moal
0 siblings, 2 replies; 3+ messages in thread
From: Wentao Liang @ 2026-06-25 14:18 UTC (permalink / raw)
To: dlemoal, cassel; +Cc: linux-ide, linux-kernel, Wentao Liang, stable
When dmaengine_slave_config() fails, the DMA channel acquired by
dma_request_chan() is not released before returning the error,
leaking the channel reference.
Fix by adding dma_release_channel() in the error path.
The ata_host_activate() error path already correctly releases the
DMA channel.
Cc: stable@vger.kernel.org
Fixes: 88622d80af82 ("ata: pata_pxa: dmaengine conversion")
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/ata/pata_pxa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
index 03dbaf4a13a7..9f63bdfb8576 100644
--- a/drivers/ata/pata_pxa.c
+++ b/drivers/ata/pata_pxa.c
@@ -286,6 +286,7 @@ static int pxa_ata_probe(struct platform_device *pdev)
ret = dmaengine_slave_config(data->dma_chan, &config);
if (ret < 0) {
dev_err(&pdev->dev, "dma configuration failed: %d\n", ret);
+ dma_release_channel(data->dma_chan);
return ret;
}
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: pata_pxa: Fix DMA channel leak on probe error
2026-06-25 14:18 [PATCH] ata: pata_pxa: Fix DMA channel leak on probe error Wentao Liang
@ 2026-06-26 11:10 ` Niklas Cassel
2026-06-26 21:44 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Cassel @ 2026-06-26 11:10 UTC (permalink / raw)
To: Wentao Liang; +Cc: dlemoal, linux-ide, linux-kernel, stable
On Thu, Jun 25, 2026 at 10:18:37PM +0800, Wentao Liang wrote:
> When dmaengine_slave_config() fails, the DMA channel acquired by
> dma_request_chan() is not released before returning the error,
> leaking the channel reference.
>
> Fix by adding dma_release_channel() in the error path.
>
> The ata_host_activate() error path already correctly releases the
> DMA channel.
>
> Cc: stable@vger.kernel.org
> Fixes: 88622d80af82 ("ata: pata_pxa: dmaengine conversion")
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
> ---
> drivers/ata/pata_pxa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
> index 03dbaf4a13a7..9f63bdfb8576 100644
> --- a/drivers/ata/pata_pxa.c
> +++ b/drivers/ata/pata_pxa.c
> @@ -286,6 +286,7 @@ static int pxa_ata_probe(struct platform_device *pdev)
> ret = dmaengine_slave_config(data->dma_chan, &config);
> if (ret < 0) {
> dev_err(&pdev->dev, "dma configuration failed: %d\n", ret);
> + dma_release_channel(data->dma_chan);
> return ret;
> }
>
> --
> 2.39.5 (Apple Git-154)
>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ata: pata_pxa: Fix DMA channel leak on probe error
2026-06-25 14:18 [PATCH] ata: pata_pxa: Fix DMA channel leak on probe error Wentao Liang
2026-06-26 11:10 ` Niklas Cassel
@ 2026-06-26 21:44 ` Damien Le Moal
1 sibling, 0 replies; 3+ messages in thread
From: Damien Le Moal @ 2026-06-26 21:44 UTC (permalink / raw)
To: Wentao Liang, cassel; +Cc: linux-ide, linux-kernel, stable
On 6/25/26 23:18, Wentao Liang wrote:
> When dmaengine_slave_config() fails, the DMA channel acquired by
> dma_request_chan() is not released before returning the error,
> leaking the channel reference.
>
> Fix by adding dma_release_channel() in the error path.
>
> The ata_host_activate() error path already correctly releases the
> DMA channel.
>
> Cc: stable@vger.kernel.org
> Fixes: 88622d80af82 ("ata: pata_pxa: dmaengine conversion")
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Applied to for-7.2-fixes. Thanks!
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-26 21:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-25 14:18 [PATCH] ata: pata_pxa: Fix DMA channel leak on probe error Wentao Liang
2026-06-26 11:10 ` Niklas Cassel
2026-06-26 21:44 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox