The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrea Righi <arighi@nvidia.com>
To: Christian Loehle <christian.loehle@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Felix Abecassis <fabecassis@nvidia.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	Phil Auld <pauld@redhat.com>,
	linux-kernel@vger.kernel.org,
	Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] sched/fair: Stabilize idle SMT core selection with asym-capacity
Date: Mon, 6 Jul 2026 18:46:37 +0200	[thread overview]
Message-ID: <akvb7ciJXN9jTaLK@gpd4> (raw)
In-Reply-To: <5c8d6545-2200-485f-87f5-f90e057a7a32@arm.com>

Hi Christian,

On Mon, Jul 06, 2026 at 12:40:58PM +0100, Christian Loehle wrote:
> On 7/3/26 18:07, Andrea Righi wrote:
> > On Fri, Jul 03, 2026 at 06:54:14PM +0200, Peter Zijlstra wrote:
> >> On Fri, Jul 03, 2026 at 04:52:17PM +0200, Andrea Righi wrote:
> >>
> >>> As mentioned in my other email, I found a surprising asymmetry on this machine:
> >>> pinning one worker per core to the first SMT siblings gives substantially better
> >>> performance than pinning them to the second siblings, despite firmware
> >>> advertising identical capacity and frequency for both.
> >>
> >> Cute, that's something that Power7 also had. That's where
> >> SD_ASYM_PACKING originated from.
> > 
> > Yep, I'm actually experimenting with a patch that mimics the Power7 and it
> > seems to work. :) But I'm using a quirk to detect the particular CPU
> > implementation to set SD_ASYM_PACKING on the SMT domain and assign a higher
> > arch_asym_cpu_priority() to the first sibling, which is not the best...
> > 
> > So I'm checking with the firmware folks whether they can expose the relative SMT
> > thread priority explicitly, so that the kernel can discover the asymmetry and
> > the preferred sibling, instead of relying on CPU type and enumeration order
> > (considering that there are also multiple SMT configurations that can alter this
> > asymmetry... it's not just SMT on/off).
> 
> Thanks for the explanation, interesting...
> So maybe we can fold the entire highest_perf thing into that, too, so you end up
> just with SD_ASYM_PACKING and not
> SD_ASYM_PACKING (for SMT sibling asymmetry)+CAS(for highest_perf core asymmetry),
> I think that would be a lot cleaner.

I think so. I need to try combining this with your SD_ASYM_PACKING series.

This is what I’m currently experimenting with, if you're curious (still WIP):
 git://git.kernel.org/pub/scm/linux/kernel/git/arighi/linux.git vr-smt

Thanks,
-Andrea

  reply	other threads:[~2026-07-06 16:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-30 15:27 [PATCH] sched/fair: Stabilize idle SMT core selection with asym-capacity Andrea Righi
2026-07-03  5:51 ` K Prateek Nayak
2026-07-03  9:40   ` Andrea Righi
2026-07-03 10:00     ` Christian Loehle
2026-07-03 14:52       ` Andrea Righi
2026-07-03 16:54         ` Peter Zijlstra
2026-07-03 17:07           ` Andrea Righi
2026-07-06 11:40             ` Christian Loehle
2026-07-06 16:46               ` Andrea Righi [this message]
2026-07-03 11:20     ` Julia Lawall
2026-07-03 14:38       ` Andrea Righi
2026-07-03 12:33     ` Andrea Righi
2026-07-03 12:51       ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=akvb7ciJXN9jTaLK@gpd4 \
    --to=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=christian.loehle@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=fabecassis@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=julia.lawall@inria.fr \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox