The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Michail Tatas <michail.tatas@gmail.com>
To: Doug Anderson <dianders@chromium.org>
Cc: michael@amarulasolutions.com, neil.armstrong@linaro.org,
	jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com,
	mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
	simona@ffwll.ch, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] drm/panel: ilitek-ili9805: Use dsi_multi in init
Date: Tue, 21 Jul 2026 23:39:44 +0300	[thread overview]
Message-ID: <al_ZEMZ-KEX-MJvy@michalis-linux> (raw)
In-Reply-To: <CAD=FV=XoyaqCwXCQagxmeSQKZi8nW2R-g8f8UpFFk-BHXq0OcA@mail.gmail.com>

Hello Doug,

> > +       mipi_dsi_dcs_write_seq_multi(ctx, 0xbb, 0x14, 0x55);
> > +       mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x08);
> > +       mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_PIXEL_FORMAT, 0x77);
> 
> You've already got my Reviewed-by tag, and I'm planning to merge this
> patch as-is. ...but my AI happened to notice that the above line could
> be:
> 
> mipi_dsi_dcs_set_pixel_format_multi(ctx, 0x77)
> 
> ...so I figured I'd at least mention it. ;-)
> 
> My AI also noticed (yet another) pre-existing issue that the "name"
> field of "struct ili9805_desc" isn't used in this driver...

Hahaha AI's like finding stuff like that, good catch.
I will include these changes in this patch and send a v4.

Regards,
Michail

  reply	other threads:[~2026-07-21 20:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-21 17:27 [PATCH v3 0/3] drm/panel: ilitek-ili9805: convert to *_multi API Michail Tatas
2026-07-21 17:27 ` [PATCH v3 1/3] drm/panel: ilitek-ili9805: Use _multi variants Michail Tatas
2026-07-21 17:27 ` [PATCH v3 2/3] drm/panel: ilitek-ili9805: Use dsi_multi in init Michail Tatas
2026-07-21 20:13   ` Doug Anderson
2026-07-21 20:39     ` Michail Tatas [this message]
2026-07-21 17:27 ` [PATCH v3 3/3] drm/panel: ilitek-ili9805: make cleanup funcs void Michail Tatas
2026-07-21 19:44 ` [PATCH v3 0/3] drm/panel: ilitek-ili9805: convert to *_multi API Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=al_ZEMZ-KEX-MJvy@michalis-linux \
    --to=michail.tatas@gmail.com \
    --cc=airlied@gmail.com \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=michael@amarulasolutions.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox