[PATCH v1] clk: qcom: Drop inclusions of <linux/mod_devicetable.h>

[PATCH v1] clk: qcom: Drop inclusions of <linux/mod_devicetable.h>

[Uwe Kleine-König (The Capable Hub)]

The only used symbol in these four drivers that is provided by
<linux/mod_devicetable.h> is of_device_id and this is also provided by
<linux/platform_device.h>. So drop the unneeded include which brings us
one step closer to removing <linux/mod_devicetable.h>.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
 drivers/clk/qcom/camcc-glymur.c | 1 -
 drivers/clk/qcom/evacc-glymur.c | 1 -
 drivers/clk/qcom/gcc-shikra.c   | 1 -
 drivers/clk/qcom/videocc-hawi.c | 1 -
 4 files changed, 4 deletions(-)

diff --git a/drivers/clk/qcom/camcc-glymur.c b/drivers/clk/qcom/camcc-glymur.c
index a80f05b7bc48..d4b11e6a6efc 100644
--- a/drivers/clk/qcom/camcc-glymur.c
+++ b/drivers/clk/qcom/camcc-glymur.c
@@ -4,7 +4,6 @@
  */
 
 #include <linux/clk-provider.h>
-#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
diff --git a/drivers/clk/qcom/evacc-glymur.c b/drivers/clk/qcom/evacc-glymur.c
index ba124cfc1a4d..7f031b05a94a 100644
--- a/drivers/clk/qcom/evacc-glymur.c
+++ b/drivers/clk/qcom/evacc-glymur.c
@@ -4,7 +4,6 @@
  */
 
 #include <linux/clk-provider.h>
-#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
diff --git a/drivers/clk/qcom/gcc-shikra.c b/drivers/clk/qcom/gcc-shikra.c
index d5222756f214..03e6a954de25 100644
--- a/drivers/clk/qcom/gcc-shikra.c
+++ b/drivers/clk/qcom/gcc-shikra.c
@@ -4,7 +4,6 @@
  */
 
 #include <linux/clk-provider.h>
-#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
diff --git a/drivers/clk/qcom/videocc-hawi.c b/drivers/clk/qcom/videocc-hawi.c
index ac3ff7202fa0..318270105dfe 100644
--- a/drivers/clk/qcom/videocc-hawi.c
+++ b/drivers/clk/qcom/videocc-hawi.c
@@ -4,7 +4,6 @@
  */
 
 #include <linux/clk-provider.h>
-#include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>

base-commit: b8809969e1d7a591e0f49dd464a5d04b3cf02ab1
-- 
2.55.0.11.g153666a7d9bb

Re: [PATCH v1] clk: qcom: Drop inclusions of <linux/mod_devicetable.h>

[Brian Masney]

On Thu, Jul 16, 2026 at 08:21:05PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> The only used symbol in these four drivers that is provided by
> <linux/mod_devicetable.h> is of_device_id and this is also provided by
> <linux/platform_device.h>.

I don't see it defined in platform_device, unless I am missing
something?

It looks like the reason this compiles is because of this chain of
includes:

linux/clk-provider.h -> linux/of.h -> linux/device-id/of.h


> So drop the unneeded include which brings us
> one step closer to removing <linux/mod_devicetable.h>.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>

With an updated commit message:

Reviewed-by: Brian Masney <bmasney@redhat.com>

Re: [PATCH v1] clk: qcom: Drop inclusions of <linux/mod_devicetable.h>

[Uwe Kleine-König (The Capable Hub)]

[-- Attachment #1: Type: text/plain, Size: 1452 bytes --]

Hello Brian,

On Thu, Jul 16, 2026 at 03:15:55PM -0400, Brian Masney wrote:
> On Thu, Jul 16, 2026 at 08:21:05PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > The only used symbol in these four drivers that is provided by
> > <linux/mod_devicetable.h> is of_device_id and this is also provided by
> > <linux/platform_device.h>.
> 
> I don't see it defined in platform_device, unless I am missing
> something?
> 
> It looks like the reason this compiles is because of this chain of
> includes:
> 
> linux/clk-provider.h -> linux/of.h -> linux/device-id/of.h

Well, the chain for <linux/platform_device.h> is:

	   <linux/platform_device.h>
	-> <linux/device.h>
	-> <linux/device/driver.h>
	-> <linux/device-id/of.h>

but the more relevant thing is: <linux/platform_device.h> makes use of
struct of_device_id and most consumer of that header (typically platform
drivers) need struct of_device_id. So it's very sensible that
<linux/platform_device.h> is enough to get that definition. The include
chain is just an implementation detail.
 
> > So drop the unneeded include which brings us
> > one step closer to removing <linux/mod_devicetable.h>.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> With an updated commit message:
> 
> Reviewed-by: Brian Masney <bmasney@redhat.com>

Does this discussion convince you that the commit log is ok as is?

Thanks
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

Re: [PATCH v1] clk: qcom: Drop inclusions of <linux/mod_devicetable.h>

[Brian Masney]

On Thu, Jul 16, 2026 at 09:55:23PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> On Thu, Jul 16, 2026 at 03:15:55PM -0400, Brian Masney wrote:
> > On Thu, Jul 16, 2026 at 08:21:05PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > > The only used symbol in these four drivers that is provided by
> > > <linux/mod_devicetable.h> is of_device_id and this is also provided by
> > > <linux/platform_device.h>.
> > 
> > I don't see it defined in platform_device, unless I am missing
> > something?
> > 
> > It looks like the reason this compiles is because of this chain of
> > includes:
> > 
> > linux/clk-provider.h -> linux/of.h -> linux/device-id/of.h
> 
> Well, the chain for <linux/platform_device.h> is:
> 
> 	   <linux/platform_device.h>
> 	-> <linux/device.h>
> 	-> <linux/device/driver.h>
> 	-> <linux/device-id/of.h>
> 
> but the more relevant thing is: <linux/platform_device.h> makes use of
> struct of_device_id and most consumer of that header (typically platform
> drivers) need struct of_device_id. So it's very sensible that
> <linux/platform_device.h> is enough to get that definition. The include
> chain is just an implementation detail.
>  
> > > So drop the unneeded include which brings us
> > > one step closer to removing <linux/mod_devicetable.h>.
> > > 
> > > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> > 
> > With an updated commit message:
> > 
> > Reviewed-by: Brian Masney <bmasney@redhat.com>
> 
> Does this discussion convince you that the commit log is ok as is?

Yes, agreed. Thanks for the clarification.

Brian