Re: [PATCH 1/2] x86/cpu/hygon: Introduce macros for hygon family numbers

[Ingo Molnar <mingo@kernel.org>]

* Guo Chaohong <guochaohong@open-hieco.net> wrote:

> 
> On 8/3/2026 2:10 PM, Peter Zijlstra wrote:
> > On Mon, Aug 03, 2026 at 01:12:47PM +0800, Chaohong Guo wrote:
> > > Consolidate all magic numbers of hygon CPUs into a header file,
> > > The macros describe the family/model numbers of hygon CPUs.
> > > 
> > > Signed-off-by: Chaohong Guo <guochaohong@open-hieco.net>
> > > Co-developed-by: Zhiquan Li <lizhiquan@open-hieco.net>
> > > Signed-off-by: Zhiquan Li <lizhiquan@open-hieco.net>
> > > ---
> > >   arch/x86/include/asm/cpu_device_id.h   |  2 ++
> > >   arch/x86/include/asm/processor-hygon.h | 20 ++++++++++++++++++++
> > >   2 files changed, 22 insertions(+)
> > >   create mode 100644 arch/x86/include/asm/processor-hygon.h
> > > 
> > > diff --git a/arch/x86/include/asm/cpu_device_id.h b/arch/x86/include/asm/cpu_device_id.h
> > > index c62d8fae52c3..447837d15f87 100644
> > > --- a/arch/x86/include/asm/cpu_device_id.h
> > > +++ b/arch/x86/include/asm/cpu_device_id.h
> > > @@ -44,6 +44,8 @@
> > >   #include <asm/intel-family.h>
> > >   /* And the X86_VENDOR_* ones */
> > >   #include <asm/processor.h>
> > > +/* Hygon HFM model defines */
> > > +#include <asm/processor-hygon.h>
> > I'll take these, but Boris, should I rename this to hygon-family.h to
> > match intel-family.h ?
> 
> 
> I will rename it to hygon-family.h, fix the SOB order as Boris suggested,
> and then send it out.

Please also:

 - Fix the 7447V model confusion problem I mentioned,

 - and take a good look at canonical header guard definition placement
   in existing x86 headers and use that format, not the random placement
   your patch introduces ...

Thanks,

	Ingo