[PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances

[PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances

[Hrushikesh Salunke]

In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
"serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
property. But "idle-states" is defined only for the lanes of first two
SERDES instances. For completeness, set the "idle-states" of lanes of
remaining SERDES instances to a default value of "unused".

Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>
---
This patch is based on commit
475c850a7fdd  Add linux-next specific files for 20250606

 arch/arm64/boot/dts/ti/k3-am69-sk.dts | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
index f28375629739..dcd7eb079766 100644
--- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
@@ -1295,7 +1295,11 @@ &serdes_ln_ctrl {
 	idle-states = <J784S4_SERDES0_LANE0_PCIE1_LANE0>, <J784S4_SERDES0_LANE1_PCIE1_LANE1>,
 		      <J784S4_SERDES0_LANE2_PCIE3_LANE0>, <J784S4_SERDES0_LANE3_USB>,
 			<J784S4_SERDES1_LANE0_PCIE0_LANE0>, <J784S4_SERDES1_LANE1_PCIE0_LANE1>,
-			<J784S4_SERDES1_LANE2_PCIE0_LANE2>, <J784S4_SERDES1_LANE3_PCIE0_LANE3>;
+			<J784S4_SERDES1_LANE2_PCIE0_LANE2>, <J784S4_SERDES1_LANE3_PCIE0_LANE3>,
+			<J784S4_SERDES2_LANE0_IP2_UNUSED>, <J784S4_SERDES2_LANE1_IP2_UNUSED>,
+			<J784S4_SERDES2_LANE2_IP3_UNUSED>, <J784S4_SERDES2_LANE3_IP3_UNUSED>,
+			<J784S4_SERDES4_LANE0_IP3_UNUSED>, <J784S4_SERDES4_LANE1_IP3_UNUSED>,
+			<J784S4_SERDES4_LANE2_IP3_UNUSED>, <J784S4_SERDES4_LANE3_IP4_UNUSED>;
 };
 
 &serdes_wiz0 {
-- 
2.34.1

Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances

[Siddharth Vadapalli]

On Mon, Jun 09, 2025 at 05:29:21PM +0530, Hrushikesh Salunke wrote:
> In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
> "serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
> property. But "idle-states" is defined only for the lanes of first two
> SERDES instances. For completeness, set the "idle-states" of lanes of
> remaining SERDES instances to a default value of "unused".
> 
> Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

Regards,
Siddharth.

Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances

[Siddharth Vadapalli]

On Wed, Jun 11, 2025 at 06:23:24PM +0530, Siddharth Vadapalli wrote:
> On Mon, Jun 09, 2025 at 05:29:21PM +0530, Hrushikesh Salunke wrote:
> > In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
> > "serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
> > property. But "idle-states" is defined only for the lanes of first two
> > SERDES instances. For completeness, set the "idle-states" of lanes of
> > remaining SERDES instances to a default value of "unused".
> > 
> > Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>
> 
> Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

I failed to notice that this change will introduce a regression on
AM69-SK for CPSW AND Display which rely on the SERDES Lane Mapping for
SERDES2 and SERDES4 being at their reset value of "zero". This patch
should be fixed by updating it to the following:

	<J784S4_SERDES2_LANE0_IP2_UNUSED>, <J784S4_SERDES2_LANE1_IP2_UNUSED>,
	<J784S4_SERDES2_LANE2_QSGMII_LANE1>, <J784S4_SERDES2_LANE3_QSGMII_LANE2>,
	<J784S4_SERDES4_LANE0_EDP_LANE0>, <J784S4_SERDES4_LANE1_EDP_LANE1>,
	<J784S4_SERDES4_LANE2_EDP_LANE2>, <J784S4_SERDES4_LANE3_EDP_LANE3>;


Regards,
Siddharth.

Re: [PATCH] arm64: dts: ti: k3-am69-sk: Add idle-states for remaining SERDES instances

[Hrushikesh Salunke]

On 19/06/25 11:35, Siddharth Vadapalli wrote:
> On Wed, Jun 11, 2025 at 06:23:24PM +0530, Siddharth Vadapalli wrote:
>> On Mon, Jun 09, 2025 at 05:29:21PM +0530, Hrushikesh Salunke wrote:
>>> In AM69 SoC there are 4 instances of the 4 lane SERDES. So in
>>> "serdes_ln_ctrl" node there are total 16 entries in "mux-reg-mask"
>>> property. But "idle-states" is defined only for the lanes of first two
>>> SERDES instances. For completeness, set the "idle-states" of lanes of
>>> remaining SERDES instances to a default value of "unused".
>>>
>>> Signed-off-by: Hrushikesh Salunke <h-salunke@ti.com>
>>
>> Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> 
> I failed to notice that this change will introduce a regression on
> AM69-SK for CPSW AND Display which rely on the SERDES Lane Mapping for
> SERDES2 and SERDES4 being at their reset value of "zero". This patch
> should be fixed by updating it to the following:
> 
> 	<J784S4_SERDES2_LANE0_IP2_UNUSED>, <J784S4_SERDES2_LANE1_IP2_UNUSED>,
> 	<J784S4_SERDES2_LANE2_QSGMII_LANE1>, <J784S4_SERDES2_LANE3_QSGMII_LANE2>,
> 	<J784S4_SERDES4_LANE0_EDP_LANE0>, <J784S4_SERDES4_LANE1_EDP_LANE1>,
> 	<J784S4_SERDES4_LANE2_EDP_LANE2>, <J784S4_SERDES4_LANE3_EDP_LANE3>;
> 
> 

Thanks for noticing this Siddharth. I will correct this and post the v2
for this patch.

Regards,
Hrushikesh