* [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
@ 2021-04-09 13:54 angkery
2021-04-09 14:02 ` Jens Axboe
2021-04-09 16:49 ` Sergei Shtylyov
0 siblings, 2 replies; 6+ messages in thread
From: angkery @ 2021-04-09 13:54 UTC (permalink / raw)
To: axboe; +Cc: linux-ide, linux-kernel, Junlin Yang
From: Junlin Yang <yangjunlin@yulong.com>
The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'irq', so making 'irq' an int, and change the position to
keep the code format.
./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
WARNING: Unsigned expression compared with zero: irq > 0
Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
---
drivers/ata/pata_ixp4xx_cf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
index abc0e87..43215a4 100644
--- a/drivers/ata/pata_ixp4xx_cf.c
+++ b/drivers/ata/pata_ixp4xx_cf.c
@@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap,
static int ixp4xx_pata_probe(struct platform_device *pdev)
{
- unsigned int irq;
struct resource *cs0, *cs1;
struct ata_host *host;
struct ata_port *ap;
struct ixp4xx_pata_data *data = dev_get_platdata(&pdev->dev);
int ret;
+ int irq;
cs0 = platform_get_resource(pdev, IORESOURCE_MEM, 0);
cs1 = platform_get_resource(pdev, IORESOURCE_MEM, 1);
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
2021-04-09 13:54 [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero angkery
@ 2021-04-09 14:02 ` Jens Axboe
2021-04-09 16:49 ` Sergei Shtylyov
1 sibling, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2021-04-09 14:02 UTC (permalink / raw)
To: angkery; +Cc: linux-ide, linux-kernel, Junlin Yang
On 4/9/21 7:54 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> The return from the call to platform_get_irq() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', so making 'irq' an int, and change the position to
> keep the code format.
>
> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> WARNING: Unsigned expression compared with zero: irq > 0
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
2021-04-09 13:54 [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero angkery
2021-04-09 14:02 ` Jens Axboe
@ 2021-04-09 16:49 ` Sergei Shtylyov
2021-04-09 17:02 ` Sergei Shtylyov
1 sibling, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2021-04-09 16:49 UTC (permalink / raw)
To: angkery, axboe; +Cc: linux-ide, linux-kernel, Junlin Yang
On 4/9/21 4:54 PM, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> The return from the call to platform_get_irq() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', so making 'irq' an int, and change the position to
> keep the code format.
>
> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> WARNING: Unsigned expression compared with zero: irq > 0
I'd understand < 0... but > 0? What tool warned about this issue?
> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> ---
> drivers/ata/pata_ixp4xx_cf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
> index abc0e87..43215a4 100644
> --- a/drivers/ata/pata_ixp4xx_cf.c
> +++ b/drivers/ata/pata_ixp4xx_cf.c
> @@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap,
>
> static int ixp4xx_pata_probe(struct platform_device *pdev)
> {
> - unsigned int irq;
Oops, not sure how I missed that. :-/
Thanks for fixing my overlook. :-)
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
2021-04-09 16:49 ` Sergei Shtylyov
@ 2021-04-09 17:02 ` Sergei Shtylyov
2021-04-09 23:38 ` angkery
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2021-04-09 17:02 UTC (permalink / raw)
To: angkery, axboe; +Cc: linux-ide, linux-kernel, Junlin Yang
On 4/9/21 7:49 PM, Sergei Shtylyov wrote:
>> From: Junlin Yang <yangjunlin@yulong.com>
>>
>> The return from the call to platform_get_irq() is int, it can be
>> a negative error code, however this is being assigned to an unsigned
>> int variable 'irq', so making 'irq' an int, and change the position to
>> keep the code format.
>>
>> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
>> WARNING: Unsigned expression compared with zero: irq > 0
>
> I'd understand < 0... but > 0? What tool warned about this issue?
>
>> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
>> ---
>> drivers/ata/pata_ixp4xx_cf.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/pata_ixp4xx_cf.c b/drivers/ata/pata_ixp4xx_cf.c
>> index abc0e87..43215a4 100644
>> --- a/drivers/ata/pata_ixp4xx_cf.c
>> +++ b/drivers/ata/pata_ixp4xx_cf.c
>> @@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct ata_port *ap,
>>
>> static int ixp4xx_pata_probe(struct platform_device *pdev)
>> {
>> - unsigned int irq;
>
> Oops, not sure how I missed that. :-/
> Thanks for fixing my overlook. :-)
Forgot to add my
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> [...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
2021-04-09 17:02 ` Sergei Shtylyov
@ 2021-04-09 23:38 ` angkery
2021-04-10 8:46 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: angkery @ 2021-04-09 23:38 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: axboe, linux-ide, linux-kernel, Junlin Yang
On Fri, 9 Apr 2021 20:02:56 +0300
Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote:
> On 4/9/21 7:49 PM, Sergei Shtylyov wrote:
>
> >> From: Junlin Yang <yangjunlin@yulong.com>
> >>
> >> The return from the call to platform_get_irq() is int, it can be
> >> a negative error code, however this is being assigned to an
> >> unsigned int variable 'irq', so making 'irq' an int, and change
> >> the position to keep the code format.
> >>
> >> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> >> WARNING: Unsigned expression compared with zero: irq > 0
> >
> > I'd understand < 0... but > 0? What tool warned about this issue?
> >
> > > yes, by coccicheck, i will update commits information.
> >
> >> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> >> ---
> >> drivers/ata/pata_ixp4xx_cf.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/ata/pata_ixp4xx_cf.c
> >> b/drivers/ata/pata_ixp4xx_cf.c index abc0e87..43215a4 100644
> >> --- a/drivers/ata/pata_ixp4xx_cf.c
> >> +++ b/drivers/ata/pata_ixp4xx_cf.c
> >> @@ -135,12 +135,12 @@ static void ixp4xx_setup_port(struct
> >> ata_port *ap,
> >> static int ixp4xx_pata_probe(struct platform_device *pdev)
> >> {
> >> - unsigned int irq;
> >
> > Oops, not sure how I missed that. :-/
> > Thanks for fixing my overlook. :-)
>
> Forgot to add my
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
>
> > [...]
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
2021-04-09 23:38 ` angkery
@ 2021-04-10 8:46 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2021-04-10 8:46 UTC (permalink / raw)
To: angkery; +Cc: axboe, linux-ide, linux-kernel, Junlin Yang
On 10.04.2021 2:38, angkery wrote:
> On Fri, 9 Apr 2021 20:02:56 +0300
> Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote:
>
>> On 4/9/21 7:49 PM, Sergei Shtylyov wrote:
>>
>>>> From: Junlin Yang <yangjunlin@yulong.com>
>>>>
>>>> The return from the call to platform_get_irq() is int, it can be
>>>> a negative error code, however this is being assigned to an
>>>> unsigned int variable 'irq', so making 'irq' an int, and change
>>>> the position to keep the code format.
>>>>
>>>> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
>>>> WARNING: Unsigned expression compared with zero: irq > 0
>>>
>>> I'd understand < 0... but > 0? What tool warned about this issue?
>>>
>>>> yes, by coccicheck, i will update commits information.
Thanks!
Yet, looking at your subject, the above should read irq < 0, not > 0.
>>>> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-10 8:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-09 13:54 [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero angkery
2021-04-09 14:02 ` Jens Axboe
2021-04-09 16:49 ` Sergei Shtylyov
2021-04-09 17:02 ` Sergei Shtylyov
2021-04-09 23:38 ` angkery
2021-04-10 8:46 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox