* [PATCH RESEND] soundwire: amd: clear wake enable register for
@ 2024-12-03 9:10 Vijendar Mukunda
2024-12-03 9:23 ` Mukunda,Vijendar
2024-12-23 6:08 ` Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Vijendar Mukunda @ 2024-12-03 9:10 UTC (permalink / raw)
To: vkoul
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Basavaraj.Hiregoudar, Sunil-kumar.Dommati, venkataprasad.potturu,
Mario.Limonciello, linux-sound, linux-kernel, alsa-devel,
Vijendar Mukunda
As per design for power off mode, clear the wake enable register during
resume sequence.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
drivers/soundwire/amd_manager.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
index 5a4bfaef65fb..96a3aa6da711 100644
--- a/drivers/soundwire/amd_manager.c
+++ b/drivers/soundwire/amd_manager.c
@@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
return amd_sdw_clock_stop_exit(amd_manager);
} else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
+ writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
if (val) {
val |= AMD_SDW_CLK_RESUME_REQ;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] soundwire: amd: clear wake enable register for
2024-12-03 9:10 [PATCH RESEND] soundwire: amd: clear wake enable register for Vijendar Mukunda
@ 2024-12-03 9:23 ` Mukunda,Vijendar
2024-12-23 6:08 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Mukunda,Vijendar @ 2024-12-03 9:23 UTC (permalink / raw)
To: vkoul
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Basavaraj.Hiregoudar, Sunil-kumar.Dommati, venkataprasad.potturu,
Mario.Limonciello, linux-sound, linux-kernel, alsa-devel
On 03/12/24 14:40, Vijendar Mukunda wrote:
> As per design for power off mode, clear the wake enable register during
> resume sequence.
Ignore this patch as commit title was incomplete.
Resent the patch again.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> drivers/soundwire/amd_manager.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
> index 5a4bfaef65fb..96a3aa6da711 100644
> --- a/drivers/soundwire/amd_manager.c
> +++ b/drivers/soundwire/amd_manager.c
> @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
> if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
> return amd_sdw_clock_stop_exit(amd_manager);
> } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
> + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
> val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
> if (val) {
> val |= AMD_SDW_CLK_RESUME_REQ;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] soundwire: amd: clear wake enable register for
2024-12-03 9:10 [PATCH RESEND] soundwire: amd: clear wake enable register for Vijendar Mukunda
2024-12-03 9:23 ` Mukunda,Vijendar
@ 2024-12-23 6:08 ` Vinod Koul
2024-12-23 6:13 ` Mukunda,Vijendar
1 sibling, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2024-12-23 6:08 UTC (permalink / raw)
To: Vijendar Mukunda
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Basavaraj.Hiregoudar, Sunil-kumar.Dommati, venkataprasad.potturu,
Mario.Limonciello, linux-sound, linux-kernel, alsa-devel
On 03-12-24, 14:40, Vijendar Mukunda wrote:
for...? Pls write the full subject
> As per design for power off mode, clear the wake enable register during
> resume sequence.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> drivers/soundwire/amd_manager.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
> index 5a4bfaef65fb..96a3aa6da711 100644
> --- a/drivers/soundwire/amd_manager.c
> +++ b/drivers/soundwire/amd_manager.c
> @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
> if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
> return amd_sdw_clock_stop_exit(amd_manager);
> } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
> + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
no need for 0x for a zero value
> val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
> if (val) {
> val |= AMD_SDW_CLK_RESUME_REQ;
> --
> 2.34.1
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND] soundwire: amd: clear wake enable register for
2024-12-23 6:08 ` Vinod Koul
@ 2024-12-23 6:13 ` Mukunda,Vijendar
0 siblings, 0 replies; 4+ messages in thread
From: Mukunda,Vijendar @ 2024-12-23 6:13 UTC (permalink / raw)
To: Vinod Koul
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale,
Basavaraj.Hiregoudar, Sunil-kumar.Dommati, venkataprasad.potturu,
Mario.Limonciello, linux-sound, linux-kernel, alsa-devel
On 23/12/24 11:38, Vinod Koul wrote:
> On 03-12-24, 14:40, Vijendar Mukunda wrote:
>
> for...? Pls write the full subject
Patch commit title was not updated properly.
I have already respin the patch by updating the subject.
Sent a mail to ignore this patch as commit message is incomplete.
>
>> As per design for power off mode, clear the wake enable register during
>> resume sequence.
>>
>> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
>> ---
>> drivers/soundwire/amd_manager.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
>> index 5a4bfaef65fb..96a3aa6da711 100644
>> --- a/drivers/soundwire/amd_manager.c
>> +++ b/drivers/soundwire/amd_manager.c
>> @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
>> if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
>> return amd_sdw_clock_stop_exit(amd_manager);
>> } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
>> + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
> no need for 0x for a zero value
Will fix it and post v2 version.
>
>> val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
>> if (val) {
>> val |= AMD_SDW_CLK_RESUME_REQ;
>> --
>> 2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-23 6:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-03 9:10 [PATCH RESEND] soundwire: amd: clear wake enable register for Vijendar Mukunda
2024-12-03 9:23 ` Mukunda,Vijendar
2024-12-23 6:08 ` Vinod Koul
2024-12-23 6:13 ` Mukunda,Vijendar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox