public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pinctrl: qcom: nord: remove duplicated pin function
@ 2026-05-06  9:00 Bartosz Golaszewski
  2026-05-06  9:10 ` Konrad Dybcio
  2026-05-06 14:11 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-05-06  9:00 UTC (permalink / raw)
  To: Bjorn Andersson, Linus Walleij, Maulik Shah, Shawn Guo,
	Dmitry Baryshkov, Pankaj Patil
  Cc: brgl, linux-arm-msm, linux-gpio, linux-kernel,
	Bartosz Golaszewski, kernel test robot

The qdss_cti function is initialized twice in the nord_functions array.
Remove the duplicate entry.

Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
---
 drivers/pinctrl/qcom/pinctrl-nord.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-nord.c b/drivers/pinctrl/qcom/pinctrl-nord.c
index f14361101bf4..7c21306e77ff 100644
--- a/drivers/pinctrl/qcom/pinctrl-nord.c
+++ b/drivers/pinctrl/qcom/pinctrl-nord.c
@@ -1417,7 +1417,6 @@ static const struct pinfunction nord_functions[] = {
 	MSM_PIN_FUNCTION(prng_rosc0),
 	MSM_PIN_FUNCTION(prng_rosc1),
 	MSM_PIN_FUNCTION(pwrbrk_i_n),
-	MSM_PIN_FUNCTION(qdss_cti),
 	MSM_PIN_FUNCTION(qdss),
 	MSM_PIN_FUNCTION(qdss_cti),
 	MSM_PIN_FUNCTION(qspi),
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: qcom: nord: remove duplicated pin function
  2026-05-06  9:00 [PATCH] pinctrl: qcom: nord: remove duplicated pin function Bartosz Golaszewski
@ 2026-05-06  9:10 ` Konrad Dybcio
  2026-05-06 14:11 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-05-06  9:10 UTC (permalink / raw)
  To: Bartosz Golaszewski, Bjorn Andersson, Linus Walleij, Maulik Shah,
	Shawn Guo, Dmitry Baryshkov, Pankaj Patil
  Cc: brgl, linux-arm-msm, linux-gpio, linux-kernel, kernel test robot

On 5/6/26 11:00 AM, Bartosz Golaszewski wrote:
> The qdss_cti function is initialized twice in the nord_functions array.
> Remove the duplicate entry.
> 
> Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] pinctrl: qcom: nord: remove duplicated pin function
  2026-05-06  9:00 [PATCH] pinctrl: qcom: nord: remove duplicated pin function Bartosz Golaszewski
  2026-05-06  9:10 ` Konrad Dybcio
@ 2026-05-06 14:11 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-06 14:11 UTC (permalink / raw)
  To: Bartosz Golaszewski, Bjorn Andersson, Linus Walleij, Maulik Shah,
	Shawn Guo, Dmitry Baryshkov, Pankaj Patil
  Cc: brgl, linux-arm-msm, linux-gpio, linux-kernel, kernel test robot

On 06/05/2026 11:00, Bartosz Golaszewski wrote:
> The qdss_cti function is initialized twice in the nord_functions array.
> Remove the duplicate entry.
> 
> Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
>  drivers/pinctrl/qcom/pinctrl-nord.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-nord.c b/drivers/pinctrl/qcom/pinctrl-nord.c
> index f14361101bf4..7c21306e77ff 100644
> --- a/drivers/pinctrl/qcom/pinctrl-nord.c
> +++ b/drivers/pinctrl/qcom/pinctrl-nord.c
> @@ -1417,7 +1417,6 @@ static const struct pinfunction nord_functions[] = {
>  	MSM_PIN_FUNCTION(prng_rosc0),
>  	MSM_PIN_FUNCTION(prng_rosc1),
>  	MSM_PIN_FUNCTION(pwrbrk_i_n),
> -	MSM_PIN_FUNCTION(qdss_cti),
>  	MSM_PIN_FUNCTION(qdss),
>  	MSM_PIN_FUNCTION(qdss_cti),
>  	MSM_PIN_FUNCTION(qspi),

I also see on my allyes builders -Winitializer-overrides.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-06 14:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06  9:00 [PATCH] pinctrl: qcom: nord: remove duplicated pin function Bartosz Golaszewski
2026-05-06  9:10 ` Konrad Dybcio
2026-05-06 14:11 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox