* [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall
@ 2024-11-09 5:50 guanjing
2024-11-12 9:25 ` Alexandre TORGUE
2024-12-12 15:32 ` [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall Alexandre TORGUE
0 siblings, 2 replies; 6+ messages in thread
From: guanjing @ 2024-11-09 5:50 UTC (permalink / raw)
To: mcoquelin.stm32, alexandre.torgue
Cc: linux-stm32, linux-arm-kernel, linux-kernel, guanjing
Remove misplaced colon in stm32_firewall_get_firewall()
which results in a syntax error when the code is compiled
without CONFIG_STM32_FIREWALL.
Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
---
include/linux/bus/stm32_firewall_device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/bus/stm32_firewall_device.h b/include/linux/bus/stm32_firewall_device.h
index 18e0a2fc3816..5178b72bc920 100644
--- a/include/linux/bus/stm32_firewall_device.h
+++ b/include/linux/bus/stm32_firewall_device.h
@@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct stm32_firewall *firewall, u32 su
#else /* CONFIG_STM32_FIREWALL */
int stm32_firewall_get_firewall(struct device_node *np, struct stm32_firewall *firewall,
- unsigned int nb_firewall);
+ unsigned int nb_firewall)
{
return -ENODEV;
}
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall
2024-11-09 5:50 [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall guanjing
@ 2024-11-12 9:25 ` Alexandre TORGUE
2024-11-12 9:40 ` Gatien CHEVALLIER
2024-12-12 15:32 ` [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall Alexandre TORGUE
1 sibling, 1 reply; 6+ messages in thread
From: Alexandre TORGUE @ 2024-11-12 9:25 UTC (permalink / raw)
To: guanjing, mcoquelin.stm32
Cc: linux-stm32, linux-arm-kernel, linux-kernel, Gatien CHEVALLIER
Hi
On 11/9/24 06:50, guanjing wrote:
> Remove misplaced colon in stm32_firewall_get_firewall()
> which results in a syntax error when the code is compiled
> without CONFIG_STM32_FIREWALL.
>
> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
> ---
> include/linux/bus/stm32_firewall_device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/bus/stm32_firewall_device.h b/include/linux/bus/stm32_firewall_device.h
> index 18e0a2fc3816..5178b72bc920 100644
> --- a/include/linux/bus/stm32_firewall_device.h
> +++ b/include/linux/bus/stm32_firewall_device.h
> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct stm32_firewall *firewall, u32 su
> #else /* CONFIG_STM32_FIREWALL */
>
> int stm32_firewall_get_firewall(struct device_node *np, struct stm32_firewall *firewall,
> - unsigned int nb_firewall);
> + unsigned int nb_firewall)
> {
> return -ENODEV;
> }
Acked-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
Thanks
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall
2024-11-12 9:25 ` Alexandre TORGUE
@ 2024-11-12 9:40 ` Gatien CHEVALLIER
2024-11-21 9:19 ` [PATCH v2] firewall: remove misplaced semicolon fromstm32_firewall_get_firewall guanjing
0 siblings, 1 reply; 6+ messages in thread
From: Gatien CHEVALLIER @ 2024-11-12 9:40 UTC (permalink / raw)
To: Alexandre TORGUE, guanjing, mcoquelin.stm32
Cc: linux-stm32, linux-arm-kernel, linux-kernel
On 11/12/24 10:25, Alexandre TORGUE wrote:
> Hi
>
> On 11/9/24 06:50, guanjing wrote:
>> Remove misplaced colon in stm32_firewall_get_firewall()
>> which results in a syntax error when the code is compiled
>> without CONFIG_STM32_FIREWALL.
>>
>> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
>> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
>> ---
>> include/linux/bus/stm32_firewall_device.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/linux/bus/stm32_firewall_device.h
>> b/include/linux/bus/stm32_firewall_device.h
>> index 18e0a2fc3816..5178b72bc920 100644
>> --- a/include/linux/bus/stm32_firewall_device.h
>> +++ b/include/linux/bus/stm32_firewall_device.h
>> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct
>> stm32_firewall *firewall, u32 su
>> #else /* CONFIG_STM32_FIREWALL */
>> int stm32_firewall_get_firewall(struct device_node *np, struct
>> stm32_firewall *firewall,
>> - unsigned int nb_firewall);
>> + unsigned int nb_firewall)
>> {
>> return -ENODEV;
>> }
>
> Acked-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>
> Thanks
> Alex
Hi, please use get_maintainers.pl script next time so that
adequate people are put in To/CC.
Nevertheless, thanks for the patch!
Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] firewall: remove misplaced semicolon fromstm32_firewall_get_firewall
2024-11-12 9:40 ` Gatien CHEVALLIER
@ 2024-11-21 9:19 ` guanjing
2024-11-21 21:16 ` Jeff Johnson
0 siblings, 1 reply; 6+ messages in thread
From: guanjing @ 2024-11-21 9:19 UTC (permalink / raw)
To: Gatien CHEVALLIER, Alexandre TORGUE, mcoquelin.stm32
Cc: linux-stm32, linux-arm-kernel, linux-kernel
Thanks for your advice. I apologize for the omission. :)
On 2024/11/12 17:40, Gatien CHEVALLIER wrote:
> On 11/12/24 10:25, Alexandre TORGUE wrote:
>> Hi
>>
>> On 11/9/24 06:50, guanjing wrote:
>>> Remove misplaced colon in stm32_firewall_get_firewall()
>>> which results in a syntax error when the code is compiled
>>> without CONFIG_STM32_FIREWALL.
>>>
>>> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
>>> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
>>> ---
>>> include/linux/bus/stm32_firewall_device.h | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/linux/bus/stm32_firewall_device.h
>>> b/include/linux/bus/stm32_firewall_device.h
>>> index 18e0a2fc3816..5178b72bc920 100644
>>> --- a/include/linux/bus/stm32_firewall_device.h
>>> +++ b/include/linux/bus/stm32_firewall_device.h
>>> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct
>>> stm32_firewall *firewall, u32 su
>>> #else /* CONFIG_STM32_FIREWALL */
>>> int stm32_firewall_get_firewall(struct device_node *np, struct
>>> stm32_firewall *firewall,
>>> - unsigned int nb_firewall);
>>> + unsigned int nb_firewall)
>>> {
>>> return -ENODEV;
>>> }
>>
>> Acked-by: Alexandre Torgue <alexandre.torgue@foss.st.com>
>>
>> Thanks
>> Alex
>
> Hi, please use get_maintainers.pl script next time so that
> adequate people are put in To/CC.
> Nevertheless, thanks for the patch!
>
> Reviewed-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall
2024-11-09 5:50 [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall guanjing
2024-11-12 9:25 ` Alexandre TORGUE
@ 2024-12-12 15:32 ` Alexandre TORGUE
1 sibling, 0 replies; 6+ messages in thread
From: Alexandre TORGUE @ 2024-12-12 15:32 UTC (permalink / raw)
To: guanjing, mcoquelin.stm32; +Cc: linux-stm32, linux-arm-kernel, linux-kernel
Hi
On 11/9/24 06:50, guanjing wrote:
> Remove misplaced colon in stm32_firewall_get_firewall()
> which results in a syntax error when the code is compiled
> without CONFIG_STM32_FIREWALL.
>
> Fixes: 5c9668cfc6d7 ("firewall: introduce stm32_firewall framework")
> Signed-off-by: guanjing <guanjing@cmss.chinamobile.com>
> ---
> include/linux/bus/stm32_firewall_device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/bus/stm32_firewall_device.h b/include/linux/bus/stm32_firewall_device.h
> index 18e0a2fc3816..5178b72bc920 100644
> --- a/include/linux/bus/stm32_firewall_device.h
> +++ b/include/linux/bus/stm32_firewall_device.h
> @@ -115,7 +115,7 @@ void stm32_firewall_release_access_by_id(struct stm32_firewall *firewall, u32 su
> #else /* CONFIG_STM32_FIREWALL */
>
> int stm32_firewall_get_firewall(struct device_node *np, struct stm32_firewall *firewall,
> - unsigned int nb_firewall);
> + unsigned int nb_firewall)
> {
> return -ENODEV;
> }
Applied on stm32-next.
Regards
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-12-12 15:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-09 5:50 [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall guanjing
2024-11-12 9:25 ` Alexandre TORGUE
2024-11-12 9:40 ` Gatien CHEVALLIER
2024-11-21 9:19 ` [PATCH v2] firewall: remove misplaced semicolon fromstm32_firewall_get_firewall guanjing
2024-11-21 21:16 ` Jeff Johnson
2024-12-12 15:32 ` [PATCH v2] firewall: remove misplaced semicolon from stm32_firewall_get_firewall Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox