From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Rik van Riel <riel@surriel.com>, linux-kernel@vger.kernel.org
Cc: kernel-team@fb.com, pjt@google.com, peterz@infradead.org,
mingo@redhat.com, morten.rasmussen@arm.com, tglx@linutronix.de,
mgorman@techsingularity.net, vincent.guittot@linaro.org,
Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH 01/14] sched: introduce task_se_h_load helper
Date: Mon, 12 Aug 2019 19:40:03 +0200 [thread overview]
Message-ID: <ddfaa51b-2b4a-e235-031a-dca1092bab93@arm.com> (raw)
In-Reply-To: <20190722173348.9241-2-riel@surriel.com>
On 7/22/19 7:33 PM, Rik van Riel wrote:
> Sometimes the hierarchical load of a sched_entity needs to be calculated.
> Rename task_h_load to task_se_h_load, and directly pass a sched_entity to
> that function.
>
> Move the function declaration up above where it will be used later.
>
> No functional changes.
>
> Signed-off-by: Rik van Riel <riel@surriel.com>
> Reviewed-by: Josef Bacik <josef@toxicpanda.com>
[...]
> /* Give new sched_entity start runnable values to heavy its load in infant time */
> @@ -1668,7 +1668,7 @@ static void task_numa_compare(struct task_numa_env *env,
> /*
> * In the overloaded case, try and keep the load balanced.
> */
> - load = task_h_load(env->p) - task_h_load(cur);
> + load = task_se_h_load(env->p->se) - task_se_h_load(cur->se);
Shouldn't this be:
load = task_se_h_load(&env->p->se) - task_se_h_load(&cur->se);
> if (!load)
> goto assign;
>
> @@ -1706,7 +1706,7 @@ static void task_numa_find_cpu(struct task_numa_env *env,
> bool maymove = false;
> int cpu;
>
> - load = task_h_load(env->p);
> + load = task_se_h_load(env->p->se);
load = task_se_h_load(&env->p->se);
[...]
next prev parent reply other threads:[~2019-08-12 17:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 17:33 [PATCH RFC v3 0/14] sched,fair: flatten CPU controller runqueues Rik van Riel
2019-07-22 17:33 ` [PATCH 01/14] sched: introduce task_se_h_load helper Rik van Riel
2019-08-12 17:40 ` Dietmar Eggemann [this message]
2019-07-22 17:33 ` [PATCH 02/14] sched: change /proc/sched_debug fields Rik van Riel
2019-07-22 17:33 ` [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h_load Rik van Riel
2019-07-29 20:05 ` Peter Zijlstra
2019-07-29 21:13 ` Rik van Riel
2019-07-29 20:11 ` Peter Zijlstra
2019-07-29 20:26 ` Peter Zijlstra
2019-07-22 17:33 ` [PATCH 04/14] sched,fair: move runnable_load_avg to cfs_rq Rik van Riel
2019-07-30 8:55 ` Peter Zijlstra
2019-07-22 17:33 ` [PATCH 06/14] sched,cfs: use explicit cfs_rq of parent se helper Rik van Riel
2019-07-22 17:33 ` [PATCH 07/14] sched,cfs: fix zero length timeslice calculation Rik van Riel
2019-07-22 17:33 ` [PATCH 08/14] sched,fair: simplify timeslice length code Rik van Riel
2019-07-22 17:33 ` [PATCH 09/14] sched,fair: refactor enqueue/dequeue_entity Rik van Riel
2019-07-30 9:36 ` Peter Zijlstra
2019-07-30 12:58 ` Rik van Riel
2019-07-31 9:35 ` Peter Zijlstra
2019-07-31 15:03 ` Rik van Riel
2019-07-31 15:30 ` Peter Zijlstra
2019-07-22 17:33 ` [PATCH 10/14] sched,fair: add helper functions for flattened runqueue Rik van Riel
2019-07-22 17:33 ` [PATCH 11/14] sched,fair: flatten hierarchical runqueues Rik van Riel
2019-07-22 17:33 ` [PATCH 12/14] sched,fair: track cfs_rq->max_h_load for more legitimate h_weight Rik van Riel
2019-07-22 17:33 ` [PATCH 13/14] sched,fair: flatten update_curr functionality Rik van Riel
2019-07-22 17:33 ` [PATCH 14/14] sched,fair: propagate sum_exec_runtime up the hierarchy Rik van Riel
2019-07-30 16:29 ` [PATCH RFC v3 0/14] sched,fair: flatten CPU controller runqueues Peter Zijlstra
2019-07-30 18:27 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddfaa51b-2b4a-e235-031a-dca1092bab93@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=riel@surriel.com \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox