* [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX
@ 2022-03-17 13:19 YueHaibing
2022-03-17 13:59 ` Shawn Guo
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: YueHaibing @ 2022-03-17 13:19 UTC (permalink / raw)
To: tglx, maz, shawn.guo; +Cc: linux-kernel, YueHaibing
If MAILBOX is n, building fails:
drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
Make QCOM_MPM depends on MAILBOX to fix this.
Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 680d2fcf2686..15edb9a6fcae 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -433,6 +433,7 @@ config QCOM_PDC
config QCOM_MPM
tristate "QCOM MPM"
depends on ARCH_QCOM
+ depends on MAILBOX
select IRQ_DOMAIN_HIERARCHY
help
MSM Power Manager driver to manage and configure wakeup
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX
2022-03-17 13:19 [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX YueHaibing
@ 2022-03-17 13:59 ` Shawn Guo
2022-03-17 15:27 ` Marc Zyngier
2022-03-17 15:33 ` [irqchip: irq/irqchip-next] " irqchip-bot for YueHaibing
2022-04-05 15:40 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for YueHaibing
2 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2022-03-17 13:59 UTC (permalink / raw)
To: YueHaibing; +Cc: tglx, maz, linux-kernel
On Thu, Mar 17, 2022 at 09:19:56PM +0800, YueHaibing wrote:
> If MAILBOX is n, building fails:
>
> drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
> irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
> irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
>
> Make QCOM_MPM depends on MAILBOX to fix this.
>
> Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/irqchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 680d2fcf2686..15edb9a6fcae 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -433,6 +433,7 @@ config QCOM_PDC
> config QCOM_MPM
> tristate "QCOM MPM"
> depends on ARCH_QCOM
> + depends on MAILBOX
> select IRQ_DOMAIN_HIERARCHY
> help
> MSM Power Manager driver to manage and configure wakeup
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX
2022-03-17 13:59 ` Shawn Guo
@ 2022-03-17 15:27 ` Marc Zyngier
0 siblings, 0 replies; 5+ messages in thread
From: Marc Zyngier @ 2022-03-17 15:27 UTC (permalink / raw)
To: Shawn Guo; +Cc: YueHaibing, tglx, linux-kernel
On 2022-03-17 13:59, Shawn Guo wrote:
> On Thu, Mar 17, 2022 at 09:19:56PM +0800, YueHaibing wrote:
>> If MAILBOX is n, building fails:
>>
>> drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
>> irq-qcom-mpm.c:(.text+0x174): undefined reference to
>> `mbox_send_message'
>> irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit:
>> R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
>>
>> Make QCOM_MPM depends on MAILBOX to fix this.
>>
>> Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
>
>> ---
>> drivers/irqchip/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 680d2fcf2686..15edb9a6fcae 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -433,6 +433,7 @@ config QCOM_PDC
>> config QCOM_MPM
>> tristate "QCOM MPM"
>> depends on ARCH_QCOM
>> + depends on MAILBOX
>> select IRQ_DOMAIN_HIERARCHY
>> help
>> MSM Power Manager driver to manage and configure wakeup
>> --
>> 2.17.1
>>
Hmmm... Even if that fix the build, this still isn't correct, is it?
You also need the mailbox *driver* to be selected. How is that
dependency enforced?
I'll queue this to fix -next, but this really is papering over
a bigger problem.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 5+ messages in thread
* [irqchip: irq/irqchip-next] irq/qcom-mpm: Fix build error without MAILBOX
2022-03-17 13:19 [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX YueHaibing
2022-03-17 13:59 ` Shawn Guo
@ 2022-03-17 15:33 ` irqchip-bot for YueHaibing
2022-04-05 15:40 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for YueHaibing
2 siblings, 0 replies; 5+ messages in thread
From: irqchip-bot for YueHaibing @ 2022-03-17 15:33 UTC (permalink / raw)
To: linux-kernel; +Cc: YueHaibing, Shawn Guo, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 8f887b78961c935a54bb2b5d4dc2c25f869c3723
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/8f887b78961c935a54bb2b5d4dc2c25f869c3723
Author: YueHaibing <yuehaibing@huawei.com>
AuthorDate: Thu, 17 Mar 2022 21:19:56 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Thu, 17 Mar 2022 15:29:04
irq/qcom-mpm: Fix build error without MAILBOX
If MAILBOX is n, building fails:
drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
Make QCOM_MPM depends on MAILBOX to fix this.
Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220317131956.30004-1-yuehaibing@huawei.com
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 680d2fc..15edb9a 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -433,6 +433,7 @@ config QCOM_PDC
config QCOM_MPM
tristate "QCOM MPM"
depends on ARCH_QCOM
+ depends on MAILBOX
select IRQ_DOMAIN_HIERARCHY
help
MSM Power Manager driver to manage and configure wakeup
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [irqchip: irq/irqchip-fixes] irq/qcom-mpm: Fix build error without MAILBOX
2022-03-17 13:19 [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX YueHaibing
2022-03-17 13:59 ` Shawn Guo
2022-03-17 15:33 ` [irqchip: irq/irqchip-next] " irqchip-bot for YueHaibing
@ 2022-04-05 15:40 ` irqchip-bot for YueHaibing
2 siblings, 0 replies; 5+ messages in thread
From: irqchip-bot for YueHaibing @ 2022-04-05 15:40 UTC (permalink / raw)
To: linux-kernel; +Cc: YueHaibing, Shawn Guo, Marc Zyngier, tglx
The following commit has been merged into the irq/irqchip-fixes branch of irqchip:
Commit-ID: fa4dcc880390fbedf4118e9f88a6b13363e0a7a1
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/fa4dcc880390fbedf4118e9f88a6b13363e0a7a1
Author: YueHaibing <yuehaibing@huawei.com>
AuthorDate: Thu, 17 Mar 2022 21:19:56 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Tue, 05 Apr 2022 16:33:13 +01:00
irq/qcom-mpm: Fix build error without MAILBOX
If MAILBOX is n, building fails:
drivers/irqchip/irq-qcom-mpm.o: In function `mpm_pd_power_off':
irq-qcom-mpm.c:(.text+0x174): undefined reference to `mbox_send_message'
irq-qcom-mpm.c:(.text+0x174): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `mbox_send_message'
Make QCOM_MPM depends on MAILBOX to fix this.
Fixes: a6199bb514d8 ("irqchip: Add Qualcomm MPM controller driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220317131956.30004-1-yuehaibing@huawei.com
---
drivers/irqchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index 680d2fc..15edb9a 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -433,6 +433,7 @@ config QCOM_PDC
config QCOM_MPM
tristate "QCOM MPM"
depends on ARCH_QCOM
+ depends on MAILBOX
select IRQ_DOMAIN_HIERARCHY
help
MSM Power Manager driver to manage and configure wakeup
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-06 1:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-17 13:19 [PATCH -next] irq/qcom-mpm: Fix build error without MAILBOX YueHaibing
2022-03-17 13:59 ` Shawn Guo
2022-03-17 15:27 ` Marc Zyngier
2022-03-17 15:33 ` [irqchip: irq/irqchip-next] " irqchip-bot for YueHaibing
2022-04-05 15:40 ` [irqchip: irq/irqchip-fixes] " irqchip-bot for YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox