ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)

ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)

[Andrey Golovko]

Hi,

On an ASUS ProArt PX13 HN7306EAC (Ryzen AI MAX+ 395, AMD ACP rev 0x70,
two TAS2783 at unique_id 0x8/0xB plus RT721 on SoundWire link 1), audio
is silent after resume from s2idle whenever the platform actually reaches
S0i3. Playback runs with no error whatsoever - no XRUN at first, no
prepare failure, no bus error - and the speakers stay quiet until the PCM
is fully torn down and recreated.

This is with v7.2-rc4 plus 5893013efabb ("ASoC: amd: ps: disable MSI on
resume in ACP PCI driver"), which is what makes the peripherals re-attach
at all on this board [1], and with a local fix that drops the stale
tas2783 regcache on re-attach [2]. Both are necessary here; neither is
sufficient.

I measured where the audio stops, and the answer is not where I expected.

1. The ACP side is healthy
--------------------------
I dumped the ACP registers that the driver programs (ring buffer address
and size, FIFO address and size, DMA size, watermark, stream enable, plus
the SoundWire manager block) during actual playback, once in the silent
state after resume and once after the workaround restored audio.

72 of 78 registers are bit-identical. The only differences are
ACP_EXTERNAL_INTR_CNTL (one extra bit, 0x10000 = PDM_DMA_INTR_MASK, i.e.
the digital mics, unrelated to this stream) and the last immediate
command/response pair on the bus.

That is expected: acp63_sdw_pcm_resume() reprograms the PTE, the ring
buffer, the watermark and the DMA interrupt masks for every live
substream on system resume. The ACP DMA configuration is restored
correctly.

2. The DMA is running at the correct rate while silent
------------------------------------------------------
Sampling ACP_P1_AUDIO1_TX_LINEARPOSITIONCNTR every 500 ms during silent
playback:

  0x000002FBF880  +96064
  0x000002FD6F80  +96000
  0x000002FEE6C0  +96064
  0x000003005E00  +96064
  0x00000301D500  +96000

96000 bytes per 500 ms = 192000 B/s = 48000 Hz x 2 ch x 2 bytes, exactly
nominal. The ACP is fetching the buffer and feeding the SoundWire FIFO
the whole time the speakers are silent.

3. The peripheral port never finishes preparing
-----------------------------------------------
Dumping /sys/kernel/debug/soundwire/master-0-1/sdw:*/registers during
playback, silent state versus working state, the entire difference across
all three peripherals is two registers - and it is the same register on
both amplifiers:

  DP1 0x104 (DPn_PrepareStatus):  silent = 0x3   working = 0x0

with DPn_PrepareCtrl (0x105) = 0x3 and DPn_ChannelEn = 0x3 in both cases.
(The third difference is SCP_Int1 on one amp, i.e. transient interrupt
status.)

Per the core's own reading of that register - "Poll for NOT_PREPARED==0"
in sdw_prep_deprep_slave_ports() - a set bit means the channel is *not*
prepared. So after the power gate both amps sit with both channels
unprepared, indefinitely, while the manager streams data at them.

4. Why nothing complains
------------------------
tas2783-sdw declares simple_ch_prep_sm, so the core skips its entire
prepare block: it neither writes DPn_PrepareCtrl nor polls
DPn_PrepareStatus. The driver writes DPn_PrepareCtrl itself from
tas_port_prep() - as the comment there says, "TAS2783 requires explicit
port prepare during playback stream setup even when simple_ch_prep_sm is
enabled. Without this, the port fails to enter the prepared state
resulting in no audio output" - but nobody ever checks whether the port
actually reached the prepared state.

The result is a completely silent failure: the stream is enabled, the DMA
runs, the log is clean, and there is no sound.

What restores it is a full teardown: hw_free (which de-prepares the port,
writing DPn_PrepareCtrl = 0) followed by hw_params and a fresh prepare.
Re-preparing without the de-prepare - which is what a plain userspace
resume does - leaves DPn_PrepareStatus stuck. On this board I work around
it by cycling the card profile after every resume, which forces that
teardown.

Questions
---------
 - Should TAS2783 declare simple_ch_prep_sm at all? The port evidently
   does not prepare instantaneously, which is the premise of that
   property; letting the core do its normal write-and-poll would at least
   turn this into a visible error instead of silence.
 - If the property is correct, should tas_port_prep() poll
   DPn_PrepareStatus after writing DPn_PrepareCtrl, mirroring what the
   core does?
 - Either way: why does a fresh prepare not complete after the device has
   lost power, when a de-prepare followed by a prepare does? If the amp
   needs the port explicitly de-prepared before it will accept a new
   prepare after a power cycle, that sequencing has to happen somewhere
   on resume.

Happy to test patches, dump additional registers, or run traces on this
hardware.

[1] https://lore.kernel.org/all/466a905d-8203-46d2-bfe4-a3b3f9b5d68b@montane.tech/
[2] https://lore.kernel.org/all/bb5064629ada99fa5163621f72fbd27f@gmail.com/

Thanks,
Andrey

Re: ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)

[Pierre-Louis Bossart]

On 7/27/26 11:33, Andrey Golovko wrote:
> Hi,
> 
> On an ASUS ProArt PX13 HN7306EAC (Ryzen AI MAX+ 395, AMD ACP rev 0x70,
> two TAS2783 at unique_id 0x8/0xB plus RT721 on SoundWire link 1), audio
> is silent after resume from s2idle whenever the platform actually reaches
> S0i3. Playback runs with no error whatsoever - no XRUN at first, no
> prepare failure, no bus error - and the speakers stay quiet until the PCM
> is fully torn down and recreated.
> 
> This is with v7.2-rc4 plus 5893013efabb ("ASoC: amd: ps: disable MSI on
> resume in ACP PCI driver"), which is what makes the peripherals re-attach
> at all on this board [1], and with a local fix that drops the stale
> tas2783 regcache on re-attach [2]. Both are necessary here; neither is
> sufficient.
> 
> I measured where the audio stops, and the answer is not where I expected.
> 
> 1. The ACP side is healthy
> --------------------------
> I dumped the ACP registers that the driver programs (ring buffer address
> and size, FIFO address and size, DMA size, watermark, stream enable, plus
> the SoundWire manager block) during actual playback, once in the silent
> state after resume and once after the workaround restored audio.
> 
> 72 of 78 registers are bit-identical. The only differences are
> ACP_EXTERNAL_INTR_CNTL (one extra bit, 0x10000 = PDM_DMA_INTR_MASK, i.e.
> the digital mics, unrelated to this stream) and the last immediate
> command/response pair on the bus.
> 
> That is expected: acp63_sdw_pcm_resume() reprograms the PTE, the ring
> buffer, the watermark and the DMA interrupt masks for every live
> substream on system resume. The ACP DMA configuration is restored
> correctly.
> 
> 2. The DMA is running at the correct rate while silent
> ------------------------------------------------------
> Sampling ACP_P1_AUDIO1_TX_LINEARPOSITIONCNTR every 500 ms during silent
> playback:
> 
>   0x000002FBF880  +96064
>   0x000002FD6F80  +96000
>   0x000002FEE6C0  +96064
>   0x000003005E00  +96064
>   0x00000301D500  +96000
> 
> 96000 bytes per 500 ms = 192000 B/s = 48000 Hz x 2 ch x 2 bytes, exactly
> nominal. The ACP is fetching the buffer and feeding the SoundWire FIFO
> the whole time the speakers are silent.
> 
> 3. The peripheral port never finishes preparing
> -----------------------------------------------
> Dumping /sys/kernel/debug/soundwire/master-0-1/sdw:*/registers during
> playback, silent state versus working state, the entire difference across
> all three peripherals is two registers - and it is the same register on
> both amplifiers:
> 
>   DP1 0x104 (DPn_PrepareStatus):  silent = 0x3   working = 0x0
> 
> with DPn_PrepareCtrl (0x105) = 0x3 and DPn_ChannelEn = 0x3 in both cases.
> (The third difference is SCP_Int1 on one amp, i.e. transient interrupt
> status.)
> 
> Per the core's own reading of that register - "Poll for NOT_PREPARED==0"
> in sdw_prep_deprep_slave_ports() - a set bit means the channel is *not*
> prepared. So after the power gate both amps sit with both channels
> unprepared, indefinitely, while the manager streams data at them.
> 
> 4. Why nothing complains
> ------------------------
> tas2783-sdw declares simple_ch_prep_sm, so the core skips its entire
> prepare block: it neither writes DPn_PrepareCtrl nor polls
> DPn_PrepareStatus. The driver writes DPn_PrepareCtrl itself from
> tas_port_prep() - as the comment there says, "TAS2783 requires explicit
> port prepare during playback stream setup even when simple_ch_prep_sm is
> enabled. Without this, the port fails to enter the prepared state
> resulting in no audio output" - but nobody ever checks whether the port
> actually reached the prepared state.
> 
> The result is a completely silent failure: the stream is enabled, the DMA
> runs, the log is clean, and there is no sound.
> 
> What restores it is a full teardown: hw_free (which de-prepares the port,
> writing DPn_PrepareCtrl = 0) followed by hw_params and a fresh prepare.
> Re-preparing without the de-prepare - which is what a plain userspace
> resume does - leaves DPn_PrepareStatus stuck. On this board I work around
> it by cycling the card profile after every resume, which forces that
> teardown.

Just to be clear: are you referring to a scenario where audio playback
is on-going, the device does a system suspend during the audio playback
due to a user request, and on resume audio is supposed to restart playing?

That's not an easy capability to test/automate. When I worked with
Intel, we had scripts to force a suspend-resume with aplay running in
the background. They worked most of the time except when they didn't...

> Questions
> ---------
>  - Should TAS2783 declare simple_ch_prep_sm at all? The port evidently
>    does not prepare instantaneously, which is the premise of that
>    property; letting the core do its normal write-and-poll would at least
>    turn this into a visible error instead of silence.
>  - If the property is correct, should tas_port_prep() poll
>    DPn_PrepareStatus after writing DPn_PrepareCtrl, mirroring what the
>    core does?

It'd be surprising, these registers are typically updated quickly and if
the sequence works for one playback it should work timing wise after resume.

Anyways, adding Niranjan H Y who contributed the patch "ASoC: tas2783A:
add explicit port prepare handling". The topic of this prepare bit was
discussed in the thread "SoundWire: Allow Prepare command for
Simplified_CP_SM" and we ended-up with the use of this port_prep
callback. IIRC the use of the simple_ch_prep_sm was due to Windows/BIOS
precedent.

Note that there was a change in the full port-prepare programming
sequence, we've since stopped using this interrupt due to other deadlock
problems (see "soundwire: stream: Poll for DP prepare to avoid interrupt
deadlock"). It could very well be that this driver can now use the full
state machine, who knows.

>  - Either way: why does a fresh prepare not complete after the device has
>    lost power, when a de-prepare followed by a prepare does? If the amp
>    needs the port explicitly de-prepared before it will accept a new
>    prepare after a power cycle, that sequencing has to happen somewhere
>    on resume.

It could be that the use of the port_prep callback is restricted to the
initial stream setup. I am not sure if that stream callback is invoked a
second time after a suspend-resume cycle, this driver is the only one
who makes use of that callback...

Alternatively it could be that something else remains stuck and prevents
the port prepare sequence from completing.

Re: ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)

[Holalu Yogendra, Niranjan]

> On 19:39-20260727, Pierre-Louis Bossart wrote:
> Subject: Re: ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)
> 
> >On 7/27/26 11:33, Andrey Golovko wrote:

> > Questions
> > ---------
> >  - Should TAS2783 declare simple_ch_prep_sm at all? The port evidently
> >    does not prepare instantaneously, which is the premise of that
> >    property; letting the core do its normal write-and-poll would at least
> >    turn this into a visible error instead of silence.
> >  - If the property is correct, should tas_port_prep() poll
> >    DPn_PrepareStatus after writing DPn_PrepareCtrl, mirroring what the
> >    core does?

We need to use the same BIOS between Windows and Linux, the BIOS sets the device as Simplified_CP_SM.

The device expects the DPn_PrepareCtrl bits to be set to be functional - but doesn't update DPn_PrepareStatus.

If the device is configured as generic CP_SM, the DPn_PrepareStatus bits will not be updated.
Hence we end up with port prepare fail errors even for normal scenario where it could produce audio.
So, the changes were added in the codec driver to explicitly write DPn_PrepareCtrl even in simplified CP_SM
and ignore the DPn_PrepareStatus. 

Regards
Niranjan

Re: ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)

[Andrey Golovko]

Hi Niranjan, Pierre-Louis,

thanks to both - answers and new data inline.

Pierre-Louis wrote:
> Just to be clear: are you referring to a scenario where audio playback
> is on-going, the device does a system suspend during the audio playback
> due to a user request, and on resume audio is supposed to restart
> playing?

Not necessarily on-going playback - that's the point that makes this
hit ordinary users. PipeWire keeps the PCM substream open the whole
session, so the substream survives the suspend regardless of whether
anything was audibly playing. After resume, even a stream started
*fresh* by an application plays into that surviving substream and is
silent. The only way to get sound back is to force the substream
through hw_free + hw_params (I cycle the card profile, which PipeWire
translates into exactly that).

So the reproduction is deterministic and needs no aplay-in-background
race: boot, let PipeWire open the device, systemctl suspend for
>= 1 min (enough for amd_pmc to report real S0i3 residency; without
residency the bug does not reproduce), resume, start any playback.
Silent every time here.

> It could be that the use of the port_prep callback is restricted to the
> initial stream setup. I am not sure if that stream callback is invoked a
> second time after a suspend-resume cycle

I can answer that with a trace rather than a guess, with one caveat:
stock ps-sdw-dma.c advertises SNDRV_PCM_INFO_RESUME, so a plain resume
takes TRIGGER_RESUME and skips the prepare path entirely - no stream
callbacks at all. With a local patch dropping INFO_RESUME (so userspace
does a full snd_pcm_prepare recovery), the resume-spanning ftrace shows
the complete sequence running after resume: sdw_prepare_stream ->
sdw_prep_deprep_slave_ports -> tas_port_prep() invoked again, 4 calls
(2 amps x 2 callbacks), DPn_PrepareCtrl written with the right masks,
then enable. So the callback *is* invoked on the recovery path - and
the amps are still silent.

The one thing that separates every silent case from every working case
in my traces is the de-prepare: the working path (hw_free) writes
DPn_PrepareCtrl = 0 first, then a fresh prepare writes 3. The silent
path re-writes 3 over 3. After the device has lost power and been
re-initialized (SW_RESET + firmware re-download on re-attach), a
rewrite of the same value evidently does not re-arm anything; the
0 -> 3 edge does.

Niranjan wrote:
> The device expects the DPn_PrepareCtrl bits to be set to be functional -
> but doesn't update DPn_PrepareStatus.

Thanks, that explains the design - I'll withdraw the "port prepare
never completes" framing then, since it leaned on reading
DPn_PrepareStatus, and per your description those bits are not to be
interpreted in Simplified_CP_SM.

One empirical note, for what it's worth: on this hardware 0x104 is not
static. Across all my dumps, on both amplifiers, it reads 0x3 in every
silent state and 0x0 in every working state, tracking the audible state
exactly. I'm not suggesting polling it - just that on this part the
register does reflect something about the port state.

Which leaves the practical question for TI:

  After the amplifier loses power while the manager is power-gated
  (attach as UNINITIALIZED, SW_RESET, firmware re-download), what does
  the device need before a port prepare takes effect again? Empirically
  writing DPn_PrepareCtrl = 0 and then 3 works, while writing 3 alone
  does not. If the 0 -> 3 sequence is genuinely required, where should
  it live - tas_port_prep() unconditionally de-preparing before
  preparing, or the codec driver de-preparing its ports as part of the
  re-attach re-init?

If TI can confirm the required sequence I'm happy to write and test the
patch on this hardware - I already have the register dumps and traces
automated.

Thanks,
Andrey