* [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
@ 2024-05-15 15:03 Julien Panis
2024-05-15 15:22 ` Nicolas Pitre
2024-05-16 9:08 ` AngeloGioacchino Del Regno
0 siblings, 2 replies; 3+ messages in thread
From: Julien Panis @ 2024-05-15 15:03 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, Nicolas Pitre
Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek,
Julien Panis
Filtered mode is not supported on mt8188 SoC and is the source of bad
results. Move to immediate mode which provides good temperatures.
Signed-off-by: Julien Panis <jpanis@baylibre.com>
---
Filtered mode was set by mistake and difficulties with the test setup
prevented from catching this earlier. Use default mode (immediate mode)
instead.
---
drivers/thermal/mediatek/lvts_thermal.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 0bb3a495b56e..82c355c466cf 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 1),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};
@@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(0, 1, 0, 0),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x200,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x300,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};
---
base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1
Best regards,
--
Julien Panis <jpanis@baylibre.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
2024-05-15 15:03 [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188 Julien Panis
@ 2024-05-15 15:22 ` Nicolas Pitre
2024-05-16 9:08 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Pitre @ 2024-05-15 15:22 UTC (permalink / raw)
To: Julien Panis
Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Matthias Brugger, AngeloGioacchino Del Regno, linux-pm,
linux-kernel, linux-arm-kernel, linux-mediatek
On Wed, 15 May 2024, Julien Panis wrote:
> Filtered mode is not supported on mt8188 SoC and is the source of bad
> results. Move to immediate mode which provides good temperatures.
>
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
Reviewed-by: Nicolas Pitre <npitre@baylibre.com>
> ---
> Filtered mode was set by mistake and difficulties with the test setup
> prevented from catching this earlier. Use default mode (immediate mode)
> instead.
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 0bb3a495b56e..82c355c466cf 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 1),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
> @@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(0, 1, 0, 0),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x200,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x300,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
>
> ---
> base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
> change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1
>
> Best regards,
> --
> Julien Panis <jpanis@baylibre.com>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188
2024-05-15 15:03 [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188 Julien Panis
2024-05-15 15:22 ` Nicolas Pitre
@ 2024-05-16 9:08 ` AngeloGioacchino Del Regno
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-05-16 9:08 UTC (permalink / raw)
To: Julien Panis, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba, Matthias Brugger, Nicolas Pitre
Cc: linux-pm, linux-kernel, linux-arm-kernel, linux-mediatek
Il 15/05/24 17:03, Julien Panis ha scritto:
> Filtered mode is not supported on mt8188 SoC and is the source of bad
> results. Move to immediate mode which provides good temperatures.
>
> Signed-off-by: Julien Panis <jpanis@baylibre.com>
Please add the relevant Fixes tag, after which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> Filtered mode was set by mistake and difficulties with the test setup
> prevented from catching this earlier. Use default mode (immediate mode)
> instead.
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 0bb3a495b56e..82c355c466cf 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 1),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
> @@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(0, 1, 0, 0),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x200,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x300,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
>
> ---
> base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
> change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-16 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-15 15:03 [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188 Julien Panis
2024-05-15 15:22 ` Nicolas Pitre
2024-05-16 9:08 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox